Skip to content

Conversation

@jbinda
Copy link

@jbinda jbinda commented Feb 4, 2020

Updates Gutenberg so the Group block is available in production.

Gutenberg PR: WordPress/gutenberg#20004

To test:

  • Run the app without metro running
  • Start a new post
  • Verify Group block is visible in the block picker
  • Select the Group block
  • Verify it is working as expected:
    • Try to break it
    • Use try portrait & landscape modes
    • Try nesting it more than expected
    • Check if the navigation button on FloatingToolbar works
    • Check if AppenderButton is visible when Group is selected
    • Check if AppenderButton is show as placeholder when Group is unselected
    • Check if AppenderButton open the Inserter after press (when Group block is empty and when it already has some nested blocks)
    • Move the block between other ones inside a Group and check it works correctly
    • Move the whole Group block between another Group blocks in RootList
    • Try to use Ungroup button on Toolbar
    • Remove the block
    • Add one again
  • Save as draft
  • Open your draft and check the Group block is shown correctly

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jbinda jbinda requested a review from pinarol February 4, 2020 15:22
@jbinda jbinda self-assigned this Feb 4, 2020
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 4, 2020

You can test the changes on this Pull Request by downloading the APK here.

@pinarol pinarol requested review from chipsnyder and removed request for pinarol February 5, 2020 15:20
@@ -1,6 +1,10 @@
14.3
-----
* Block editor: New Group block for nesting blocks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add this since we are already mentioning it in gutenberg-mobile release notes.

@pinarol
Copy link
Contributor

pinarol commented Feb 5, 2020

We don't need to merge this PR. Let's just use it for testing.

@chipsnyder
Copy link
Contributor

Looks good. 👍Great work WordPress/gutenberg#20004 (review)

@pinarol
Copy link
Contributor

pinarol commented Feb 5, 2020

@jbinda I have one request from you. Could you add some of the test from this PR to this file under "Group-1" title? It is not super urgent, we can do that in 2 weeks. But it'll be very helpful for upcoming sanity tests. Some test cases can really benefit from screenshots, in that case let's follow the method we used for other tests that has links provided like: "Gallery block - Add Gallery Caption - steps". Please ping me if you have any questions. Thanks!

@jbinda
Copy link
Author

jbinda commented Feb 6, 2020

@pinarol Sure I will handle that

@jbinda
Copy link
Author

jbinda commented Feb 6, 2020

@chipsnyder thanks for testing and review ! :)

@jbinda
Copy link
Author

jbinda commented Feb 6, 2020

Closed because it was opened just for testing purpose

@jbinda jbinda closed this Feb 6, 2020
@jkmassel jkmassel deleted the update-gutenberg-group-block branch October 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants