-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enable Group block in production #11231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
| @@ -1,6 +1,10 @@ | |||
| 14.3 | |||
| ----- | |||
| * Block editor: New Group block for nesting blocks. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to add this since we are already mentioning it in gutenberg-mobile release notes.
|
We don't need to merge this PR. Let's just use it for testing. |
|
Looks good. 👍Great work WordPress/gutenberg#20004 (review) |
|
@jbinda I have one request from you. Could you add some of the test from this PR to this file under "Group-1" title? It is not super urgent, we can do that in 2 weeks. But it'll be very helpful for upcoming sanity tests. Some test cases can really benefit from screenshots, in that case let's follow the method we used for other tests that has links provided like: "Gallery block - Add Gallery Caption - steps". Please ping me if you have any questions. Thanks! |
|
@pinarol Sure I will handle that |
|
@chipsnyder thanks for testing and review ! :) |
|
Closed because it was opened just for testing purpose |
Updates Gutenberg so the
Groupblock is available in production.Gutenberg PR: WordPress/gutenberg#20004To test:
GroupblockFloatingToolbarworksAppenderButtonis visible whenGroupis selectedAppenderButtonis show as placeholder whenGroupis unselectedAppenderButtonopen theInserterafter press (whenGroupblock is empty and when it already has some nested blocks)Groupand check it works correctlyGroupblock between anotherGroupblocks in RootListUngroupbutton onToolbarPR submission checklist:
RELEASE-NOTES.txtif necessary.