[RNMobile] Performance improvements in Video related controls #28220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: +82 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
This was referenced Jan 15, 2021
lukewalczak
added
[Type] Performance
dratwas
approved these changes
Jan 27, 2021
Member
Author
|
Hello @gziolo, could you please take a look at the changes and confirm that they are in line with web development? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after
LatestPostPR: #28205Description
Part of: #28196
Contains changes only related to the
Videoblock and controls available within block settings and inherit changes fromLatest PostsPR.VideoCommonSettingsToggleControlSelectControlHow has this been tested?
Test manually
Videoblock on web and mobile.Videoblock add attach the videoExpect all the enabled options works correctly
Screenshots
RESULTS
1. toggling one of video setting option
Types of changes
Performance improvements
Checklist: