[RNMobile] Performance improvements in Columns and Column related controls #28227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
6 tasks
lukewalczak
added
[Type] Performance
dratwas
requested changes
Jan 25, 2021
lukewalczak
requested review from
ajitbohra and
chrisvanpatten
as code owners
dratwas
approved these changes
Jan 29, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after
FilePR: #28220Description
Part of: #28196
Contains changes only related to the
ColumnandColumnsblock and controls available within block settings and inherit changes fromFilePR.RangeControlUnitControlUnitControlFooterMessageControlUnitControlFooterMessageControlHow has this been tested?
Do sanity testing for
Columnsblock using instructions from test casesScreenshots
RESULTS
In
Columnswe cannot avoid re-rendering other controls since they includes component called preview that indicates fill level which each column will take in reference to all available space, however we can avoid re-renders in footer message.1. changing one of the column width
Types of changes
Performance improvements
Checklist: