[RNMobile] Search Block: Add block toolbar options #28985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 12, 2021 20:15
Only adds a shell of a block.
This alert will be removed once styling is added in a later PR.
AmandaRiu
added
[Block] Search
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
7 tasks
AmandaRiu
changed the base branch from
master
to
rnmobile/3073-search-block-1
2 tasks
cameronvoell
approved these changes
Feb 22, 2021
Member
cameronvoell
left a comment
cameronvoell
left a comment
There was a problem hiding this comment.
Changes look good. Nice job moving forward with search block 👍
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #28983 by adding the block toolbar options. All options work, but since some Block UI elements are still yet to be implemented, the UI will not reflect those changes (even though the updates to the block attributes still work). To get around this I have added a temporary alert when the following options change to notify the tester that the change has completed successfully:
For reasons I'm unsure of, the alert message will pop up and dismiss immediately on iOS. If it's difficult to catch the message, changes can also be verified by switching to the HTML view and verifying the option change there.
How has this been tested?
Tested in the demo and WordPress apps for both iOS and Android platforms.
Add a search block to the editor by selecting it from the block inserter, then continue with the following steps. Each section is broken up by the toolbar option under test for clarity. The search block currently only has a single UI element: the search label. This is how it looks when first added:
Test toggle label
Test button position
Menu options
Test icon only
Screenshots
Types of changes
New feature - continues to build on the Search block feature which will span multiple PRs.
Checklist: