[RNMobile] Added Audio block to the initial html #29056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +176 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
2 tasks
ceyhun
approved these changes
Feb 19, 2021
Member
ceyhun
left a comment
ceyhun
left a comment
There was a problem hiding this comment.
Tested on iOS and Android simulators with the demo app and it's looking good 👍 React Native E2E Tests (iOS) test had failed and I restarted it. I think it's not related to this PR and it's just flaky at the moment.
Contributor
Author
Thanks for the review 🙇 I saw the appium PR that would allow us to grab the log from the failed tests, so hopefully, that will assist with diagnosis. |
Contributor
Author
|
@ceyhun I just realized the wordpress-mobile/gutenberg-mobile#3168 PR wasn't approved but I know it was probably due to the failing e2e test so we can determine next week if we are merging with the flaky test or if we want to get it resolved and then do merges 🙏 |
Member
Oh, I think I just overlooked it, will look into it now, sorry about that 😅 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A section was created with the File and Audio block in the initial HTML that is shown when the editor loads in debug mode.
How has this been tested?
Screenshots
Types of changes
Checklist: