Skip to content

Conversation

@jd-alexander
Copy link
Contributor

gutenberg PR WordPress/gutenberg#29056

To test:
See WordPress/gutenberg#29056

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@jd-alexander jd-alexander added the Testing Anything related to automated tests label Feb 17, 2021
@jd-alexander jd-alexander added this to the 1.48.0 (16.9) milestone Feb 17, 2021
@jd-alexander jd-alexander requested a review from ceyhun February 17, 2021 15:55
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 19, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-alexander jd-alexander merged commit daba192 into develop Feb 23, 2021
@jd-alexander jd-alexander deleted the fix/add-audio-block-to-initial-html branch February 23, 2021 00:30
@fluiddot
Copy link
Contributor

👋 I've noticed that this PR was merged with the Gutenberg reference pointing to a commit from the Gutenberg PR instead to the merge commit. I'll make a new PR updating the Gutenberg reference.

@fluiddot
Copy link
Contributor

Here is the PR that fixes it.

@jd-alexander
Copy link
Contributor Author

👋 I've noticed that this PR was merged with the Gutenberg reference pointing to a commit from the Gutenberg PR instead to the merge commit. I'll make a new PR updating the Gutenberg reference.

Thanks @fluiddot I thought it was fine to point it to the final commit containing the changes. I will point to the merge commit from now on. 🙏🏾

@fluiddot
Copy link
Contributor

👋 I've noticed that this PR was merged with the Gutenberg reference pointing to a commit from the Gutenberg PR instead to the merge commit. I'll make a new PR updating the Gutenberg reference.

Thanks @fluiddot I thought it was fine to point it to the final commit containing the changes. I will point to the merge commit from now on. 🙏🏾

No worries, I saw a reference to this topic in an internal post (p9ugOq-1bP-p2) just in case you want to check it, it's described in one of the last bullet points. Although it's true that it doesn't specifically say to have the reference pointing to the merge commit but I think that's the idea.

@jd-alexander
Copy link
Contributor Author

Awesome! Thanks for sharing It makes sense that this is done especially since when the release is being done it's the merge commits that are utilized. 🙏

@enejb enejb mentioned this pull request Mar 1, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Anything related to automated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants