-
Notifications
You must be signed in to change notification settings - Fork 57
Add audio block to initial html #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
ceyhun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via WordPress/gutenberg#29056
|
👋 I've noticed that this PR was merged with the Gutenberg reference pointing to a commit from the Gutenberg PR instead to the merge commit. I'll make a new PR updating the Gutenberg reference. |
|
Here is the PR that fixes it. |
Thanks @fluiddot I thought it was fine to point it to the final commit containing the changes. I will point to the merge commit from now on. 🙏🏾 |
No worries, I saw a reference to this topic in an internal post (p9ugOq-1bP-p2) just in case you want to check it, it's described in one of the last bullet points. Although it's true that it doesn't specifically say to have the reference pointing to the merge commit but I think that's the idea. |
|
Awesome! Thanks for sharing It makes sense that this is done especially since when the release is being done it's the merge commits that are utilized. 🙏 |
gutenberg PRWordPress/gutenberg#29056To test:
See WordPress/gutenberg#29056
PR submission checklist: