Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8623d6e
feat(infinite-hits): implement `transformItems`
francoischalifour Jul 20, 2018
56da733
feat(hits): implement `transformItems`
francoischalifour Jul 20, 2018
85033ec
feat(breadcrumb): implement `transformItems`
francoischalifour Jul 20, 2018
f5aec2e
feat(hierarchical-menu): implement `transformItems`
francoischalifour Jul 20, 2018
e9b2d4c
feat(menu): implement `transformItems`
francoischalifour Jul 20, 2018
e55dba2
feat(menu-select): implement `transformItems`
francoischalifour Jul 20, 2018
1818edb
feat(refinement-list): implement `transformItems`
francoischalifour Jul 23, 2018
526d308
feat(geo-search): implement `transformItems`
francoischalifour Jul 23, 2018
c898c4a
feat(sort-by): implement `transformItems`
francoischalifour Jul 23, 2018
ee19dd7
feat(hits-per-page): implement `transformItems`
francoischalifour Jul 23, 2018
93e7af4
feat(current-refined-values): implement `transformItems`
francoischalifour Jul 23, 2018
b0f8611
feat(numeric-refinement-list): implement `transformItems`
francoischalifour Jul 23, 2018
63840dc
feat(numeric-selector): implement `transformItems`
francoischalifour Jul 23, 2018
01e3bb4
refactor(hits): use default identity function for `transformItems`
francoischalifour Jul 27, 2018
ca82ede
refactor(infinite-hits): use default identity function for `transform…
francoischalifour Jul 27, 2018
547f028
test(hits-per-page): migrate to Jest
francoischalifour Jul 30, 2018
b23df37
test(menu): migrate to Jest
francoischalifour Jul 30, 2018
7ffc09b
test(numeric-refinement-list): migrate to Jest
francoischalifour Jul 30, 2018
d74fe50
test(sort-by-selector): migrate to Jest
francoischalifour Jul 30, 2018
9dd9064
test(infinite-hits): migrate to Jest
francoischalifour Jul 30, 2018
54b30cf
test(refinement-list): migrate to Jest
francoischalifour Jul 30, 2018
80ad6e5
test(hits): migrate to Jest
francoischalifour Jul 30, 2018
a8e58b3
test(hierarchical-menu): migrate to Jest
francoischalifour Jul 30, 2018
dcaf3ca
test(current-refined-values): migrate to Jest and remove Lodash imports
francoischalifour Jul 30, 2018
4be30e9
Merge branch 'develop' into feat/transform-items
bobylito Jul 30, 2018
7c10a17
test(refinement-list): update snapshots
francoischalifour Jul 30, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(menu-select): implement transformItems
  • Loading branch information
francoischalifour committed Jul 25, 2018
commit e55dba27700ee8490069903406630544272d8093
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`menuSelect render correctly 1`] = `
exports[`menuSelect render renders correctly 1`] = `
<HeaderFooter-AutoHide
canRefine={true}
cssClasses={
Expand Down Expand Up @@ -46,3 +46,52 @@ exports[`menuSelect render correctly 1`] = `
}
/>
`;

exports[`menuSelect render renders transformed items correctly 1`] = `
<HeaderFooter-AutoHide
canRefine={true}
cssClasses={
Object {
"footer": "ais-menu-select--footer",
"header": "ais-menu-select--header",
"option": "ais-menu-select--option",
"root": "ais-menu-select",
"select": "ais-menu-select--select",
}
}
items={
Array [
Object {
"label": "foo",
"transformed": true,
"value": undefined,
},
Object {
"label": "bar",
"transformed": true,
"value": undefined,
},
]
}
refine={[Function]}
shouldAutoHideContainer={false}
templateProps={
Object {
"templates": Object {
"footer": "",
"header": "",
"item": "{{label}} ({{#helpers.formatNumber}}{{count}}{{/helpers.formatNumber}})",
"seeAllOption": "See all",
},
"templatesConfig": undefined,
"transformData": undefined,
"useCustomCompileOptions": Object {
"footer": false,
"header": false,
"item": false,
"seeAllOption": false,
},
}
}
/>
`;
71 changes: 49 additions & 22 deletions src/widgets/menu-select/__tests__/menu-select-test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import sinon from 'sinon';

import menuSelect from '../menu-select';

describe('menuSelect', () => {
Expand All @@ -13,26 +11,55 @@ describe('menuSelect', () => {
expect(menuSelect.bind(null, { attributeName })).toThrow(/^Usage/);
});

it('render correctly', () => {
const data = { data: [{ name: 'foo' }, { name: 'bar' }] };
const results = { getFacetValues: sinon.spy(() => data) };
const state = { toggleRefinement: sinon.spy() };
const helper = {
toggleRefinement: sinon.stub().returnsThis(),
search: sinon.spy(),
state,
};
const createURL = () => '#';
const ReactDOM = { render: sinon.spy() };
menuSelect.__Rewire__('render', ReactDOM.render);
const widget = menuSelect({
container: document.createElement('div'),
attributeName: 'test',
describe('render', () => {
let ReactDOM;
let data;
let results;
let state;
let helper;

beforeEach(() => {
ReactDOM = { render: jest.fn() };
menuSelect.__Rewire__('render', ReactDOM.render);

data = { data: [{ name: 'foo' }, { name: 'bar' }] };
results = { getFacetValues: jest.fn(() => data) };
state = { toggleRefinement: jest.fn() };
helper = {
toggleRefinement: jest.fn().mockReturnThis(),
search: jest.fn(),
state,
};
});

it('renders correctly', () => {
const widget = menuSelect({
container: document.createElement('div'),
attributeName: 'test',
});

widget.init({ helper, createURL: () => '#', instantSearchInstance: {} });
widget.render({ results, createURL: () => '#', state });

expect(ReactDOM.render.mock.calls[0][0]).toMatchSnapshot();
});

it('renders transformed items correctly', () => {
const widget = menuSelect({
container: document.createElement('div'),
attributeName: 'test',
transformItems: items =>
items.map(item => ({ ...item, transformed: true })),
});

widget.init({ helper, createURL: () => '#', instantSearchInstance: {} });
widget.render({ results, createURL: () => '#', state });

expect(ReactDOM.render.mock.calls[0][0]).toMatchSnapshot();
});

afterEach(() => {
menuSelect.__ResetDependency__('render');
});
const instantSearchInstance = { templatesConfig: undefined };
widget.init({ helper, createURL, instantSearchInstance });
widget.render({ results, createURL, state });
expect(ReactDOM.render.firstCall.args[0]).toMatchSnapshot();
menuSelect.__ResetDependency__('render');
});
});
5 changes: 4 additions & 1 deletion src/widgets/menu-select/menu-select.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ menuSelect({
[ templates.{header,item,footer,seeAllOption} ],
[ transformData.{item} ],
[ autoHideContainer ]
[ transformItems ]
})`;

/**
Expand Down Expand Up @@ -95,6 +96,7 @@ menuSelect({
* @property {MenuSelectTransforms} [transformData] Set of functions to update the data before passing them to the templates.
* @property {boolean} [autoHideContainer=true] Hide the container when there are no items in the menu select.
* @property {MenuSelectCSSClasses} [cssClasses] CSS classes to add to the wrapping elements.
* @property {function(object[]):object[]} [transformItems] Function to transform the items passed to the templates.
*/

/**
Expand Down Expand Up @@ -124,6 +126,7 @@ export default function menuSelect({
templates = defaultTemplates,
transformData,
autoHideContainer = true,
transformItems,
}) {
if (!container || !attributeName) {
throw new Error(usage);
Expand All @@ -149,7 +152,7 @@ export default function menuSelect({

try {
const makeWidget = connectMenu(specializedRenderer);
return makeWidget({ attributeName, limit, sortBy });
return makeWidget({ attributeName, limit, sortBy, transformItems });
} catch (e) {
throw new Error(usage);
}
Expand Down