Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8623d6e
feat(infinite-hits): implement `transformItems`
francoischalifour Jul 20, 2018
56da733
feat(hits): implement `transformItems`
francoischalifour Jul 20, 2018
85033ec
feat(breadcrumb): implement `transformItems`
francoischalifour Jul 20, 2018
f5aec2e
feat(hierarchical-menu): implement `transformItems`
francoischalifour Jul 20, 2018
e9b2d4c
feat(menu): implement `transformItems`
francoischalifour Jul 20, 2018
e55dba2
feat(menu-select): implement `transformItems`
francoischalifour Jul 20, 2018
1818edb
feat(refinement-list): implement `transformItems`
francoischalifour Jul 23, 2018
526d308
feat(geo-search): implement `transformItems`
francoischalifour Jul 23, 2018
c898c4a
feat(sort-by): implement `transformItems`
francoischalifour Jul 23, 2018
ee19dd7
feat(hits-per-page): implement `transformItems`
francoischalifour Jul 23, 2018
93e7af4
feat(current-refined-values): implement `transformItems`
francoischalifour Jul 23, 2018
b0f8611
feat(numeric-refinement-list): implement `transformItems`
francoischalifour Jul 23, 2018
63840dc
feat(numeric-selector): implement `transformItems`
francoischalifour Jul 23, 2018
01e3bb4
refactor(hits): use default identity function for `transformItems`
francoischalifour Jul 27, 2018
ca82ede
refactor(infinite-hits): use default identity function for `transform…
francoischalifour Jul 27, 2018
547f028
test(hits-per-page): migrate to Jest
francoischalifour Jul 30, 2018
b23df37
test(menu): migrate to Jest
francoischalifour Jul 30, 2018
7ffc09b
test(numeric-refinement-list): migrate to Jest
francoischalifour Jul 30, 2018
d74fe50
test(sort-by-selector): migrate to Jest
francoischalifour Jul 30, 2018
9dd9064
test(infinite-hits): migrate to Jest
francoischalifour Jul 30, 2018
54b30cf
test(refinement-list): migrate to Jest
francoischalifour Jul 30, 2018
80ad6e5
test(hits): migrate to Jest
francoischalifour Jul 30, 2018
a8e58b3
test(hierarchical-menu): migrate to Jest
francoischalifour Jul 30, 2018
dcaf3ca
test(current-refined-values): migrate to Jest and remove Lodash imports
francoischalifour Jul 30, 2018
4be30e9
Merge branch 'develop' into feat/transform-items
bobylito Jul 30, 2018
7c10a17
test(refinement-list): update snapshots
francoischalifour Jul 30, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(hits-per-page): implement transformItems
  • Loading branch information
francoischalifour committed Jul 25, 2018
commit ee19dd71756a118b65d5e156e40fd2131ccea5e1
20 changes: 20 additions & 0 deletions dev/app/builtin/stories/hits-per-page-selector.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,25 @@ export default () => {
})
);
})
)
.add(
'with transformed items',
wrapWithHits(container => {
window.search.addWidget(
instantsearch.widgets.hitsPerPageSelector({
container,
items: [
{ value: 3, label: '3 per page' },
{ value: 5, label: '5 per page' },
{ value: 10, label: '10 per page' },
],
transformItems: items =>
items.map(item => ({
...item,
label: `${item.label} (transformed)`,
})),
})
);
})
);
};
39 changes: 39 additions & 0 deletions src/connectors/hits-per-page/__tests__/connectHitsPerPage-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,45 @@ describe('connectHitsPerPage', () => {
});
});

it('Renders during init and render with transformed items', () => {
const rendering = sinon.stub();
const makeWidget = connectHitsPerPage(rendering);
const widget = makeWidget({
items: [
{ value: 3, label: '3 items per page' },
{ value: 10, label: '10 items per page' },
],
transformItems: items =>
items.map(item => ({ ...item, label: 'transformed' })),
});

const helper = jsHelper({}, '', {
hitsPerPage: 3,
});
helper.search = sinon.stub();

widget.init({
helper,
state: helper.state,
});

expect(rendering.lastCall.args[0].items).toEqual([
expect.objectContaining({ label: 'transformed' }),
expect.objectContaining({ label: 'transformed' }),
]);

widget.render({
results: new SearchResults(helper.state, [{}]),
state: helper.state,
helper,
});

expect(rendering.lastCall.args[0].items).toEqual([
expect.objectContaining({ label: 'transformed' }),
expect.objectContaining({ label: 'transformed' }),
]);
});

it('Configures the search with the default hitsPerPage provided', () => {
const rendering = sinon.stub();
const makeWidget = connectHitsPerPage(rendering);
Expand Down
10 changes: 6 additions & 4 deletions src/connectors/hits-per-page/connectHitsPerPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ search.addWidget(
{value: 10, label: '10 results per page'},
{value: 42, label: '42 results per page'},
],
[ transformItems ]
})
);
Full documentation available at https://community.algolia.com/instantsearch.js/v2/connectors/connectHitsPerPage.html
Expand Down Expand Up @@ -50,6 +51,7 @@ Full documentation available at https://community.algolia.com/instantsearch.js/v
/**
* @typedef {Object} HitsPerPageWidgetOptions
* @property {HitsPerPageWidgetOptionsItem[]} items Array of objects defining the different values and labels.
* @property {function(object[]):object[]} [transformItems] Function to transform the items passed to the templates.
*/

/**
Expand Down Expand Up @@ -111,7 +113,7 @@ export default function connectHitsPerPage(renderFn, unmountFn) {
checkRendering(renderFn, usage);

return (widgetParams = {}) => {
const { items: userItems } = widgetParams;
const { items: userItems, transformItems = items => items } = widgetParams;
let items = userItems;

if (!items) {
Expand Down Expand Up @@ -167,7 +169,7 @@ The first one will be picked, you should probably set only one default value`

renderFn(
{
items: this._transformItems(state),
items: transformItems(this._normalizeItems(state)),
refine: this.setHitsPerPage,
hasNoResults: true,
widgetParams,
Expand All @@ -182,7 +184,7 @@ The first one will be picked, you should probably set only one default value`

renderFn(
{
items: this._transformItems(state),
items: transformItems(this._normalizeItems(state)),
refine: this.setHitsPerPage,
hasNoResults,
widgetParams,
Expand All @@ -192,7 +194,7 @@ The first one will be picked, you should probably set only one default value`
);
},

_transformItems({ hitsPerPage }) {
_normalizeItems({ hitsPerPage }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good move 👍

return items.map(item => ({
...item,
isRefined: Number(item.value) === Number(hitsPerPage),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,35 @@ exports[`hitsPerPageSelector() calls twice ReactDOM.render(<Selector props />, c
shouldAutoHideContainer={false}
/>
`;

exports[`hitsPerPageSelector() renders transformed items 1`] = `
<HeaderFooter-AutoHide
cssClasses={
Object {
"item": "ais-hits-per-page-selector--item",
"root": "ais-hits-per-page-selector",
"select": "ais-hits-per-page-selector",
}
}
currentValue={10}
options={
Array [
Object {
"isRefined": true,
"label": "10 results",
"transformed": true,
"value": 10,
},
Object {
"default": true,
"isRefined": false,
"label": "20 results",
"transformed": true,
"value": 20,
},
]
}
setValue={[Function]}
shouldAutoHideContainer={false}
/>
`;
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,23 @@ describe('hitsPerPageSelector()', () => {
expect(ReactDOM.render.firstCall.args[0]).toMatchSnapshot();
});

it('renders transformed items', () => {
widget = hitsPerPageSelector({
container,
items: [
{ value: 10, label: '10 results' },
{ value: 20, label: '20 results', default: true },
],
transformItems: widgetItems =>
widgetItems.map(item => ({ ...item, transformed: true })),
});

widget.init({ helper, state: helper.state });
widget.render({ results, state });

expect(ReactDOM.render.firstCall.args[0]).toMatchSnapshot();
});

it('sets the underlying hitsPerPage', () => {
widget.init({ helper, state: helper.state });
widget.setHitsPerPage(helper, helper.state, 10);
Expand Down
7 changes: 5 additions & 2 deletions src/widgets/hits-per-page-selector/hits-per-page-selector.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ hitsPerPageSelector({
container,
items,
[ cssClasses.{root,select,item}={} ],
[ autoHideContainer=false ]
[ autoHideContainer=false ],
[ transformItems ]
})`;

/**
Expand All @@ -59,6 +60,7 @@ hitsPerPageSelector({
* @property {HitsPerPageSelectorItems[]} items Array of objects defining the different values and labels.
* @property {boolean} [autoHideContainer=false] Hide the container when no results match.
* @property {HitsPerPageSelectorCSSClasses} [cssClasses] CSS classes to be added.
* @property {function(object[]):object[]} [transformItems] Function to transform the items passed to the templates.
*/

/**
Expand Down Expand Up @@ -88,6 +90,7 @@ export default function hitsPerPageSelector({
items,
cssClasses: userCssClasses = {},
autoHideContainer = false,
transformItems,
} = {}) {
if (!container) {
throw new Error(usage);
Expand All @@ -114,7 +117,7 @@ export default function hitsPerPageSelector({
specializedRenderer,
() => unmountComponentAtNode(containerNode)
);
return makeHitsPerPageSelector({ items });
return makeHitsPerPageSelector({ items, transformItems });
} catch (e) {
throw new Error(usage);
}
Expand Down