-
Notifications
You must be signed in to change notification settings - Fork 556
feat: Implement transformItems API
#3042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
8623d6e
feat(infinite-hits): implement `transformItems`
francoischalifour 56da733
feat(hits): implement `transformItems`
francoischalifour 85033ec
feat(breadcrumb): implement `transformItems`
francoischalifour f5aec2e
feat(hierarchical-menu): implement `transformItems`
francoischalifour e9b2d4c
feat(menu): implement `transformItems`
francoischalifour e55dba2
feat(menu-select): implement `transformItems`
francoischalifour 1818edb
feat(refinement-list): implement `transformItems`
francoischalifour 526d308
feat(geo-search): implement `transformItems`
francoischalifour c898c4a
feat(sort-by): implement `transformItems`
francoischalifour ee19dd7
feat(hits-per-page): implement `transformItems`
francoischalifour 93e7af4
feat(current-refined-values): implement `transformItems`
francoischalifour b0f8611
feat(numeric-refinement-list): implement `transformItems`
francoischalifour 63840dc
feat(numeric-selector): implement `transformItems`
francoischalifour 01e3bb4
refactor(hits): use default identity function for `transformItems`
francoischalifour ca82ede
refactor(infinite-hits): use default identity function for `transform…
francoischalifour 547f028
test(hits-per-page): migrate to Jest
francoischalifour b23df37
test(menu): migrate to Jest
francoischalifour 7ffc09b
test(numeric-refinement-list): migrate to Jest
francoischalifour d74fe50
test(sort-by-selector): migrate to Jest
francoischalifour 9dd9064
test(infinite-hits): migrate to Jest
francoischalifour 54b30cf
test(refinement-list): migrate to Jest
francoischalifour 80ad6e5
test(hits): migrate to Jest
francoischalifour a8e58b3
test(hierarchical-menu): migrate to Jest
francoischalifour dcaf3ca
test(current-refined-values): migrate to Jest and remove Lodash imports
francoischalifour 4be30e9
Merge branch 'develop' into feat/transform-items
bobylito 7c10a17
test(refinement-list): update snapshots
francoischalifour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(menu): implement
transformItems
- Loading branch information
commit e9b2d4c7dee65c22c982fc9b7f4a76738fc6e13f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we touch a test file that is still using sinon, we try to take the opportunity to replace it with Jest mocks. Can you do that? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure! I initially didn't want to edit too much code as it was intended to be merged on the yet-to-be consequent
feat/3.0branch.