Skip to content

Ouster sensor integration #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 30, 2025
Merged

Ouster sensor integration #314

merged 14 commits into from
Oct 30, 2025

Conversation

@rosalievanark
Copy link
Collaborator

@rosalievanark rosalievanark commented Oct 20, 2025 •
edited
Loading

Description

Integrate the Ouster LiDaR sensor in simulation.

Todo

  • Create a new issue for selecting a driver for the hardware (once it has arrived)

Testing

Explain how you tested your changes.

Documentation

  • I have updated the documentation (if necessary)

Additional Notes

Any relevant screenshots, logs, or context.

@rosalievanark rosalievanark linked an issue Oct 20, 2025 that may be closed by this pull request
[Sensor] Integrate Ouster simulation #310
Closed
6 tasks
@rosalievanark rosalievanark marked this pull request as ready for review October 24, 2025 12:12
Jelmerdw
Jelmerdw reviewed Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@Jelmerdw Jelmerdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Only minor changes suggested.

I would also rename test_panther_nav2.py to test_panther_nav2_velodyne.py, to be consistent with the new test_panther_nav2_ouster.py.

@Jelmerdw
Copy link
Collaborator

Jelmerdw commented Oct 28, 2025

You only missed panther_lidar and mm_lidar :). If you can change those also to panther_velodyne and mm_veldoyne, I think we can merge afterwards!

@Jelmerdw
Change naming.
d6776d9 
Signed-off-by: Jelmer de Wolde <[email protected]>
@Jelmerdw Jelmerdw merged commit bbcf97c into main Oct 30, 2025
9 checks passed
@Jelmerdw Jelmerdw deleted the 310-sensor-integrate-ouster-simulation branch October 30, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jelmerdw Jelmerdw Jelmerdw left review comments

@geurto geurto geurto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Sensor] Integrate Ouster simulation

4 participants

@rosalievanark @Jelmerdw @geurto