-
Notifications
You must be signed in to change notification settings - Fork 0
Add octomap and visualizations to moveit and rviz. #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
f47bff6 to
d577008
Compare
Signed-off-by: Jelmer de Wolde <[email protected]>
|
When running the robots.launch.py as indicated above, I get [gz-4] [Err] [Physics.cc:1785] Attempting to create a mimic constraint for joint [fr3_finger_joint2] but the chosen physics engine does not support mimic constraints, so no constraint will be created.
[...]
[gz-4] [Err] [Ogre2MeshFactory.cc:595] Cannot load mesh with zero sub-meshes
[gz-4] [Err] [Ogre2MeshFactory.cc:124] Failed to get Ogre item for [/home/rcdt/rcdt_robotics/ros2_ws/install/rcdt_gazebo/share/rcdt_gazebo/models/basket/resources/basket.obj]
[gz-4] [Err] [SceneManager.cc:426] Failed to load geometry for visual: visual
[gz-4] [Err] [Ogre2MeshFactory.cc:595] Cannot load mesh with zero sub-meshes
[gz-4] [Err] [Ogre2MeshFactory.cc:124] Failed to get Ogre item for [/home/rcdt/rcdt_robotics/ros2_ws/install/rcdt_gazebo/share/rcdt_gazebo/models/brick/resources/baksteen.obj]
[gz-4] [Err] [SceneManager.cc:426] Failed to load geometry for visual: visualAnd the simple_gui gives a "No executable found". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a general question than a review comment, is there currently a logic present for the order of function-definitions or is it just "add new functions at the bottom"? Because if that's the case I would like to propose to start putting the functions in alphabetical order to make it easier to read through the code (at least for me).
Not suggesting to change it now but is this maybe something for in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we have no checks on order of functions. I am not sure if this exists, and if so, we would like to do this. I agree that using alphabetic order might make sense in the rviz.py file. But usually, alphabetic order might be more confusing than trying to place related functions close to each other, I think?
Signed-off-by: Rosalie <[email protected]>
rosalievanark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments I left are primarily for my information
Signed-off-by: Jelmer de Wolde <[email protected]>
Description
This PR extends functions for the control of the arm, in preparation of grasping:
Fixes: #222, #278
Testing
You can test all actions by starting the
franka_planningconfiguration in one terminal:and the simple ui in a second terminal:
You should be able to perform all actions in the browser on http://localhost:8080.
Documentation
Additional Notes
Any relevant screenshots, logs, or context.