Omit DeleteOptions in check mode

[efussi]

SUMMARY

Don't set DeleteOptions in k8s when running in check mode.

Fixes #892

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

k8s

ADDITIONAL INFORMATION

See ACTUAL and EXPECTED RESULTS in #892 (comment) for command output before and after the change.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/847fe9d6f9484d00bc0ebb53f3623cdd

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 5m 28s

[abikouo]

You need to add a changelog with something like

---
bugfixes:
  - module_utils/k8s/service - fix issue when trying to delete resource using `delete_options` and `check_mode=true` (https://github.com/ansible-collections/kubernetes.core/issues/892).

It would be nice if you can also update the k8s_delete integration tests target to validate the fix

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2583eeeb22b748ad91d7281c5a3f7def

✔️ ansible-galaxy-importer SUCCESS in 3m 11s
✔️ build-ansible-collection SUCCESS in 5m 44s

[efussi]

Added the changelog fragment and will look at adding an integration test next.

[efussi]

Hint to self: make test-integration only works when the repo is cloned into a particular directory structure, see https://docs.ansible.com/ansible/latest/community/collection_contributors/collection_test_pr_locally.html#how-to-test-a-collection-pr. Next step is to make the existing integration tests pass, currently they all fail.

[efussi]

Notes from setting up the environment to run the integration tests:

• The integration tests modify the cluster pointed at by the current kubeconfig (!!!)
• The Makefile variable to set integration test arguments has an unusual leading ?: make test-integration ?TEST_ARGS=k8s_delete (not sure if $(?TEST_ARGS) has a special meaning in non-GNU variants of make, in my version of make the ? is considered part of the variable name which doesn't match TEST_ARGS ?= "" at the beginning of the Makefile)
• The nginx-d pod started by the k8s_delete test target needs to run as root, this breaks on OpenShift when the default restricted-v2 SCC is used. Prepare the cluster like this:

  oc new-project delete  # ensure integration test namespace `delete` exists
  oc adm policy add-scc-to-user anyuid -z default  # bind the `default` service account to the `anyuid` SCC
  

[efussi]

@abikouo I added an integration test. Can you please let me know if any further changes are needed?

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/beaaa8eb7ef5404a87541d326218b5b9

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 5m 25s

[efussi]

@abikouo This PR is ready for review now. There are some failing tests, but I think that's unrelated to this PR (at least I have no idea what I could do about this):

=========================== short test summary info ============================
FAILED tests/unit/module_utils/test_core.py::test_warn_on_k8s_version[stdin0] - AssertionError: assert 'kubernetes' in {'__ansible_type': 'WarningSummary', 'details': [{'__ansible_type': 'Detail', 'msg': 'kubernetes<24.2.0 is not supported or tested. Some features may not work.'}]}
======================== 1 failed, 185 passed in 15.12s ========================

[yurnov]

@abikouo This PR is ready for review now. There are some failing tests, but I think that's unrelated to this PR (at least I have no ide what I could do about this):

=========================== short test summary info ============================
FAILED tests/unit/module_utils/test_core.py::test_warn_on_k8s_version[stdin0] - AssertionError: assert 'kubernetes' in {'__ansible_type': 'WarningSummary', 'details': [{'__ansible_type': 'Detail', 'msg': 'kubernetes<24.2.0 is not supported or tested. Some features may not work.'}]}
======================== 1 failed, 185 passed in 15.12s ========================

It's an issue with the test for the current devel and milestone branches of ansible. Here is issue #904 and a prepared fix #903

[yurnov]

Hi @efussi

Would you please rebase your PR or merge main into? It should resolve a issue with failing test

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5f6a3f73363d4e2db2f27ea4ad0b734a

✔️ ansible-galaxy-importer SUCCESS in 3m 20s
✔️ build-ansible-collection SUCCESS in 5m 38s

[abikouo]

Replaced by #905
CC @yurnov @beeankha

[efussi]

Hi @efussi

Would you please rebase your PR or merge main into? It should resolve a issue with failing test

@abikouo beat me to it 😄. Thanks for taking care of this!