Skip to content

Rebase PR #898 #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
softwarefactory-project-zuul merged 3 commits into from
Apr 25, 2025
Merged

Rebase PR #898 #905

softwarefactory-project-zuul merged 3 commits into from
Apr 25, 2025

Conversation

@abikouo
Copy link
Contributor

@abikouo abikouo commented Apr 24, 2025

This PR is a rebase of #898 for CI to pass
Thanks @efussi for your collaboration.

Closes #892

@abikouo abikouo requested a review from beeankha April 24, 2025 16:02
@abikouo abikouo mentioned this pull request Apr 24, 2025
Closed
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Apr 24, 2025

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/438109cf6af5490388f669e3d64f42d1

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 5m 32s

@yurnov
Copy link
Contributor

yurnov commented Apr 24, 2025

Hi @abikouo,

to have it backported to stable-3 and stable-5 you would need to backport #903 to the same branches

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Apr 25, 2025

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/a36cd87fcff441ba98b39199396d6a94

✔️ ansible-galaxy-importer SUCCESS in 3m 22s
✔️ build-ansible-collection SUCCESS in 5m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d329e7e into ansible-collections:main Apr 25, 2025
54 checks passed
@patchback
Copy link

patchback bot commented Apr 25, 2025

Beep beep boop!
🤖 Hi, I'm @patchback — your friendly neighborhood robot!

Somebody's just asked me to create a backport of this pull request
into the stable-3 branch. So in this comment I report that
I'm on it!

Please, expect to see further updates regarding my progress in updates
to this comment. Stay tuned!

If you think I'm experiencing problems, ping @webknjaz — my creator.

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Apr 25, 2025 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/d329e7ee42799ae9d86b54cf2c7dfc8059103504/pr-905

Backported as #906

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Apr 25, 2025 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/d329e7ee42799ae9d86b54cf2c7dfc8059103504/pr-905

Backported as #907

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 25, 2025
@abikouo @patchback
Rebase PR #898 (#905)
f724149 
This PR is a rebase of #898 for CI to pass
Thanks @efussi for your collaboration.
Closes #892

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Bianca Henderson <[email protected]>
(cherry picked from commit d329e7e)
patchback bot pushed a commit that referenced this pull request Apr 25, 2025
@abikouo @patchback
Rebase PR #898 (#905)
3b566ce 
This PR is a rebase of #898 for CI to pass
Thanks @efussi for your collaboration.
Closes #892

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Bianca Henderson <[email protected]>
(cherry picked from commit d329e7e)
This was referenced Apr 25, 2025
Closed
Closed
@patchback
Copy link

patchback bot commented Apr 25, 2025 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/d329e7ee42799ae9d86b54cf2c7dfc8059103504/pr-905

Backported as #912

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Apr 25, 2025 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/d329e7ee42799ae9d86b54cf2c7dfc8059103504/pr-905

Backported as #913

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 25, 2025
@abikouo @patchback
Rebase PR #898 (#905)
66bb1d9 
This PR is a rebase of #898 for CI to pass
Thanks @efussi for your collaboration.
Closes #892

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Bianca Henderson <[email protected]>
(cherry picked from commit d329e7e)
patchback bot pushed a commit that referenced this pull request Apr 25, 2025
@abikouo @patchback
Rebase PR #898 (#905)
331ef23 
This PR is a rebase of #898 for CI to pass
Thanks @efussi for your collaboration.
Closes #892

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Bianca Henderson <[email protected]>
(cherry picked from commit d329e7e)
This was referenced Apr 25, 2025
Merged
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 25, 2025
@patchback
Rebase PR #898 (#905) (#913)
349534b 
This is a backport of PR #905 as merged into main (d329e7e).
This PR is a rebase of #898 for CI to pass
Thanks @efussi for your collaboration.
Closes #892

Reviewed-by: Bikouo Aubin
Reviewed-by: Bianca Henderson <[email protected]>
abikouo added a commit that referenced this pull request May 2, 2025
@abikouo
Rebase PR #898 (#905)
7fd4c5f 
This PR is a rebase of #898 for CI to pass
Thanks @efussi for your collaboration.
Closes #892

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Bianca Henderson <[email protected]>
(cherry picked from commit d329e7e)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 2, 2025
@patchback
Rebase PR #898 (#905) (#912)
96464f1 
This is a backport of PR #905 as merged into main (d329e7e).
This PR is a rebase of #898 for CI to pass
Thanks @efussi for your collaboration.
Closes #892

Reviewed-by: Bianca Henderson <[email protected]>
Reviewed-by: Bikouo Aubin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeankha beeankha beeankha approved these changes

+1 more reviewer

@yurnov yurnov yurnov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-3 backport-5 mergeit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kubernetes.core.k8s deletes objects in check mode if delete_options are set

4 participants

@abikouo @yurnov @beeankha @efussi