-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: Add rust-toolchain.toml to ensure consistent toolchain version #7972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f782ef9
chore: Add rust-toolchain.toml to ensure consistent toolchain version
EricccTaiwan 4b229e8
Merge remote-tracking branch 'apache/main' into add-rust-toolchain
alamb ed838ad
Update toolchain setup
alamb 5a772bf
fix
alamb e04bb8a
try 3
alamb 892c5a0
revert
alamb ac2b6ef
install
alamb 3a7decb
move
alamb 1dd7e78
cleaup
alamb 5b94123
install targets
alamb 8089db5
Merge remote-tracking branch 'apache/main' into add-rust-toolchain
alamb 19b28ad
Update to 1.89
alamb 2976c39
Merge branch 'main' into add-rust-toolchain
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
install targets
- Loading branch information
commit 5b94123b08a288edcefc2f63cd8ba2eaf00879ba
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,8 +148,10 @@ jobs: | |
| submodules: true | ||
| - name: Setup Rust toolchain | ||
| uses: ./.github/actions/setup-builder | ||
| with: | ||
| target: wasm32-unknown-unknown,wasm32-wasip1 | ||
| - name: Install wasm32 targets | ||
| run: | | ||
| rustup target add wasm32-unknown-unknown | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| rustup target add wasm32-wasip1 | ||
| - name: Build wasm32-unknown-unknown | ||
| run: cargo build -p arrow --no-default-features --features=json,csv,ipc,ffi --target wasm32-unknown-unknown | ||
| - name: Build wasm32-wasip1 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed these parameters as almost all uses installed stable