-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: Add rust-toolchain.toml to ensure consistent toolchain version #7972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f782ef9
4b229e8
ed838ad
5a772bf
e04bb8a
892c5a0
ac2b6ef
3a7decb
1dd7e78
5b94123
8089db5
19b28ad
2976c39
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,8 +148,10 @@ jobs: | |
| submodules: true | ||
| - name: Setup Rust toolchain | ||
| uses: ./.github/actions/setup-builder | ||
| with: | ||
| target: wasm32-unknown-unknown,wasm32-wasip1 | ||
| - name: Install wasm32 targets | ||
| run: | | ||
| rustup target add wasm32-unknown-unknown | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| rustup target add wasm32-wasip1 | ||
| - name: Build wasm32-unknown-unknown | ||
| run: cargo build -p arrow --no-default-features --features=json,csv,ipc,ffi --target wasm32-unknown-unknown | ||
| - name: Build wasm32-wasip1 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,12 +34,8 @@ jobs: | |
| docs: | ||
| name: Rustdocs are clean | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is let over from a previous time when we checked docs on different configurations -- at the moment there is a single pair that is used, so I unparameterized this and made the version used explicit
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| matrix: | ||
| arch: [ amd64 ] | ||
| rust: [ nightly ] | ||
| container: | ||
| image: ${{ matrix.arch }}/rust | ||
| image: amd64/rust | ||
| env: | ||
| RUSTDOCFLAGS: "-Dwarnings --enable-index-page -Zunstable-options" | ||
| steps: | ||
|
|
@@ -52,10 +48,10 @@ jobs: | |
| apt install -y libpython3.11-dev | ||
| - name: Setup Rust toolchain | ||
| uses: ./.github/actions/setup-builder | ||
| with: | ||
| rust-version: ${{ matrix.rust }} | ||
| - name: Install Nightly Rust | ||
| run: rustup install nightly | ||
| - name: Run cargo doc | ||
| run: cargo doc --document-private-items --no-deps --workspace --all-features | ||
| run: cargo +nightly doc --document-private-items --no-deps --workspace --all-features | ||
| - name: Fix file permissions | ||
| shell: sh | ||
| run: | | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| [toolchain] | ||
| channel = "1.89" | ||
| components = ["rustfmt", "clippy"] |


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed these parameters as almost all uses installed stable