Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
348 changes: 348 additions & 0 deletions parquet-variant-compute/src/cast_to_variant.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,348 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

use crate::{VariantArray, VariantArrayBuilder};
use arrow::array::{Array, AsArray};
use arrow::datatypes::{
Float32Type, Float64Type, Int16Type, Int32Type, Int64Type, Int8Type, UInt16Type, UInt32Type,
UInt64Type, UInt8Type,
};
use arrow_schema::{ArrowError, DataType};
use parquet_variant::Variant;

/// Convert the input array of a specific primitive type to a `VariantArray`
/// row by row
macro_rules! primtive_conversion {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
macro_rules! primtive_conversion {
macro_rules! primitive_conversion {

($t:ty, $input:expr, $builder:expr) => {{
let array = $input.as_primitive::<$t>();
for i in 0..array.len() {
if array.is_null(i) {
$builder.append_null();
continue;
}
$builder.append_variant(Variant::from(array.value(i)));
}
}};
}

/// Casts a typed arrow [`Array`] to a [`VariantArray`]. This is useful when you
/// need to convert a specific data type
///
/// # Arguments
/// * `input` - A reference to the input [`ArrayRef`] to cast
///
/// # Notes
/// If the input array element is null, the corresponding element in the
/// output `VariantArray` will also be null (not `Variant::Null`).
///
/// # Example
/// ```
/// # use arrow::array::{Array, ArrayRef, Int64Array};
/// # use parquet_variant::Variant;
/// # use parquet_variant_compute::cast_to_variant::cast_to_variant;
/// // input is an Int64Array, which will be cast to a VariantArray
/// let input = Int64Array::from(vec![Some(1), None, Some(3)]);
/// let result = cast_to_variant(&input).unwrap();
/// assert_eq!(result.len(), 3);
/// assert_eq!(result.value(0), Variant::Int64(1));
/// assert!(result.is_null(1)); // note null, not Variant::Null
/// assert_eq!(result.value(2), Variant::Int64(3));
/// ```
pub fn cast_to_variant(input: &dyn Array) -> Result<VariantArray, ArrowError> {
let mut builder = VariantArrayBuilder::new(input.len());

let input_type = input.data_type();
// todo: use `downcast_primitive` to avoid the boilerplate and match more types
match input_type {
DataType::Int8 => {
primtive_conversion!(Int8Type, input, builder);
}
DataType::Int16 => {
primtive_conversion!(Int16Type, input, builder);
}
DataType::Int32 => {
primtive_conversion!(Int32Type, input, builder);
}
DataType::Int64 => {
primtive_conversion!(Int64Type, input, builder);
}
DataType::UInt8 => {
primtive_conversion!(UInt8Type, input, builder);
}
DataType::UInt16 => {
primtive_conversion!(UInt16Type, input, builder);
}
DataType::UInt32 => {
primtive_conversion!(UInt32Type, input, builder);
}
DataType::UInt64 => {
primtive_conversion!(UInt64Type, input, builder);
}
DataType::Float32 => {
primtive_conversion!(Float32Type, input, builder);
}
DataType::Float64 => {
primtive_conversion!(Float64Type, input, builder);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what downcast_primitive is, but if we used downcast_primitive_array! macro, I think the code simplifies to just:

Suggested change
let input_type = input.data_type();
// todo: use `downcast_primitive` to avoid the boilerplate and match more types
match input_type {
DataType::Int8 => {
primtive_conversion!(Int8Type, input, builder);
}
DataType::Int16 => {
primtive_conversion!(Int16Type, input, builder);
}
DataType::Int32 => {
primtive_conversion!(Int32Type, input, builder);
}
DataType::Int64 => {
primtive_conversion!(Int64Type, input, builder);
}
DataType::UInt8 => {
primtive_conversion!(UInt8Type, input, builder);
}
DataType::UInt16 => {
primtive_conversion!(UInt16Type, input, builder);
}
DataType::UInt32 => {
primtive_conversion!(UInt32Type, input, builder);
}
DataType::UInt64 => {
primtive_conversion!(UInt64Type, input, builder);
}
DataType::Float32 => {
primtive_conversion!(Float32Type, input, builder);
}
DataType::Float64 => {
primtive_conversion!(Float64Type, input, builder);
}
downcast_primitive_array! {
input => input.iter().for_each(|v| match v {
Some(value) => builder.append_variant(Variant::from(value)),
None => builder.append_null(),
}),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it does. However, when I make this change, I get the following errorrs (because we need to implement conversion to/from the other types (like Decimal128 --> i128)

Screenshot 2025-08-06 at 6 42 20 AM

I think we may have to handle those cases specially. I will file a follow on ticket to do so.

error[E0277]: the trait bound `parquet_variant::Variant<'_, '_>: std::convert::From<half::binary16::f16>` is not satisfied
  --> parquet-variant-compute/src/cast_to_variant.rs:72:52
   |
72 |                 Some(value) => builder.append_variant(Variant::from(value)),
   |                                                       ^^^^^^^ the trait `std::convert::From<half::binary16::f16>` is not implemented for `parquet_variant::Variant<'_, '_>`
   |
   = help: the following other types implement trait `std::convert::From<T>`:
             `parquet_variant::Variant<'_, '_>` implements `std::convert::From<&[u8]>`
             `parquet_variant::Variant<'_, '_>` implements `std::convert::From<&str>`
             `parquet_variant::Variant<'_, '_>` implements `std::convert::From<()>`
             `parquet_variant::Variant<'_, '_>` implements `std::convert::From<bool>`
             `parquet_variant::Variant<'_, '_>` implements `std::convert::From<chrono::datetime::DateTime<chrono::offset::utc::Utc>>`
             `parquet_variant::Variant<'_, '_>` implements `std::convert::From<chrono::naive::date::NaiveDate>`
             `parquet_variant::Variant<'_, '_>` implements `std::convert::From<chrono::naive::datetime::NaiveDateTime>`
             `parquet_variant::Variant<'_, '_>` implements `std::convert::From<f32>`
           and 12 others

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense.

dt => {
return Err(ArrowError::CastError(format!(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of follow on tickets we can perhaps file as follow on work:

  1. Support for timestamps
  2. Support for string / binary arrays
  3. Support for various timestamps types

"Unsupported data type for casting to Variant: {dt:?}",
)));
}
};
Ok(builder.build())
}

// TODO add cast_with_options that allow specifying
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this will go in a separate issue/PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is probably a good idea -- I can file tickets for it tomorrow hopefully

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought more about this, and since there is (currently) no way for a conversion from Variant --> Array to fail, that means the cast options are less obviously relevant (and thus I can't file a ticket as I don't know what it should do)

I updated the comment to reflect this


#[cfg(test)]
mod tests {
use super::*;
use arrow::array::{
ArrayRef, Float32Array, Float64Array, Int16Array, Int32Array, Int64Array, Int8Array,
UInt16Array, UInt32Array, UInt64Array, UInt8Array,
};
use parquet_variant::{Variant, VariantDecimal16};
use std::sync::Arc;

#[test]
fn test_cast_to_variant_int8() {
run_test(
Arc::new(Int8Array::from(vec![
Some(i8::MIN),
None,
Some(-1),
Some(1),
Some(i8::MAX),
])),
vec![
Some(Variant::Int8(i8::MIN)),
None,
Some(Variant::Int8(-1)),
Some(Variant::Int8(1)),
Some(Variant::Int8(i8::MAX)),
],
)
}

#[test]
fn test_cast_to_variant_int16() {
run_test(
Arc::new(Int16Array::from(vec![
Some(i16::MIN),
None,
Some(-1),
Some(1),
Some(i16::MAX),
])),
vec![
Some(Variant::Int16(i16::MIN)),
None,
Some(Variant::Int16(-1)),
Some(Variant::Int16(1)),
Some(Variant::Int16(i16::MAX)),
],
)
}

#[test]
fn test_cast_to_variant_int32() {
run_test(
Arc::new(Int32Array::from(vec![
Some(i32::MIN),
None,
Some(-1),
Some(1),
Some(i32::MAX),
])),
vec![
Some(Variant::Int32(i32::MIN)),
None,
Some(Variant::Int32(-1)),
Some(Variant::Int32(1)),
Some(Variant::Int32(i32::MAX)),
],
)
}

#[test]
fn test_cast_to_variant_int64() {
run_test(
Arc::new(Int64Array::from(vec![
Some(i64::MIN),
None,
Some(-1),
Some(1),
Some(i64::MAX),
])),
vec![
Some(Variant::Int64(i64::MIN)),
None,
Some(Variant::Int64(-1)),
Some(Variant::Int64(1)),
Some(Variant::Int64(i64::MAX)),
],
)
}

#[test]
fn test_cast_to_variant_uint8() {
run_test(
Arc::new(UInt8Array::from(vec![
Some(0),
None,
Some(1),
Some(127),
Some(u8::MAX),
])),
vec![
Some(Variant::Int8(0)),
None,
Some(Variant::Int8(1)),
Some(Variant::Int8(127)),
Some(Variant::Int16(255)), // u8::MAX cannot fit in Int8
],
)
}

#[test]
fn test_cast_to_variant_uint16() {
run_test(
Arc::new(UInt16Array::from(vec![
Some(0),
None,
Some(1),
Some(32767),
Some(u16::MAX),
])),
vec![
Some(Variant::Int16(0)),
None,
Some(Variant::Int16(1)),
Some(Variant::Int16(32767)),
Some(Variant::Int32(65535)), // u16::MAX cannot fit in Int16
],
)
}

#[test]
fn test_cast_to_variant_uint32() {
run_test(
Arc::new(UInt32Array::from(vec![
Some(0),
None,
Some(1),
Some(2147483647),
Some(u32::MAX),
])),
vec![
Some(Variant::Int32(0)),
None,
Some(Variant::Int32(1)),
Some(Variant::Int32(2147483647)),
Some(Variant::Int64(4294967295)), // u32::MAX cannot fit in Int32
],
)
}

#[test]
fn test_cast_to_variant_uint64() {
run_test(
Arc::new(UInt64Array::from(vec![
Some(0),
None,
Some(1),
Some(9223372036854775807),
Some(u64::MAX),
])),
vec![
Some(Variant::Int64(0)),
None,
Some(Variant::Int64(1)),
Some(Variant::Int64(9223372036854775807)),
Some(Variant::Decimal16(
// u64::MAX cannot fit in Int64
VariantDecimal16::try_from(18446744073709551615).unwrap(),
)),
],
)
}

#[test]
fn test_cast_to_variant_float32() {
run_test(
Arc::new(Float32Array::from(vec![
Some(f32::MIN),
None,
Some(-1.5),
Some(0.0),
Some(1.5),
Some(f32::MAX),
])),
vec![
Some(Variant::Float(f32::MIN)),
None,
Some(Variant::Float(-1.5)),
Some(Variant::Float(0.0)),
Some(Variant::Float(1.5)),
Some(Variant::Float(f32::MAX)),
],
)
}

#[test]
fn test_cast_to_variant_float64() {
run_test(
Arc::new(Float64Array::from(vec![
Some(f64::MIN),
None,
Some(-1.5),
Some(0.0),
Some(1.5),
Some(f64::MAX),
])),
vec![
Some(Variant::Double(f64::MIN)),
None,
Some(Variant::Double(-1.5)),
Some(Variant::Double(0.0)),
Some(Variant::Double(1.5)),
Some(Variant::Double(f64::MAX)),
],
)
}

/// Converts the given `Array` to a `VariantArray` and tests the conversion
/// against the expected values. It also tests the handling of nulls by
/// setting one element to null and verifying the output.
fn run_test(values: ArrayRef, expected: Vec<Option<Variant>>) {
// test without nulls
let variant_array = cast_to_variant(&values).unwrap();
assert_eq!(variant_array.len(), expected.len());
for (i, expected_value) in expected.iter().enumerate() {
match expected_value {
Some(value) => {
assert!(!variant_array.is_null(i), "Expected non-null at index {i}");
assert_eq!(variant_array.value(i), *value, "mismatch at index {i}");
}
None => {
assert!(variant_array.is_null(i), "Expected null at index {i}");
}
}
}
}
}
1 change: 1 addition & 0 deletions parquet-variant-compute/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.

pub mod cast_to_variant;
mod from_json;
mod to_json;
mod variant_array;
Expand Down
Loading
Loading