Skip to content

Refactor metadata - #2534

Merged
chickenlj merged 31 commits into
apache:dev-3.3from
FoghostCn:refect-metadata
Mar 4, 2024
Merged

chickenlj merged 31 commits into
apache:dev-3.3from
FoghostCn:refect-metadata

Conversation

@FoghostCn

@FoghostCn FoghostCn commented Dec 9, 2023 •

Copy link
Copy Markdown
Contributor

resolve #2432

Refector metadata

@chickenlj chickenlj changed the title Refect metadata Refactor metadata Dec 10, 2023
@FoghostCn
FoghostCn marked this pull request as draft December 11, 2023 02:26
@FoghostCn
FoghostCn force-pushed the refect-metadata branch 2 times, most recently from b34486d to 09ae67b Compare January 2, 2024 04:17
@FoghostCn
FoghostCn marked this pull request as ready for review January 2, 2024 04:17
@FoghostCn

Copy link
Copy Markdown
Contributor Author

metadata service tri support move to #2540

Comment thread metadata/info/metadata_info_test.go Resolved
Comment thread server/server.go Resolved
Comment thread metadata/client.go Resolved
Comment thread metadata/client.go Resolved
Comment thread metadata/client.go Resolved
Comment thread global/registry_config.go Resolved
@FoghostCn
FoghostCn force-pushed the refect-metadata branch 2 times, most recently from 192c83c to 8f6cf25 Compare January 8, 2024 11:17
@codecov-commenter

codecov-commenter commented Jan 9, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (198504b) 47.55% compared to head (2e54f26) 47.38%.

❗ Current head 2e54f26 differs from pull request most recent head e283246. Consider uploading reports for the commit e283246 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-3.3    #2534      +/-   ##
===========================================
- Coverage    47.55%   47.38%   -0.18%     
===========================================
  Files          318      324       +6     
  Lines        23627    24653    +1026     
===========================================
+ Hits         11236    11681     +445     
- Misses       11328    11880     +552     
- Partials      1063     1092      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread registry/exposed_tmp/exposed.go Resolved
Comment thread registry/exposed_tmp/exposed.go Resolved
@FoghostCn
FoghostCn force-pushed the refect-metadata branch 2 times, most recently from a9894b4 to 222442b Compare January 15, 2024 05:29
@chickenlj

Copy link
Copy Markdown
Contributor

Remember to create a new branch like release-3.2.0-alpha before merging into main. Because this is not something ready for the first release.

Comment thread metadata/options.go Resolved
@chickenlj
chickenlj changed the base branch from main to dev-3.3 February 4, 2024 02:44
@FoghostCn

Copy link
Copy Markdown
Contributor Author

the CI seems has some problem,plz rerun CI

@FoghostCn
FoghostCn requested a review from DMwangnima February 24, 2024 07:05
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@FinalT FinalT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj
chickenlj merged commit d6464e4 into apache:dev-3.3 Mar 4, 2024
@FoghostCn
FoghostCn deleted the refect-metadata branch April 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants