Skip to content

[SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource #27174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 3 commits into from
Closed

[SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource #27174

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e1065a
Output log warning
MaxGekk Jan 11, 2020
78077eb
Remove @deprecated
MaxGekk Jan 11, 2020
e25f195
Remove logWarning from inferSchema()
MaxGekk Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove @deprecated
  • Loading branch information
@MaxGekk
MaxGekk committed Jan 11, 2020
commit 78077ebd19e88854958df28044521dfdd0fdf69b
1 change: 0 additions & 1 deletion external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ class AvroOptions(
* If the option is not set, the Hadoop's config `avro.mapred.ignore.inputs.without.extension`
* is taken into account. If the former one is not set too, file extensions are ignored.
*/
@deprecated("Use the general data source option pathGlobFilter for filtering file names", "3.0")
Copy link
Member

@srowen srowen Jan 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this if it's really deprecated? I get that it will remove some compiler warnings, but, that's not super important, or can be worked around as you do elsewhere by deprecating the test methods too?

val ignoreExtension: Boolean = {
def warn(s: String): Unit = logWarning(
Copy link
Member

@HyukjinKwon HyukjinKwon Jan 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we define a separate method?

Copy link
Member Author

@MaxGekk MaxGekk Jan 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, to reuse the same code in 2 places.

Copy link
Member

@HyukjinKwon HyukjinKwon Jan 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly but I think it's fine to don't do it ...

s"$s is deprecated, and it will be not use by Avro datasource in the future releases. " +
Expand Down