[SPARK-31834][SQL]Improve error message for incompatible data types #28654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhulipeng
changed the title
Member
|
ok to test. |
|
Test build #123216 has finished for PR 28654 at commit
|
Member
|
retest this please |
|
Test build #123218 has finished for PR 28654 at commit
|
maropu
reviewed
May 28, 2020
| case (w: AtomicType, r: AtomicType) if storeAssignmentPolicy == STRICT => | ||
| if (!Cast.canUpCast(w, r)) { | ||
| addError(s"Cannot safely cast '$context': $w to $r") | ||
| addError(s"Cannot safely cast '$context': ${w.simpleString} to ${r.simpleString}") |
Member
There was a problem hiding this comment.
nit: simpleString -> catalogString?
Member
There was a problem hiding this comment.
+1 for catalogString :
maropu
reviewed
May 28, 2020
| case (w: AtomicType, r: AtomicType) if storeAssignmentPolicy == ANSI => | ||
| if (!Cast.canANSIStoreAssign(w, r)) { | ||
| addError(s"Cannot safely cast '$context': $w to $r") | ||
| addError(s"Cannot safely cast '$context': ${w.simpleString} to ${r.simpleString}") |
|
Test build #123236 has finished for PR 28654 at commit
|
maropu
reviewed
May 28, 2020
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala
Outdated
Show resolved
Hide resolved
maropu
reviewed
May 28, 2020
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala
Outdated
Show resolved
Hide resolved
maropu
approved these changes
May 28, 2020
|
Test build #123415 has finished for PR 28654 at commit
|
Member
|
retest this please |
|
Test build #123423 has finished for PR 28654 at commit
|
Member
|
Merged to master and branch-3.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jun 2, 2020
### What changes were proposed in this pull request? We should use dataType.catalogString to unified the data type mismatch message. Before: ```sql spark-sql> create table SPARK_31834(a int) using parquet; spark-sql> insert into SPARK_31834 select '1'; Error in query: Cannot write incompatible data to table '`default`.`spark_31834`': - Cannot safely cast 'a': StringType to IntegerType; ``` After: ```sql spark-sql> create table SPARK_31834(a int) using parquet; spark-sql> insert into SPARK_31834 select '1'; Error in query: Cannot write incompatible data to table '`default`.`spark_31834`': - Cannot safely cast 'a': string to int; ``` ### How was this patch tested? UT. Closes #28654 from lipzhu/SPARK-31834. Authored-by: lipzhu <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit d79a8a8) Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We should use dataType.catalogString to unified the data type mismatch message.
Before:
After:
How was this patch tested?
UT.