Skip to content

[SPARK-31834][SQL]Improve error message for incompatible data types #28654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhulipeng wants to merge 3 commits into from
Closed

[SPARK-31834][SQL]Improve error message for incompatible data types #28654

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46665cd
Improve error message for incompatible data types
zhulipeng May 27, 2020
77c7eef
use catalogString
zhulipeng May 28, 2020
9c4b485
use catalogString
zhulipeng Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use catalogString
  • Loading branch information
@zhulipeng
zhulipeng committed May 28, 2020
commit 77c7eef56ba7edaa4fee9bc8f6b5ac471d0806d7
6 changes: 3 additions & 3 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ object DataType {

case (w: AtomicType, r: AtomicType) if storeAssignmentPolicy == STRICT =>
if (!Cast.canUpCast(w, r)) {
addError(s"Cannot safely cast '$context': ${w.simpleString} to ${r.simpleString}")
addError(s"Cannot safely cast '$context': ${w.catalogString} to ${r.catalogString}")
false
} else {
true
Expand All @@ -467,7 +467,7 @@ object DataType {

case (w: AtomicType, r: AtomicType) if storeAssignmentPolicy == ANSI =>
if (!Cast.canANSIStoreAssign(w, r)) {
addError(s"Cannot safely cast '$context': ${w.simpleString} to ${r.simpleString}")
addError(s"Cannot safely cast '$context': ${w.catalogString} to ${r.catalogString}")
false
} else {
true
Expand All @@ -478,7 +478,7 @@ object DataType {

case (w, r) =>
addError(s"Cannot write '$context': " +
s"${w.simpleString} is incompatible with ${r.simpleString}")
s"${w.catalogString} is incompatible with ${r.catalogString}")
false
}
}
Expand Down