Skip to content

[SPARK-31834][SQL]Improve error message for incompatible data types #28654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhulipeng wants to merge 3 commits into from
Closed

[SPARK-31834][SQL]Improve error message for incompatible data types #28654

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46665cd
Improve error message for incompatible data types
zhulipeng May 27, 2020
77c7eef
use catalogString
zhulipeng May 28, 2020
9c4b485
use catalogString
zhulipeng Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use catalogString
  • Loading branch information
@zhulipeng
zhulipeng committed Jun 2, 2020
commit 9c4b485030dbb80d0d757ef8100984a53ff7eb2b
6 changes: 3 additions & 3 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class StrictDataTypeWriteCompatibilitySuite extends DataTypeWriteCompatibilityBa
test("Check NullType is incompatible with all other types") {
allNonNullTypes.foreach { t =>
assertSingleError(NullType, t, "nulls", s"Should not allow writing None to type $t") { err =>
assert(err.contains(s"incompatible with ${t.simpleString}"))
assert(err.contains(s"incompatible with ${t.catalogString}"))
}
}
}
Expand Down Expand Up @@ -209,8 +209,8 @@ abstract class DataTypeWriteCompatibilityBaseSuite extends SparkFunSuite {
s"Should not allow writing $w to $r because cast is not safe") { err =>
assert(err.contains("'t'"), "Should include the field name context")
assert(err.contains("Cannot safely cast"), "Should identify unsafe cast")
assert(err.contains(s"${w.simpleString}"), "Should include write type")
assert(err.contains(s"${r.simpleString}"), "Should include read type")
assert(err.contains(s"${w.catalogString}"), "Should include write type")
assert(err.contains(s"${r.catalogString}"), "Should include read type")
}
}
}
Expand Down