feat(anvil): support for op-stack deposit transactions #6073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
gm! what's the status here? this is gonna need a rebase. sorry about that! |
Contributor
Author
|
@Evalir thanks for the ping, I just rebased. Hoping to get to the tests this week sometime. |
anikaraghu
force-pushed
the
op-deposit
branch
from
576599f to
fb394fb
Compare
Merged
anikaraghu
force-pushed
the
op-deposit
branch
from
cdc95f7 to
68d2857
Compare
Merged
anikaraghu
force-pushed
the
op-deposit
branch
from
68d2857 to
b0da3f2
Compare
mattsse
requested changes
Nov 18, 2023
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this looks pretty good already, a few nits
crates/anvil/core/Cargo.toml
Outdated
| impersonated-tx = [] | ||
| fastrlp = ["dep:open-fastrlp"] | ||
| serde = ["dep:serde"] | ||
| optimism = ["dep:ethers-core", "dep:ethers-contract", "dep:ethers-providers", "dep:ethers-middleware"] |
Member
There was a problem hiding this comment.
this should just be optimism = ["ethers-core/optimism"]
| } | ||
|
|
||
| /// Returns true if op-stack deposits are active | ||
| pub fn is_op_deposits(&self) -> bool { |
Member
There was a problem hiding this comment.
Suggested change
| pub fn is_op_deposits(&self) -> bool { | |
| pub fn is_optimism(&self) -> bool { |
Comment on lines
1929
to
1932
| let mut deposit_nonce: Option<u64> = None; | ||
| if transaction_type.unwrap_or_default() == 0x7E { | ||
| deposit_nonce = Some(info.nonce); | ||
| } |
Member
There was a problem hiding this comment.
deposit_nonce = transaction_type.and_then(|ty| (x == 0x7E).then_some(info.nonce))
mattsse
reviewed
Nov 18, 2023
3 tasks
anikaraghu
force-pushed
the
op-deposit
branch
from
bf8a9bb to
e8ae0dd
Compare
mattsse
requested changes
Nov 21, 2023
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this is great!
love the tests.
I bumped lock file so that it compiles, only have a few nitpicks.
there's a failing test that can be attributed to the activated feature can_read_cache which I will fix
mattsse
approved these changes
Nov 22, 2023
Evalir
approved these changes
Nov 22, 2023
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
thanks! this looks quite good!
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds anvil support for op-stack's deposit transaction. This is a requirement for
mocktimism(see ethereum-optimism/mocktimism#4), which is an anvil wrapper for testing and forking op-stack chains.Fortunately, deposit tx support has already been added to
ethers-rs(gakonst/ethers-rs#2434) andrevm(bluealloy/revm#682), so adding to anvil is mostly just plumbing the tx types through.Solution
This PR adds all the required fields and types for deposit transactions. Support for optimism can be enabled by passing the
--optimismflag toanvil.TODO
cargo.tomloverrides after Re-enable the transaction.other field for optimism feature gakonst/ethers-rs#2622 has been merged