use different cmake variable for eigen include dir #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eigen3.2's upstream FindEigen3.cmake specifies only EIGEN3_INCLUDE_DIR, not EIGEN3_INCLUDE_DIRS: https://bitbucket.org/eigen/eigen/src/cafa6d909f409f4ec33070ebf991a77e7b747dc1/cmake/FindEigen3.cmake?at=default&fileviewer=file-view-default#FindEigen3.cmake-10 Eigen3.3-beta provides an Eigen3Config that defines EIGEN3_INCLUDE_DIRS AND _DIR, but that's still beta, even though Ubuntu introduced it in xenial already. So to stay backwards compatible, _INCLUDE_DIR should be used.
|
thanks for the PR, will merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eigen3.2's upstream FindEigen3.cmake specifies only EIGEN3_INCLUDE_DIR, not
EIGEN3_INCLUDE_DIRS:
https://bitbucket.org/eigen/eigen/src/cafa6d909f409f4ec33070ebf991a77e7b747dc1/cmake/FindEigen3.cmake?at=default&fileviewer=file-view-default#FindEigen3.cmake-10
Eigen3.3-beta provides an Eigen3Config that defines EIGEN3_INCLUDE_DIRS AND
_DIR, but that's still beta, even though Ubuntu introduced it in xenial
already. So to stay backwards compatible, _INCLUDE_DIR should be used.