Skip to content

use different cmake variable for eigen include dir #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kohrt merged 1 commit into from
Jun 21, 2016
Merged

use different cmake variable for eigen include dir #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use different cmake variable for eigen include dir 
Eigen3.2's upstream FindEigen3.cmake specifies only
EIGEN3_INCLUDE_DIR, not EIGEN3_INCLUDE_DIRS:
https://bitbucket.org/eigen/eigen/src/cafa6d909f409f4ec33070ebf991a77e7b747dc1/cmake/FindEigen3.cmake?at=default&fileviewer=file-view-default#FindEigen3.cmake-10

Eigen3.3-beta provides an Eigen3Config that defines
EIGEN3_INCLUDE_DIRS AND _DIR, but that's still beta, even though
Ubuntu introduced it in xenial already. So to stay backwards
compatible, _INCLUDE_DIR should be used.
  • Loading branch information
Michael Görner committed Jun 9, 2016
commit 9fdef94747db5a91a12fe716a3eb4d4197badc26
2 changes: 1 addition & 1 deletion kinect2_registration/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ endif()

if(Eigen3_FOUND)
message(STATUS "CPU based depth registration enabled")
include_directories(${EIGEN3_INCLUDE_DIRS})
include_directories(${EIGEN3_INCLUDE_DIR})
set(DEPTH_REG_CPU ON)
add_definitions(-DDEPTH_REG_CPU)
else()
Expand Down