Merge `main` into `feature/click-cli` by iknox-fa · Pull Request #6761 · dbt-labs/dbt-core

iknox-fa · 2023-01-26T20:48:00Z

resolves https://github.com/orgs/dbt-labs/projects/38/views/1

Description

This PR represents the body of work for API-ification phase 1. As that has all been reviewed previously a complete line-by-line review is probably not needed however, the following steps have been taken to ensure the merge was done correctly:

Merge in both branches until no outstanding PRs remain.
Ensure testing parity. At this point not all tests on feature/click-cli pass but we expect that tests on this branch will pass if they also pass there. Note that it's expected that the failing for different reasons but that doesn't mean that it's a regression.
Check code coverage for any portions of code with low test coverage and do manual testing there.

Checklist

I have read the contributing guide and understand what's expected of me
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
I have run changie new to create a changelog entry

* fix f string issue * removed one space * Add changelog * fixed return format Co-authored-by: Leah Antkiewicz <leah.antkiewicz@fishtownanalytics.com>

* Updated string formatting on non-f-strings. Found all cases of strings separated by white space on a single line and removed white space separation. EX: "hello " "world" -> "hello world". * add changelog entry

* Create functors to initialize event types with str-type member attributes. Before this change, the spec of various classes expected base_msg and msg params to be str's. This assumption did not always hold true. post_init hooks ensures the spec is obeyed. * Add new changelog. * Add msg type change functor to a few other events that could use it. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>

…y. (#6095) Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>

* convert 027 cycle test * remove no-op expect_pass=False * remove postgres from test names

#6134)

* Convert test to functional set. * Remove old statement tests from integration test set. * Nix whitespace Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>

* switch out to use our action * point to main

* point to correct workflow * add inputs

* Initial structured logging changes * remove "this" from core/dbt/events/functions.py * CT-1047: Fix execution_time definitions to use float * CT-1047: Revert unintended checking of changes to functions.py * WIP * first pass to resolve circular deps * more circular dep resolution * remove a bunch of duplication * move message into log line * update comments * fix field that wen missing during rebase * remove double import * remove some comments and extra code * fix pre-commit * rework deprecations * WIP converting messages * WIP converting messages * remove stray comment * WIP more message conversion * WIP more message conversion * tweak the messages * convert last message * rename * remove warn_or_raise as never used * add fake calls to all new events * fix some tests * put back deprecation * restore deprecation fully * fix unit test * fix log levels * remove some skipped ids * fix macro log function * fix how messages are built to match expected outcome * fix expected test message * small fixes from reviews * fix conflict resolution in UI Co-authored-by: Gerda Shank <gerda@dbtlabs.com> Co-authored-by: Peter Allen Webb <peter.webb@dbtlabs.com>

* converting 023_exit_codes_tests * use packages fixture, clean up test names

…ker (#6180) * Bump python from 3.10.7-slim-bullseye to 3.11.0-slim-bullseye in /docker Bumps python from 3.10.7-slim-bullseye to 3.11.0-slim-bullseye. --- updated-dependencies: - dependency-name: python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add automated changelog yaml from template for bot PR Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>

* Updates lib to use new profile name functionality * Adds changie entry * Fixes formatting

* Combine various print result log events with different levels * Changie * more merge cleanup * Specify DynamicLevel for event classes that must specify level

* Remove root_path * Bump manifest schema to 8 * Update tests and compability utility for v8, root_path removal

…/core (#6144) * Update colorama requirement in /core Updates the requirements on [colorama](https://github.com/tartley/colorama) to permit the latest version. - [Release notes](https://github.com/tartley/colorama/releases) - [Changelog](https://github.com/tartley/colorama/blob/master/CHANGELOG.rst) - [Commits](tartley/colorama@0.3.9...0.4.6) --- updated-dependencies: - dependency-name: colorama dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Add automated changelog yaml from template for bot PR Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>

* converting 044_test_run_operations

* init pr for dbt_debug test conversion * removal of old test * minor test format change * add new Base class and Test classes * reformatting test, new method for capsys and error messgae to check, todo fix badproject * refomatting tests, ready for review * checking yaml file, and small reformat * modifying since update wasn't working in ci/cd

* Optimization to remove graph analysis bottleneck in large dags. * Add changelog entry.

* Test converted and reformatted for pytest. * Ax old versions of 052 test * Nix the 'os' import and black format * Change names of models to be more PEP like * cleanup code Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>

…leases (#6602) * Add release workflows * Update nightly-release.yml * Set default `test_run` value to `true` * Update .bumpversion.cfg * Resolve review comment - Update workflow docs - Change workflow name - Set `test_run` default value to `true` * Update Slack secret * PyPI

eve-johns and others added 30 commits October 17, 2022 16:58

f-string cleanup #6068 (#6082)

a9c8bc0

* fix f string issue * removed one space * Add changelog * fixed return format Co-authored-by: Leah Antkiewicz <leah.antkiewicz@fishtownanalytics.com>

Updated string formatting on non-f-strings. (#6086)

35f7975

* Updated string formatting on non-f-strings. Found all cases of strings separated by white space on a single line and removed white space separation. EX: "hello " "world" -> "hello world". * add changelog entry

Add unit tests for recent stringifier functors added to events librar…

a7670a3

…y. (#6095) Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>

CT-1099: Migrate test 071_commented_yaml_regression_3568_tests (#6106)

53ae325

Add 'michelleark' to changie's core_team list (#6084)

6c86094

convert 027 cycle test (#6094)

17b8266

* convert 027 cycle test * remove no-op expect_pass=False * remove postgres from test names

[BUGFIX] Force tox to update pip (fixes psycopg2-binary @ 2.9.5) (

c285601

#6134)

Ct 1167/030 statement tests conversion (#6109)

1916784

* Convert test to functional set. * Remove old statement tests from integration test set. * Nix whitespace Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>

switch out to use internal action for triage labels (#6120)

7b73264

* switch out to use our action * point to main

more ergonomic profile name handling (#6157)

77dfec7

point to correct workflow (#6161)

fc00239

* point to correct workflow * add inputs

revert to community action (#6163)

8145eed

converting 023_exit_codes_tests (#6105)

a427484

* converting 023_exit_codes_tests * use packages fixture, clean up test names

Add new index.html and changelog yaml files from dbt-docs (#6112)

d23285b

add python version and upgrade action (#6204)

c3ccbe3

add typing to DepsTask.run (#6192)

cfad27f

Updates lib to use new profile name functionality (#6202)

d0543c9

* Updates lib to use new profile name functionality * Adds changie entry * Fixes formatting

Combine various print result log events with different levels (#6174)

68d06d8

* Combine various print result log events with different levels * Changie * more merge cleanup * Specify DynamicLevel for event classes that must specify level

CT 1443 remove root path (#6172)

6c76137

* Remove root_path * Bump manifest schema to 8 * Update tests and compability utility for v8, root_path removal

properly track hook running (#6059)

930bd35

Convert threading tests to pytest (#6226)

4e78618

Convert color tests to pytest (#6230)

d5e9ce1

Convert postgres index tests (#6228)

f022435

feature/favor-state-node (#5859)

73116fb

converting 044_test_run_operations (#6122)

39c5c42

* converting 044_test_run_operations

iknox-fa and others added 7 commits January 26, 2023 12:43

merging in feature/click-cli

94bc83c

merge in main

256763a

Graph Analysis Optimization for Large Dags (#6720)

c2c4757

* Optimization to remove graph analysis bottleneck in large dags. * Add changelog entry.

fixed missing wrapper message

5133ed2

merge in feature/click-cli

9df4867

Merge branch 'main' into merge_main_to_feature/click-cli

55412c9

cla-bot bot added the cla:yes label Jan 26, 2023

iknox-fa marked this pull request as ready for review January 27, 2023 18:50

iknox-fa requested a review from a team as a code owner January 27, 2023 18:50

iknox-fa requested a review from a team January 27, 2023 18:50

iknox-fa requested review from a team and leahwicz as code owners January 27, 2023 18:50

iknox-fa requested a review from nssalian January 27, 2023 18:50

stu-k approved these changes Jan 27, 2023

View reviewed changes

iknox-fa added 4 commits January 27, 2023 13:02

Merge branch 'main' into merge_main_to_feature/click-cli

f8bc41b

Fix test_events

413114e

Code quality fixes

6a81545

Temporarily disable running dbt --version in GHA

1ead5ac

iknox-fa merged commit d6ac340 into feature/click-cli Jan 27, 2023

iknox-fa deleted the merge_main_to_feature/click-cli branch January 27, 2023 21:07

MichelleArk mentioned this pull request Jan 30, 2023

[CT-1791] Add buildable as to indirect_selection param in Click CLI #6577

Closed

3 tasks

This was referenced Jan 31, 2023

[CT-1947] Alias --models to --select for all commands except dbt ls #6787

Merged

Move docs to run on PR merge #6805

Closed

This was referenced Feb 8, 2023

Fix Click CLI test DB Name #6895

Merged

Fix Project Env Var Tests #6916

Merged

Merge feature/click-cli into main #6931

Merged

jtcohen6 mentioned this pull request Mar 22, 2023

[CT-2320] [Regression] [v1.5] dbt list no longer suppresses info-level logging #7206

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge `main` into `feature/click-cli`#6761

Merge `main` into `feature/click-cli`#6761
iknox-fa merged 159 commits intofeature/click-clifrom
merge_main_to_feature/click-cli

iknox-fa commented Jan 26, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

iknox-fa commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

iknox-fa commented Jan 26, 2023 •

edited

Loading