Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 761d2e6
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7324320
Choose a head ref
  • 14 commits
  • 17 files changed
  • 8 contributors

Commits on Aug 31, 2021

  1. Update to SDK that understands NUGET_ENABLE_EXPERIMENTAL_HTTP_RETRY (#…

    …7814)
    
    Update to an SDK that understands NUGET_ENABLE_EXPERIMENTAL_HTTP_RETRY, and set some values in common entry points (validated in binlogs)
    
    Users who need these values set from non-arcade execution paths can set them globally via yaml or their own scripts.
    MattGal authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    ca8ebd3 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Configuration menu
    Copy the full SHA
    75af908 View commit details
    Browse the repository at this point in the history
  2. Update dependencies from https://github.com/dotnet/roslyn build 20210…

    …827.11 (#7810)
    
    [main] Update dependencies from dotnet/roslyn
    dotnet-maestro[bot] authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    4d1fbd8 View commit details
    Browse the repository at this point in the history
  3. [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade mono…

    …/linker (#7816)
    
    [main] Update dependencies from dotnet/xliff-tasks dotnet/arcade mono/linker
    dotnet-maestro[bot] authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    b0aeac9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    923c95e View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. [workloads] Add locks for parallel NuGet access (#7813)

    Android workload pack conversion has been failing intermittently:
    
        Generating package project: 'obj\Debug\src\msiPackage\x86\Microsoft.Android.Sdk.Windows\msi.csproj'
        convert.proj(72,5): error : One or more errors occurred.
        convert.proj(72,5): error : Failed to generate MSIs for workload packs.
    
        C:\Users\AzDevOps\.nuget\packages\wix\3.14.0-dotnet\tools\heat.exe dir obj\Debug\pkg\Microsoft.Android.Templates.31.0.100-rc.2.14 -cg CG_PackageContent -var var.SourceDir -ag -srd -sreg -dr InstallDir -o obj\Debug\src\msi\Microsoft.Android.Templates\31.0.100-rc.2.14\x64\PackageContent.wxs
        ##[error]light.exe(0,0): Error LGHT0001: The system cannot find the file specified. (Exception from HRESULT: 0x80070002)
        light.exe : error LGHT0001: The system cannot find the file specified. (Exception from HRESULT: 0x80070002) [C:\a\1\s\nuget-msi-convert\convert-v2\convert.proj]
    
          Exception Type: System.IO.FileNotFoundException
    
          Stack Trace:
             at Microsoft.Tools.WindowsInstallerXml.Cab.Interop.NativeMethods.CreateCabFinish(IntPtr contextHandle, IntPtr newCabNamesCallBackAddress)
             at Microsoft.Tools.WindowsInstallerXml.Cab.WixCreateCab.Complete(IntPtr newCabNamesCallBackAddress)
             at Microsoft.Tools.WindowsInstallerXml.CabinetBuilder.CreateCabinet(CabinetWorkItem cabinetWorkItem)
             at Microsoft.Tools.WindowsInstallerXml.CabinetBuilder.ProcessWorkItems()
    
    I've added a lock to attempt to synchronize some .nupkg file access that
    seemed to be problematic when executing asynchronously.
    pjcollins authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    7168d63 View commit details
    Browse the repository at this point in the history
  2. Update dependencies from https://github.com/dotnet/arcade build 20210…

    …901.3 (#7826)
    
    [main] Update dependencies from dotnet/arcade
    dotnet-maestro[bot] authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    eecf503 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Fix sourcelink repository url (#7844) (#7847)

    * Fix sourcelink repository url
    
    When we updated the ScmRepositoryUrl to handle devdiv links, we never updated the version used in SourceRoot, which is used by sourcelink, and also needed to be updated to remove -trusted from the link. By not removing -trusted, the translation pattern can't identify the url as something that needs to be translated, and so just uses the azdo url. This change adds the code to remove -trusted to fix the issue.
    
    * Remove second item group
    michellemcdaniel authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    8384be4 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Configuration menu
    Copy the full SHA
    781cee2 View commit details
    Browse the repository at this point in the history
  2. Cherry picking from main to release/6.0 (#7854)

    Address #7850 - handle the lack of a ScmRepositoryUrl when batch updating (#7852)
    MattGal authored Sep 8, 2021
    Configuration menu
    Copy the full SHA
    4063831 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Use ProductVersion.txt where possible (#7837) (#7861)

    * Add ProductVersion.txt support where possible; get the version of the inner package from productVersion.txt, NOT from the specified version.  Allows "non-stable" outer container with "stable" inner contents
    
    #7836
    MattGal authored Sep 9, 2021
    Configuration menu
    Copy the full SHA
    d17fe1b View commit details
    Browse the repository at this point in the history
  2. [workloads] Allow disabling most parallelization (#7857) (#7867)

    The changes in 7168d63 did fix Android msi generation issues for me
    locally, but CI attempts have still been failing.  A new `RunInParallel`
    task parameter has been added to allow consumers to opt-out of most
    parallelization until these issues are fixed.
    pjcollins authored Sep 9, 2021
    Configuration menu
    Copy the full SHA
    6885020 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    991986c View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Port to release/6.0: Fix lld support (#7884)

    I have found that when I've made a change to use the lld linker in July,
    I've missed to push part of the change that was supposed to go to Arcade.
    
    Without this change, the lld enabling flag is not used and we end up using
    the default linker.
    janvorli authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    7324320 View commit details
    Browse the repository at this point in the history
Loading