-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Restore removed API from Extensions #85846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
01cfe3e
Restore missing API from Extensions
ericstj cc664db
Fix a couple missing interfaces
ericstj c23bad7
Fix EventLog test
ericstj 8078dd5
Undo interface heirarchy change in hosting
ericstj ef06d4a
Add API compat validation for old Extensions baseline
ericstj 8fae371
Bring back less logging API and baseline missing
ericstj 3e69333
Implement obsolete console API
ericstj 19ef703
Fix the download of extensions compat packages
ericstj 0c27916
Remove ConsoleLifetime overload
ericstj bb9c4c7
Update obsolete message on InplaceStringBuilder
ericstj e70d1a6
Fill in implementation of obsolete logging methods
ericstj 6271dc1
Update console->config ref dependency
ericstj f2738b3
Update Obsolete messages and make error
ericstj dc7f9e1
Suppress compat around Obsolete(..., error: true)
ericstj 5f9b5dd
Fix more obsolete messages
ericstj dc99729
Remove ConsoleLoggerProvider ctor overloads
ericstj c29ad96
Omit ConfigurationSection .ctor overload
ericstj 58a8cf4
Remove OptionsWrapper members
ericstj 63c233d
Mark restored obsoleted API as EditorBrowsable=never
ericstj 5bdf838
Remove extensions 2.1 compat infrastructure
ericstj e488389
Remove unused usings
ericstj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Restore missing API from Extensions
- Loading branch information
commit 01cfe3e1779b9024f7f46124c0088678ac8a45cb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
src/libraries/Microsoft.Extensions.Logging.Abstractions/src/Obsolete.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
|
|
||
| namespace Microsoft.Extensions.Logging.Abstractions.Internal | ||
| { | ||
| [System.Obsolete("TODO")] | ||
| public partial class NullScope | ||
| { | ||
| internal NullScope() { } | ||
|
|
||
| public static NullScope Instance { get { throw new NotImplementedException(); } } | ||
|
|
||
| public void Dispose() { } | ||
| } | ||
|
|
||
| [System.Obsolete("TODO")] | ||
| public partial class TypeNameHelper | ||
| { | ||
| public TypeNameHelper() { } | ||
|
|
||
| public static string GetTypeDisplayName(System.Type type) { throw new NotImplementedException(); } | ||
| } | ||
| } | ||
|
|
||
| namespace Microsoft.Extensions.Logging.Internal | ||
| { | ||
| [System.Obsolete("TODO")] | ||
| public partial class FormattedLogValues | ||
| { | ||
| public FormattedLogValues(string format, params object[] values) { } | ||
|
|
||
| public int Count { get { throw new NotImplementedException(); } } | ||
|
|
||
| public System.Collections.Generic.KeyValuePair<string, object> this[int index] { get { throw new NotImplementedException(); } } | ||
|
|
||
| public System.Collections.Generic.IEnumerator<System.Collections.Generic.KeyValuePair<string, object>> GetEnumerator() { throw new NotImplementedException(); } | ||
|
|
||
| public override string ToString() { throw new NotImplementedException(); } | ||
| } | ||
|
|
||
| [System.Obsolete("TODO")] | ||
| public partial class LogValuesFormatter | ||
| { | ||
| public LogValuesFormatter(string format) { } | ||
|
|
||
| public string OriginalFormat { get { throw new NotImplementedException(); } } | ||
|
|
||
| public System.Collections.Generic.List<string> ValueNames { get { throw new NotImplementedException(); } } | ||
|
|
||
| public string Format(object[] values) { throw new NotImplementedException(); } | ||
|
|
||
| public System.Collections.Generic.KeyValuePair<string, object> GetValue(object[] values, int index) { throw new NotImplementedException(); } | ||
|
|
||
| public System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>> GetValues(object[] values) { throw new NotImplementedException(); } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.