Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a couple missing interfaces
  • Loading branch information
ericstj committed Jun 8, 2023
commit cc664db74bcc21151ce9151a6548c84c5e0a2a41
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public void Log<TState>(Microsoft.Extensions.Logging.LogLevel logLevel, Microsof
namespace Microsoft.Extensions.Logging.Abstractions.Internal
{
[System.ObsoleteAttribute("TODO")]
public partial class NullScope
public partial class NullScope : System.IDisposable
{
internal NullScope() { }
public static Microsoft.Extensions.Logging.Abstractions.Internal.NullScope Instance { get { throw null; } }
Expand All @@ -215,12 +215,13 @@ public TypeNameHelper() { }
namespace Microsoft.Extensions.Logging.Internal
{
[System.ObsoleteAttribute("TODO")]
public partial class FormattedLogValues
public partial class FormattedLogValues : System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>>, System.Collections.Generic.IReadOnlyCollection<System.Collections.Generic.KeyValuePair<string, object>>, System.Collections.Generic.IReadOnlyList<System.Collections.Generic.KeyValuePair<string, object>>, System.Collections.IEnumerable
{
public FormattedLogValues(string format, params object[] values) { }
public int Count { get { throw null; } }
public System.Collections.Generic.KeyValuePair<string, object> this[int index] { get { throw null; } }
public System.Collections.Generic.IEnumerator<System.Collections.Generic.KeyValuePair<string, object>> GetEnumerator() { throw null; }
System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }
public override string ToString() { throw null; }
}
[System.ObsoleteAttribute("TODO")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Collections;
using System.Collections.Generic;

namespace Microsoft.Extensions.Logging.Abstractions.Internal
{
[System.Obsolete("TODO")]
public partial class NullScope
public partial class NullScope : IDisposable
{
internal NullScope() { }

public static NullScope Instance { get { throw new NotImplementedException(); } }
public static NullScope Instance { get; } = new NullScope();

public void Dispose() { }
}
Expand All @@ -20,22 +22,25 @@ public partial class TypeNameHelper
{
public TypeNameHelper() { }

public static string GetTypeDisplayName(System.Type type) { throw new NotImplementedException(); }
public static string GetTypeDisplayName(System.Type type) =>
Microsoft.Extensions.Internal.TypeNameHelper.GetTypeDisplayName(type);
}
}

namespace Microsoft.Extensions.Logging.Internal
{
[System.Obsolete("TODO")]
public partial class FormattedLogValues
public partial class FormattedLogValues : IReadOnlyList<KeyValuePair<string, object>>
{
public FormattedLogValues(string format, params object[] values) { }

public int Count { get { throw new NotImplementedException(); } }

public System.Collections.Generic.KeyValuePair<string, object> this[int index] { get { throw new NotImplementedException(); } }
public KeyValuePair<string, object> this[int index] { get { throw new NotImplementedException(); } }

public System.Collections.Generic.IEnumerator<System.Collections.Generic.KeyValuePair<string, object>> GetEnumerator() { throw new NotImplementedException(); }
public IEnumerator<KeyValuePair<string, object>> GetEnumerator() { throw new NotImplementedException(); }

IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();

public override string ToString() { throw new NotImplementedException(); }
}
Expand All @@ -47,12 +52,12 @@ public LogValuesFormatter(string format) { }

public string OriginalFormat { get { throw new NotImplementedException(); } }

public System.Collections.Generic.List<string> ValueNames { get { throw new NotImplementedException(); } }
public List<string> ValueNames { get { throw new NotImplementedException(); } }

public string Format(object[] values) { throw new NotImplementedException(); }

public System.Collections.Generic.KeyValuePair<string, object> GetValue(object[] values, int index) { throw new NotImplementedException(); }
public KeyValuePair<string, object> GetValue(object[] values, int index) { throw new NotImplementedException(); }

public System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>> GetValues(object[] values) { throw new NotImplementedException(); }
public IEnumerable<KeyValuePair<string, object>> GetValues(object[] values) { throw new NotImplementedException(); }
}
}