Skip to content

Restore removed API from Extensions #85846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericstj merged 21 commits into from
Jun 16, 2023
Merged

Restore removed API from Extensions #85846

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
01cfe3e
Restore missing API from Extensions
ericstj May 5, 2023
cc664db
Fix a couple missing interfaces
ericstj May 6, 2023
c23bad7
Fix EventLog test
ericstj May 7, 2023
8078dd5
Undo interface heirarchy change in hosting
ericstj May 8, 2023
ef06d4a
Add API compat validation for old Extensions baseline
ericstj May 8, 2023
8fae371
Bring back less logging API and baseline missing
ericstj May 8, 2023
3e69333
Implement obsolete console API
ericstj May 10, 2023
19ef703
Fix the download of extensions compat packages
ericstj May 10, 2023
0c27916
Remove ConsoleLifetime overload
ericstj May 15, 2023
bb9c4c7
Update obsolete message on InplaceStringBuilder
ericstj May 15, 2023
e70d1a6
Fill in implementation of obsolete logging methods
ericstj May 15, 2023
6271dc1
Update console->config ref dependency
ericstj May 15, 2023
f2738b3
Update Obsolete messages and make error
ericstj Jun 9, 2023
dc7f9e1
Suppress compat around Obsolete(..., error: true)
ericstj Jun 9, 2023
5f9b5dd
Fix more obsolete messages
ericstj Jun 9, 2023
dc99729
Remove ConsoleLoggerProvider ctor overloads
ericstj Jun 12, 2023
c29ad96
Omit ConfigurationSection .ctor overload
ericstj Jun 13, 2023
58a8cf4
Remove OptionsWrapper members
ericstj Jun 14, 2023
63c233d
Mark restored obsoleted API as EditorBrowsable=never
ericstj Jun 14, 2023
5bdf838
Remove extensions 2.1 compat infrastructure
ericstj Jun 14, 2023
e488389
Remove unused usings
ericstj Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the download of extensions compat packages
  • Loading branch information
@ericstj
ericstj committed Jun 8, 2023
commit 19ef7037400901b30cea9c9c0cdbbcf2f1d26517
14 changes: 10 additions & 4 deletions src/libraries/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@

<!-- All breaking changes in extensions happened after 2.2 -->
<PropertyGroup>
<RunExtensionsCompat Condition="$(MSBuildProjectName.StartsWith('Microsoft.Extensions.')) AND '$(DisableCheckExtensionsBackwardCompatibility)' != 'true'">true</RunExtensionsCompat>
<RunExtensionsCompat Condition="$(MSBuildProjectName.StartsWith('Microsoft.Extensions.')) AND '$(IsPackable)' == 'true' AND '$(DisableCheckExtensionsBackwardCompatibility)' != 'true'">true</RunExtensionsCompat>
<ExtensionsCompatVersion Condition="'$(ExtensionsCompatVersion)' == ''">2.2.0</ExtensionsCompatVersion>
<ExtensionsApiCompatValidatePackageSemaphoreFile>$(IntermediateOutputPath)$(MSBuildThisFileName).semaphore</ExtensionsApiCompatValidatePackageSemaphoreFile>

Expand All @@ -219,13 +219,19 @@
<ExtensionsCompatSuppressionOutputFile Condition="'$(ExtensionsCompatSuppressionOutputFile)' == '' and '$(ExtensionsCompatGenerateSuppressionFile)' == 'true'">$(ExtensionsCompatSuppressionFilePath)</ExtensionsCompatSuppressionOutputFile>
</PropertyGroup>
<ItemGroup Condition="'$(RunExtensionsCompat)' == 'true'">
<!-- NuGet insists on only a single PackageDownload per ID -->
<PackageDownload Update="$(PackageId)" Version="[$(ExtensionsCompatVersion)];[$(PackageValidationBaselineVersion)]" />

<ExtensionsCompatSuppressionFile Include="@(ApiCompatSuppressionFile)" />
<ExtensionsCompatSuppressionFile Condition="Exists('$(ExtensionsCompatSuppressionFilePath)')" Include="$(ExtensionsCompatSuppressionFilePath)" />
</ItemGroup>

<Target Name="AddExtensionsCompatPackageDownload"
Condition="'$(RunExtensionsCompat)' == 'true'"
BeforeTargets="CollectPackageDownloads">
<ItemGroup>
<!-- NuGet insists on only a single PackageDownload per ID. Update the one added by SDK. -->
<PackageDownload Condition="'%(Identity)' == '$(PackageId)'" Version="[$(ExtensionsCompatVersion)];[$(PackageValidationBaselineVersion)]" />
</ItemGroup>
</Target>

<Target Name="CheckExtensionsBackwardCompatibility"
Condition="'$(RunExtensionsCompat)' == 'true'"
AfterTargets="RunPackageValidation"
Expand Down