Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
carlossanlop authored and github-actions committed May 6, 2023
commit 0a3e47fdf2ca451b67e56f879ab2b03771d97b7a
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ main PR <!-- Link to PR if any that fixed this in the main branch. -->

# Package authoring signed off?

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary [package authoring](~/docs/project/library-servicing.md) and gotten it explicitly reviewed.
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary [package authoring](../../docs/project/library-servicing.md) and gotten it explicitly reviewed.
3 changes: 2 additions & 1 deletion .github/workflows/check-service-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ jobs:
- name: Check `Servicing-approved` label
run: |
echo "Merging permission is enabled for servicing PRs when the `Servicing-approved` label is applied."
echo "Rules for applying the label can be found [here](~/docs/project/library-servicing.md)."
echo "Rules for applying the label can be found in https://github.com/dotnet/runtime/blob/main/docs/project/library-servicing.md"
if [ "${{ contains(github.event.pull_request.labels.*.name, 'Servicing-approved') }}" = "true" ]; then
echo "::error 'Servicing-approved' label not applied to the PR yet."
exit 0
else
exit 1
Expand Down