Skip to content

[main] Servicing docs improvements #85855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 7 commits into from
May 8, 2023
Merged

[main] Servicing docs improvements #85855

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc012b4
Servicing docs improvements
carlossanlop May 3, 2023
0a3e47f
Apply suggestions from code review
carlossanlop May 4, 2023
44c2e76
Apply suggestions from code review
carlossanlop May 4, 2023
b83e3c0
Apply suggestions from code review
hoyosjs May 6, 2023
2a777cc
Apply suggestions from code review
hoyosjs May 6, 2023
c6e27d0
Update .github/workflows/check-service-labels.yml
hoyosjs May 6, 2023
50e85c5
Update .github/workflows/check-service-labels.yml
hoyosjs May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update .github/workflows/check-service-labels.yml
  • Loading branch information
@hoyosjs
hoyosjs authored and github-actions committed May 6, 2023
commit 50e85c537afca98d4bba4446800f3f848e0301df
2 changes: 1 addition & 1 deletion .github/workflows/check-service-labels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ jobs:
if [ "${{ contains(github.event.pull_request.labels.*.name, 'Servicing-approved') }}" = "true" ]; then
exit 0
else
echo "::error:: 'Servicing-approved' label not applied to the PR yet. More information: https://github.com/dotnet/runtime/blob/main/docs/project/library-servicing.md"
echo "::error:: 'Servicing-approved' label not applied to the PR yet. More information: https://github.com/dotnet/runtime/blob/main/docs/project/library-servicing.md#approval-process"
exit 1
fi