Fix File.Copy onto a symlink on macOS
#87600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-System.IO
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsResolves #79243 (comment). I introduced a minor bug in #79243, which means that using This fix should be basically zero additional cost currently, as it doesn't introduce any additional syscalls (except for the case we're fixing). Also adds a test to catch this in the future.
|
3 tasks
hamarb123
commented
Jun 15, 2023
jozkee
approved these changes
Jun 16, 2023
src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve s the discussion at #79243 (comment).
I introduced a minor bug in #79243, which meant that using
File.Copyonto a symlink won't produce the expected behaviour of modifying what the symlink points to, as opposed to what I implemented, which was to replace the symlink.This fix should be basically zero additional cost currently, as it doesn't introduce any additional syscalls (except for the case we're fixing). Also adds a test to catch this in the future.