Skip to content

Fix File.Copy onto a symlink on macOS #87600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jozkee merged 6 commits into from
Jun 16, 2023
Merged

Fix File.Copy onto a symlink on macOS #87600

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e18b8ea
Initial commit
hamarb123 Jun 15, 2023
03ccef6
Fix compile error
hamarb123 Jun 15, 2023
83f2974
Update SafeFileHandle.Unix.cs
hamarb123 Jun 15, 2023
c438486
Fix macOS compilation errors
hamarb123 Jun 15, 2023
61b82f6
Somehow I forgot overwrite = true
hamarb123 Jun 15, 2023
8b20334
Implement feedback
hamarb123 Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update SafeFileHandle.Unix.cs
  • Loading branch information
@hamarb123
hamarb123 committed Jun 15, 2023
commit 83f2974ba7d7fee9ae583d447ca1c6ff10a5d44e
1 change: 1 addition & 0 deletions src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ private static SafeFileHandle Open(string fullPath, FileMode mode, FileAccess ac
/// <param name="access">The FileAccess provided to the stream's constructor</param>
/// <param name="share">The FileShare provided to the stream's constructor</param>
/// <param name="options">The FileOptions provided to the stream's constructor</param>
/// <param name="failForSymlink">Whether to cause ELOOP error when opening a symlink</param>
/// <returns>The flags value to be passed to the open system call.</returns>
private static Interop.Sys.OpenFlags PreOpenConfigurationFromOptions(FileMode mode, FileAccess access, FileShare share, FileOptions options, bool failForSymlink)
{
Expand Down