Skip to content
Next Next commit
Add Meta.fields = '__all__' to serializer classes where required.
  • Loading branch information
lovelydinosaur committed Jun 2, 2016
commit 252ccf1e6bb28e7b25ac450bbefebd59efd92c9e
5 changes: 5 additions & 0 deletions tests/test_filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
class FilterableItemSerializer(serializers.ModelSerializer):
class Meta:
model = FilterableItem
fields = '__all__'

# Basic filter on a list view.
class FilterFieldsRootView(generics.ListCreateAPIView):
Expand Down Expand Up @@ -336,6 +337,7 @@ class SearchFilterModel(models.Model):
class SearchFilterSerializer(serializers.ModelSerializer):
class Meta:
model = SearchFilterModel
fields = '__all__'


class SearchFilterTests(TestCase):
Expand Down Expand Up @@ -461,6 +463,7 @@ class SearchFilterModelM2M(models.Model):
class SearchFilterM2MSerializer(serializers.ModelSerializer):
class Meta:
model = SearchFilterModelM2M
fields = '__all__'


class SearchFilterM2MTests(TestCase):
Expand Down Expand Up @@ -511,6 +514,7 @@ class OrderingFilterRelatedModel(models.Model):
class OrderingFilterSerializer(serializers.ModelSerializer):
class Meta:
model = OrderingFilterModel
fields = '__all__'


class DjangoFilterOrderingModel(models.Model):
Expand All @@ -524,6 +528,7 @@ class Meta:
class DjangoFilterOrderingSerializer(serializers.ModelSerializer):
class Meta:
model = DjangoFilterOrderingModel
fields = '__all__'


class DjangoFilterOrderingTests(TestCase):
Expand Down
4 changes: 4 additions & 0 deletions tests/test_generics.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,13 @@ class Comment(RESTFrameworkModel):
class BasicSerializer(serializers.ModelSerializer):
class Meta:
model = BasicModel
fields = '__all__'


class ForeignKeySerializer(serializers.ModelSerializer):
class Meta:
model = ForeignKeySource
fields = '__all__'


class SlugSerializer(serializers.ModelSerializer):
Expand Down Expand Up @@ -414,6 +416,7 @@ class ClassASerializer(serializers.ModelSerializer):

class Meta:
model = ClassA
fields = '__all__'


class ExampleView(generics.ListCreateAPIView):
Expand Down Expand Up @@ -461,6 +464,7 @@ class Meta:
class DynamicSerializer(serializers.ModelSerializer):
class Meta:
model = TwoFieldModel
fields = '__all__'
return DynamicSerializer


Expand Down
1 change: 1 addition & 0 deletions tests/test_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ class ExampleSerializer(serializers.ModelSerializer):

class Meta:
model = Parent
fields = '__all__'

class ExampleView(views.APIView):
"""Example view."""
Expand Down
21 changes: 21 additions & 0 deletions tests/test_model_serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ def test_regular_fields(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = RegularFieldsModel
fields = '__all__'

expected = dedent("""
TestSerializer():
Expand Down Expand Up @@ -173,6 +174,7 @@ def test_field_options(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = FieldOptionsModel
fields = '__all__'

expected = dedent("""
TestSerializer():
Expand Down Expand Up @@ -306,6 +308,7 @@ class TestSerializer(serializers.ModelSerializer):

class Meta:
model = RegularFieldsModel
fields = '__all__'

class ChildSerializer(TestSerializer):
missing = serializers.ReadOnlyField()
Expand All @@ -320,13 +323,15 @@ def test_choices_with_nonstandard_args(self):
class ExampleSerializer(serializers.ModelSerializer):
class Meta:
model = ChoicesModel
fields = '__all__'

ExampleSerializer()

def test_fields_and_exclude_behavior(self):
class ImplicitFieldsSerializer(serializers.ModelSerializer):
class Meta:
model = RegularFieldsModel
fields = '__all__'

class ExplicitFieldsSerializer(serializers.ModelSerializer):
class Meta:
Expand All @@ -350,6 +355,7 @@ class DurationFieldModel(models.Model):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = DurationFieldModel
fields = '__all__'

expected = dedent("""
TestSerializer():
Expand All @@ -367,6 +373,7 @@ class IPAddressFieldModel(models.Model):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = IPAddressFieldModel
fields = '__all__'

s = TestSerializer(data={'address': 'not an ip address'})
self.assertFalse(s.is_valid())
Expand Down Expand Up @@ -420,6 +427,7 @@ def test_pk_relations(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = RelationalModel
fields = '__all__'

expected = dedent("""
TestSerializer():
Expand All @@ -436,6 +444,7 @@ class TestSerializer(serializers.ModelSerializer):
class Meta:
model = RelationalModel
depth = 1
fields = '__all__'

expected = dedent("""
TestSerializer():
Expand All @@ -459,6 +468,7 @@ def test_hyperlinked_relations(self):
class TestSerializer(serializers.HyperlinkedModelSerializer):
class Meta:
model = RelationalModel
fields = '__all__'

expected = dedent("""
TestSerializer():
Expand All @@ -475,6 +485,7 @@ class TestSerializer(serializers.HyperlinkedModelSerializer):
class Meta:
model = RelationalModel
depth = 1
fields = '__all__'

expected = dedent("""
TestSerializer():
Expand All @@ -499,6 +510,8 @@ class TestSerializer(serializers.HyperlinkedModelSerializer):
class Meta:
model = UniqueTogetherModel
depth = 1
fields = '__all__'

expected = dedent("""
TestSerializer():
url = HyperlinkedIdentityField(view_name='uniquetogethermodel-detail')
Expand Down Expand Up @@ -600,6 +613,7 @@ def test_default_display_value(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = DisplayValueModel
fields = '__all__'

serializer = TestSerializer()
expected = OrderedDict([('1', 'Red Color'), ('2', 'Yellow Color'), ('3', 'Green Color')])
Expand All @@ -615,6 +629,7 @@ class TestSerializer(serializers.ModelSerializer):

class Meta:
model = DisplayValueModel
fields = '__all__'

serializer = TestSerializer()
expected = OrderedDict([('1', 'My Red Color'), ('2', 'My Yellow Color'), ('3', 'My Green Color')])
Expand Down Expand Up @@ -645,6 +660,7 @@ def test_pk_retrival(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = RelationalModel
fields = '__all__'

serializer = TestSerializer(self.instance)
expected = {
Expand All @@ -660,6 +676,7 @@ def test_pk_create(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = RelationalModel
fields = '__all__'

new_foreign_key = ForeignKeyTargetModel.objects.create(
name='foreign_key'
Expand Down Expand Up @@ -707,6 +724,7 @@ def test_pk_update(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = RelationalModel
fields = '__all__'

new_foreign_key = ForeignKeyTargetModel.objects.create(
name='foreign_key'
Expand Down Expand Up @@ -875,6 +893,7 @@ def test_decimal_field_has_decimal_validator(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = DecimalFieldModel
fields = '__all__'

serializer = TestSerializer()

Expand All @@ -888,6 +907,7 @@ def test_min_value_is_passed(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = DecimalFieldModel
fields = '__all__'

serializer = TestSerializer()

Expand All @@ -901,6 +921,7 @@ def test_max_value_is_passed(self):
class TestSerializer(serializers.ModelSerializer):
class Meta:
model = DecimalFieldModel
fields = '__all__'

serializer = TestSerializer()

Expand Down
2 changes: 2 additions & 0 deletions tests/test_multitable_inheritance.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ class AssociatedModel(RESTFrameworkModel):
class DerivedModelSerializer(serializers.ModelSerializer):
class Meta:
model = ChildModel
fields = '__all__'


class AssociatedModelSerializer(serializers.ModelSerializer):
class Meta:
model = AssociatedModel
fields = '__all__'


# Tests
Expand Down
2 changes: 2 additions & 0 deletions tests/test_permissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
class BasicSerializer(serializers.ModelSerializer):
class Meta:
model = BasicModel
fields = '__all__'


class RootView(generics.ListCreateAPIView):
Expand Down Expand Up @@ -215,6 +216,7 @@ class Meta:
class BasicPermSerializer(serializers.ModelSerializer):
class Meta:
model = BasicPermModel
fields = '__all__'


# Custom object-level permission, that includes 'view' permissions
Expand Down
3 changes: 3 additions & 0 deletions tests/test_relations_slug.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class ForeignKeyTargetSerializer(serializers.ModelSerializer):

class Meta:
model = ForeignKeyTarget
fields = '__all__'


class ForeignKeySourceSerializer(serializers.ModelSerializer):
Expand All @@ -25,6 +26,7 @@ class ForeignKeySourceSerializer(serializers.ModelSerializer):

class Meta:
model = ForeignKeySource
fields = '__all__'


class NullableForeignKeySourceSerializer(serializers.ModelSerializer):
Expand All @@ -36,6 +38,7 @@ class NullableForeignKeySourceSerializer(serializers.ModelSerializer):

class Meta:
model = NullableForeignKeySource
fields = '__all__'


# TODO: M2M Tests, FKTests (Non-nullable), One2One
Expand Down
1 change: 1 addition & 0 deletions tests/test_response.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
class BasicModelSerializer(serializers.ModelSerializer):
class Meta:
model = BasicModel
fields = '__all__'


class MockPickleRenderer(BaseRenderer):
Expand Down
1 change: 1 addition & 0 deletions tests/test_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ class ValidationMaxValueValidatorModel(models.Model):
class ValidationMaxValueValidatorModelSerializer(serializers.ModelSerializer):
class Meta:
model = ValidationMaxValueValidatorModel
fields = '__all__'


class UpdateMaxValueValidationModel(generics.RetrieveUpdateDestroyAPIView):
Expand Down
5 changes: 5 additions & 0 deletions tests/test_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class UniquenessModel(models.Model):
class UniquenessSerializer(serializers.ModelSerializer):
class Meta:
model = UniquenessModel
fields = '__all__'


class RelatedModel(models.Model):
Expand All @@ -44,6 +45,7 @@ class AnotherUniquenessModel(models.Model):
class AnotherUniquenessSerializer(serializers.ModelSerializer):
class Meta:
model = AnotherUniquenessModel
fields = '__all__'


class TestUniquenessValidation(TestCase):
Expand Down Expand Up @@ -134,11 +136,13 @@ class Meta:
class UniquenessTogetherSerializer(serializers.ModelSerializer):
class Meta:
model = UniquenessTogetherModel
fields = '__all__'


class NullUniquenessTogetherSerializer(serializers.ModelSerializer):
class Meta:
model = NullUniquenessTogetherModel
fields = '__all__'


class TestUniquenessTogetherValidation(TestCase):
Expand Down Expand Up @@ -275,6 +279,7 @@ class UniqueForDateModel(models.Model):
class UniqueForDateSerializer(serializers.ModelSerializer):
class Meta:
model = UniqueForDateModel
fields = '__all__'


class TestUniquenessForDateValidation(TestCase):
Expand Down