Skip to content
Prev Previous commit
Next Next commit
Add explicit on_delete=models.CASCADE to ForeignKey fields.
  • Loading branch information
lovelydinosaur committed Jun 2, 2016
commit 642db43d5aff3ca1dd38f862e4ac6c12e36c333e
2 changes: 1 addition & 1 deletion tests/test_authentication.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

class CustomToken(models.Model):
key = models.CharField(max_length=40, primary_key=True)
user = models.OneToOneField(User)
user = models.OneToOneField(User, on_delete=models.CASCADE)


class CustomTokenAuthentication(TokenAuthentication):
Expand Down
3 changes: 1 addition & 2 deletions tests/test_filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -507,8 +507,7 @@ class OrderingFilterModel(models.Model):


class OrderingFilterRelatedModel(models.Model):
related_object = models.ForeignKey(OrderingFilterModel,
related_name="relateds")
related_object = models.ForeignKey(OrderingFilterModel, related_name="relateds", on_delete=models.CASCADE)


class OrderingFilterSerializer(serializers.ModelSerializer):
Expand Down
14 changes: 7 additions & 7 deletions tests/test_model_serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -403,20 +403,20 @@ class ThroughTargetModel(models.Model):

class Supplementary(models.Model):
extra = models.IntegerField()
forwards = models.ForeignKey('ThroughTargetModel')
backwards = models.ForeignKey('RelationalModel')
forwards = models.ForeignKey('ThroughTargetModel', on_delete=models.CASCADE)
backwards = models.ForeignKey('RelationalModel', on_delete=models.CASCADE)


class RelationalModel(models.Model):
foreign_key = models.ForeignKey(ForeignKeyTargetModel, related_name='reverse_foreign_key')
foreign_key = models.ForeignKey(ForeignKeyTargetModel, related_name='reverse_foreign_key', on_delete=models.CASCADE)
many_to_many = models.ManyToManyField(ManyToManyTargetModel, related_name='reverse_many_to_many')
one_to_one = models.OneToOneField(OneToOneTargetModel, related_name='reverse_one_to_one')
one_to_one = models.OneToOneField(OneToOneTargetModel, related_name='reverse_one_to_one', on_delete=models.CASCADE)
through = models.ManyToManyField(ThroughTargetModel, through=Supplementary, related_name='reverse_through')


class UniqueTogetherModel(models.Model):
foreign_key = models.ForeignKey(ForeignKeyTargetModel, related_name='unique_foreign_key')
one_to_one = models.OneToOneField(OneToOneTargetModel, related_name='unique_one_to_one')
foreign_key = models.ForeignKey(ForeignKeyTargetModel, related_name='unique_foreign_key', on_delete=models.CASCADE)
one_to_one = models.OneToOneField(OneToOneTargetModel, related_name='unique_one_to_one', on_delete=models.CASCADE)

class Meta:
unique_together = ("foreign_key", "one_to_one")
Expand Down Expand Up @@ -598,7 +598,7 @@ def __str__(self):


class DisplayValueModel(models.Model):
color = models.ForeignKey(DisplayValueTargetModel)
color = models.ForeignKey(DisplayValueTargetModel, on_delete=models.CASCADE)


class TestRelationalFieldDisplayValue(TestCase):
Expand Down