Skip to content

Clean up existing deprecation warnings. #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 8 commits into from
Jun 2, 2016
Merged

Clean up existing deprecation warnings. #4166

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
252ccf1
Add Meta.fields = '__all__' to serializer classes where required.
lovelydinosaur Jun 2, 2016
642db43
Add explicit on_delete=models.CASCADE to ForeignKey fields.
lovelydinosaur Jun 2, 2016
c4bc584
Add an explicit fields = '__all__' on automatically generated ModelSe…
lovelydinosaur Jun 2, 2016
55484bb
Remove use of .rel in favor of .remote_field
lovelydinosaur Jun 2, 2016
b91aaa5
Add missing linebreak after imports
lovelydinosaur Jun 2, 2016
745a28e
Use '.remote_field' and '.model' in preference to '.rel' and '.to' wh…
lovelydinosaur Jun 2, 2016
b6a7c52
Use new value_from_object in preference to internal _get_val_from_obj
lovelydinosaur Jun 2, 2016
dc914bf
Add missing on_delete=models.CASCADE to ForeignKey and OneToOneField
lovelydinosaur Jun 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add an explicit fields = '__all__' on automatically generated ModelSe… 
…rializers
  • Loading branch information
@lovelydinosaur
lovelydinosaur committed Jun 2, 2016
commit c4bc584b98bbc75cd5911810341b5cd114cc6427
2 changes: 2 additions & 0 deletions rest_framework/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,6 +1153,7 @@ class NestedSerializer(ModelSerializer):
class Meta:
model = relation_info.related_model
depth = nested_depth - 1
fields = '__all__'

field_class = NestedSerializer
field_kwargs = get_nested_relation_kwargs(relation_info)
Expand Down Expand Up @@ -1469,6 +1470,7 @@ class NestedSerializer(HyperlinkedModelSerializer):
class Meta:
model = relation_info.related_model
depth = nested_depth - 1
fields = '__all__'

field_class = NestedSerializer
field_kwargs = get_nested_relation_kwargs(relation_info)
Expand Down