Skip to content

Make DEFAULT_PAGINATION_CLASS None by default. #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carltongibson merged 7 commits into from
Sep 25, 2017
Merged

Make DEFAULT_PAGINATION_CLASS None by default. #5170

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e52d31d
Changes to the paginator defaults and settings
matteius May 23, 2017
a224b6b
DRF-5168 import warnings
matteius May 23, 2017
420bc48
Add a system checks file
matteius Sep 25, 2017
64bc395
more compatible import approach
matteius Sep 25, 2017
f34da6d
missing bactic
matteius Sep 25, 2017
7a0a5c3
revised language and approach to import the system check
matteius Sep 25, 2017
dd8979d
Adjust doc wording
Sep 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more compatible import approach
  • Loading branch information
@matteius
matteius committed Sep 25, 2017
commit 64bc395759ce87d2170beb4ae77e24715f141c18
2 changes: 1 addition & 1 deletion rest_framework/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
| |\ \| |___/\__/ / | | | | | | | (_| | | | | | | __/\ V V / (_) | | | <
\_| \_\____/\____/ \_/ |_| |_| \__,_|_| |_| |_|\___| \_/\_/ \___/|_| |_|\_|
"""
import checks # NOQA
from .checks import * # NOQA
Copy link
Collaborator

@carltongibson carltongibson Sep 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs on Registering and labeling checks suggest using an AppConfig.ready(). I think we should follow that.

Docs on AppConfig configuration

  1. Add the AppConfig class in rest_framwork/apps.py.
  2. Import check in ready, with comment explaining purpose.
  3. Set default_app_config here.


__title__ = 'Django REST framework'
__version__ = '3.6.3'
Expand Down