Skip to content

Make DEFAULT_PAGINATION_CLASS None by default. #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carltongibson merged 7 commits into from
Sep 25, 2017
Merged

Make DEFAULT_PAGINATION_CLASS None by default. #5170

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e52d31d
Changes to the paginator defaults and settings
matteius May 23, 2017
a224b6b
DRF-5168 import warnings
matteius May 23, 2017
420bc48
Add a system checks file
matteius Sep 25, 2017
64bc395
more compatible import approach
matteius Sep 25, 2017
f34da6d
missing bactic
matteius Sep 25, 2017
7a0a5c3
revised language and approach to import the system check
matteius Sep 25, 2017
dd8979d
Adjust doc wording
Sep 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adjust doc wording
  • Loading branch information
Carlton Gibson authored Sep 25, 2017
commit dd8979d7ba6d7b805fb1c7083e87c10687effd2c
2 changes: 1 addition & 1 deletion docs/api-guide/pagination.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ The pagination style may be set globally, using the `DEFAULT_PAGINATION_CLASS` a
'PAGE_SIZE': 100
}

Note that you need to set both the pagination class, and the page size that should be used. The `DEFAULT_PAGINATION_CLASS` is set to `None` and disabled by default.
Note that you need to set both the pagination class, and the page size that should be used. Both `DEFAULT_PAGINATION_CLASS` and `PAGE_SIZE` are `None` by default.

You can also set the pagination class on an individual view by using the `pagination_class` attribute. Typically you'll want to use the same pagination style throughout your API, although you might want to vary individual aspects of the pagination, such as default or maximum page size, on a per-view basis.

Expand Down