Skip to content

Make DEFAULT_PAGINATION_CLASS None by default. #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carltongibson merged 7 commits into from
Sep 25, 2017
Merged

Make DEFAULT_PAGINATION_CLASS None by default. #5170

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e52d31d
Changes to the paginator defaults and settings
matteius May 23, 2017
a224b6b
DRF-5168 import warnings
matteius May 23, 2017
420bc48
Add a system checks file
matteius Sep 25, 2017
64bc395
more compatible import approach
matteius Sep 25, 2017
f34da6d
missing bactic
matteius Sep 25, 2017
7a0a5c3
revised language and approach to import the system check
matteius Sep 25, 2017
dd8979d
Adjust doc wording
Sep 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
missing bactic
  • Loading branch information
@matteius
matteius committed Sep 25, 2017
commit f34da6dec0c0e912dec953d4929f9ef7248ed80b
2 changes: 1 addition & 1 deletion rest_framework/checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def pagination_system_check(app_configs, **kwargs):
if api_settings.PAGE_SIZE and not api_settings.DEFAULT_PAGINATION_CLASS:
errors.append(
Warning(
"You have specified a default PAGE_SIZE` pagination rest_framework setting,"
"You have specified a default `PAGE_SIZE` pagination rest_framework setting,"
"without specifying also a `DEFAULT_PAGINATION_CLASS`.",
hint="The prior version of rest_framework defaulted this setting to "
"`PageNumberPagination` however pagination defaults to disabled now. "
Copy link
Collaborator

@carltongibson carltongibson Sep 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The default for DEFAULT_PAGINATION_CLASS is None. (In previous versions this was PageNumberPagination)"

Expand Down