-
Notifications
You must be signed in to change notification settings - Fork 367
Fix ESP32-{S2/C2/C3} radio clocks #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d93990c to
4bdb9c3
Compare
0d1c87c to
b6b5ef0
Compare
77a72d2 to
19953a0
Compare
|
Works fine on S2,C2,C3. On ESP32 WIFI also works fine but the BLE example crashes immediately: |
|
I don't have a usable ESP32 at hand, unfortunately. Can you please tell if that crash is a result of this PR or one of the previous ones? Since this one mostly just modifies register values, I'm betting on the latter. |
19953a0 to
de69a47
Compare
|
|
Bizarre. Thanks, I'll investigate somehow. |
|
In the mean time, should I revert ESP32 and offer the rest up for consideration, or should we wait until some miracle happens? :) |
Probably better to revert ESP32 and get the other code merged👍 |
de69a47 to
f3e29a0
Compare
bjoernQ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
* Fix ESP32S2 radio clocks * Fix C2 * Fix C3 * Fix changelog
Counterpart of #679. Submitted as a different PR because I can not test these and I would prefer not delaying the S3 pull request if this one is incorrect somehow.
If some of the code doesn't seem to make sense, you are right. But I just plucked the constants out of esp-idf, without simplifying them. This is particularly visible in S2, where the code:
I'm not touching C6 and H2, those are scary (i.e. they are different enough that I can't tell at a glance whether they are wrong)