Fix ESP32 radio clock code writing incorrect registers #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
esp32_clocks
branch
4 times, most recently
from
14390c8 to
9935a28
Compare
bugadani
force-pushed
the
esp32_clocks
branch
2 times, most recently
from
71887e4 to
feb5a15
Compare
Contributor
Author
|
@bjoernQ I gave up. I restored the clock blanket-enable, added a wall of comments above it, and tested that the This is a bit unfortunate state to leave things in, but I'm a bit out of ideas and I'm not currently interested in solving this optimally. The result is still better than what I found, I hope :) |
bugadani
changed the title
bjoernQ
approved these changes
Aug 8, 2023
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
Thanks for looking into this! So, it's still kind of a mystery but it's cleaned up and we have a few explaining comments 👍
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Fix ESP32 radio clocks * Blanket-enable radio clocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor of #679 and #681.
This PR is not complete as we must blanket-enable all clocks on startup, which esp-idf doesn't do (or, at least, not where I expect it to). Still, with this PR, esp-hal no longer writes WIFI/BT clock bit patterns into the peripheral clock control register, where those bits don't belong.