Repository navigation
lessons: FIX-1903 shift-manager:dev epic cycle - #3447
Conversation
…net 5 says a prompt is a call site Ledger rows for the epic PR, its amendment, four issue specs and twelve implementation PRs (three outside the epic but born from it), plus the wrap's job-surface map and one audit per job that grew. Four fold candidates filed (FIX-2012..FIX-2015) and one comment on FIX-1986. Proposed: one sentence in tenet 5. Two of #3205's prompt fixes left their causes in place and both came back as closure blockers (FIX-1965, FIX-1971), the same shape as cycle 22's #2768. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MJsSFWmTXycBXJU4s96Pk1
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
There was a problem hiding this comment.
Simplify review (cycle ledger + tenet 5)
This PR is docs-only and the measurement story is strong: class (a) is a real loop failure (prompt workarounds while z.unknown(), DevTeam fixtures, and FIX-1872’s path stayed broken), and tying it to tenet 5’s “fix at the owning layer” is coherent. I would not ask to drop the ledger entry or the philosophy sharpen outright.
Where the approach went further than the instrument needs is mostly surface area, not wrong conclusions.
What looks like the right minimum change
Cycles 22 and 23 landed their upstream fixes in operational text (goals/README.md, issue-implement race trigger) with a short apex mirror only when needed. This cycle proposes only docs/philosophy.md for (a). That is defensible (the gap is “nobody reads prompts as call sites”), but it inverts the usual distill pattern: implementers feel issue-implement / worker prompts daily; tenet 5 is always-loaded but easy to treat as abstract.
Cleaner alternative (if you want a smaller, more durable diff):
- Tenet 5: keep a minimal clause—e.g. “A prompt is a call site too.”—and let the parenthetical examples live in
cycle-24.md(or a BP later), not in the apex paragraph that already carries depth/convergence material. - Skill mirror: one sharpened sentence in
issue-implement(or a shared worker checklist): when a model misbehaves on bad input shape / wrong standing doc / thin tool surface, fix that layer before editingWORKER.md. That is where #3205 actually failed. - Drop or collapse Job surface + Job audits (~lines 181–226): these sections are not in 22/23 and read like
audit-coherencedeliverable pasted into the ledger. The routing (FIX-2012–2015, FIX-1986) belongs in Linear / epic wrap / project-spec; the ledger already has “Candidates considered and dropped” and “Filed, not proposed” patterns (cycle 21). A short Filed, not proposed block with issue ids + one-line finding each would preserve signal without a new mandatory section type for every epic wrap. - De-duplicate narrative: FIX-1965 / FIX-1971 / #3205 / cycle-22 #2768 appear in the lede, class (a), the PR table, §(a), and scoring. Consider a thinner PR table (“primary class + one-line upstream miss”) and let §(a) carry the cross-cycle table only—same readability goal as 23’s crash-window section, which synthesizes rather than re-lists rows.
- Method boilerplate: “Endpoints and rounds” is nearly copy-paste from 23; a single line “Same counting rules as cycle 23” (with a link) would shrink maintenance if entries stay self-contained enough.
What I would not block on (owner / process)
- (b)(c)(d)(e) as “owner ask, not text” — consistent with the ledger header.
- Bundling philosophy in the same PR as the cycle file — reasonable when the entry is the proposal record.
- Forensic length in the PR matrix — on par with 23; the issue is added sections, not the table alone.
Verdict
Comment, not approve: the upstream fix direction is sound, but the PR is larger than the smallest change that would move the loop—especially Job surface / Job audits and the long tenet-5 paragraph vs 22/23’s “sharpen existing execution docs first.” If you want one follow-up before merge, I’d prioritize moving or shrinking the job-audit block and splitting tenet 5 (minimal clause) + issue-implement (operational hook); everything else can be a tighten pass on redundancy.
Happy to approve a revision that keeps the (a) thesis and claims/scoring but drops the new audit appendix to filed-issue bullets.
Sent by Cursor Automation: Review For Best Approach
…; fix sample count Tenet 5 keeps only "a prompt is a call site too" and its rule; the examples move into the cycle entry. The ledger's job-surface and job-audit tables collapse to a "Filed, not proposed" list (the full addition list stays in the PR body). The scope count is 18, matching the table. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MJsSFWmTXycBXJU4s96Pk1
There was a problem hiding this comment.
Code Snob. The cycle 24 lead retells the (a) table. Fold #3485 (567f07ad7) into this branch and close that POC unmerged after this lands. Do not reset onto it.
Cut the sentences after the bold result. The incidents stay on the #3205 row, in class (c), and in the (a) table. The owner's #2768 remark was split between the lead and the cycle 22 cell; the cell should carry the whole sentence. "every run was refused" and "input became an object" move into the FIX-1965 cell.
Net −10 against c3175629 (3 insertions, 13 deletions). The tenet 5 sentence, every ledger row, the job list, and the audits stay. This file has no tests. What the deleted sentences said is still in the file: leg b's two failures and both closure ids on the #3205 row, leg b passed under the table, FIX-1872's later path in class (c), the schema and the DevTeam brief in the (a) table, and cycle 22's seen-versus-fixed line in the paragraph under it.
Left the tenet sentence, including the schema / document / tool shapes. That is the sentence this PR asks to approve. Shortening it to "A prompt is a call site too" drops the clause that an instruction is the workaround, and a worker who only reads the tenet would not know which layer. Also left the paragraph under the (a) table and the coherence readout under the job audits.
Sent by Cursor Automation: Code Snob
Folds the subtraction proposed in #3485: the bold result stays, the owner's full #2768 sentence moves into the cycle 22 cell, and "every run was refused" / "input became an object" move into the FIX-1965 cell. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MJsSFWmTXycBXJU4s96Pk1
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c81de4f0f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…e approval endpoint The tenet 5 sentence now applies only when the instruction is right, so a genuinely missing or wrong prompt can still be fixed in the prompt. Each cycle 24 row carries its findings' classes, with totals per kind, and the endpoint note says the owner's merge is the direction approval here. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MJsSFWmTXycBXJU4s96Pk1


What this is
This is the
distill-lessonsloop, run at wrap for epic FIX-1903 ("out of the box,shift-manager:devdevelops Shift Manager and FSD"). It adds two things.docs/internal/cycle-ledger/cycle-24.mdand its index row).docs/philosophy.md): a prompt is a call site. No new BP.What the ledger found
WORKER.md. At closure both came back from their real causes:input: z.unknown()let the chief of staff send the project as a string.fsdprofile inherited DevTeam's demo brief.finally, the WAL sidecars were dropped, and commits were graded from a stalemain.GOAL_LEGprinted PASS. That is the exact shape of FIX-1183, which is still in Backlog.mainred.nit, the top implementation class ismissed-edge-case: 36 of 67 findings (54%). FIX-1927: a local checkout's run starts from the current base, not a stale main #3201 carries 17 of those.ea68a989is an ancestor of every first head.The proposal
Insert in tenet 5, after "A workaround every caller must copy is a smell.":
The sentence is scoped to a correct instruction, so a prompt that is missing or wrong (as in FIX-1185) is still fixed in the prompt. The examples (a schema that accepts the wrong shape, a document written for another profile, a tool that returns too little) live in the cycle entry, not the apex paragraph.
Dropped, with reasons in the cycle file:
Job audit: every addition considered, and the job it named
projectWorkspace({ checkouts }),ProjectCheckout(#3185);checkoutSource(#3194);RunLocation.orgless(#3199); fetch-before-cut and upstream pins (#3201)baseCommiton the run record,readRunCommits(…, baseCommit)(#3201)probeClaudeAccountand its types (#3189);startHarnessstart check (#3189)CLAUDE_CODE_PASSis copied twice → FIX-2014mcpToolsoption andClaudeCodeMcpTool*(#3261);projectMcpToolsandRelayedMcp*(#3261);MCPCallToolOptions(#3261)redactSecrets(#3261)redactskips secrets under 8 chars, so a short MCP key leaks into a report → FIX-2012mcpCredentialsCapability,defineMcpCredentialsCollection,mcpCredentialSchema,mcpCredentialProblem,MCP_CREDENTIALS_*; Settings route (#3261)setMcpServersand schemas,checkedMcpServers,isMcpServerName(#3261)openLab({ documents, skills })(#3317)fsdruns → FIX-2013addTask/dispatchTaskinputmust be an object (#3308)ConversationpassesgroupToolCalls(#3272)All new issues are in "Workforce: Shift Manager", in Backlog, and related to their source issues.
What's asked of you
Should we take the tenet 5 sentence, or reshape it?
distill-lessonsreview gate applies.When you approve a spec by merging, should you wait for a requested Codex pass?
Two scheduling calls carried over from cycle 23:
pnpm goal:all --model-freeonmainnightly. Right now goal checks rot between a merge and the next closure.goals/README.mddeliberately keeps goals out of CI, so this call is yours.Already handled at wrap:
end-state.svgfigure is being fixed in a separate amendment.Verification
pulls/{n}/reviews,/comments, andissues/{n}/comments. Linear children and issue text were read over GraphQL.git merge-base --is-ancestor ea68a989 <first head>returned YES for all 12 implementation PRs.redact.tsMIN_SECRET = 8vsredactSecretsCLAUDE_CODE_PASSin both filesbranch-namingand handbook markersproject-mcp-tools.ts"matched structurally"check-retired-terms,validate-model-strings,validate-reserved-namesandvalidate-no-nul-bytes. All pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01MJsSFWmTXycBXJU4s96Pk1