Skip to content

spec(epic): every stop for a person is one Inbox item (FIX-2058) - #3732

Merged
jhoffner merged 3 commits into
mainfrom
epic/waiting-on-a-person
Oct 23, 2026
Merged

jhoffner merged 3 commits into
mainfrom
epic/waiting-on-a-person

Conversation

@jhoffner

@jhoffner jhoffner commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator
A team that… Today After this epic
uses Shift Manager The Inbox shows approvals and input. A question or a review parks where the Inbox cannot see it. A coding run's question has no screen Each stop that waits on them is one Inbox item. They answer it there, and the same attempt continues
builds a worker that files work Answers a question with answerTask, a second tool. Cannot ask before a task starts Answers a midway question with a steer, and the first answer wins. Can file a task held on questions
writes a flow that asks a person An approval expires only as a rejection. A question has no deadline. A user's stop does not tell the board One waitForUser({ kind, prompt, deadline? }), 7 days by default. The flow decides at the deadline. A cancel or a stop closes the item
runs flows locally or self-hosted fsdev run with no app config refuses to stop for a person Durable execution is the default on file-backed hosts
maintains the framework Six forms of a stop for a person, three answer paths One suspension, one held start, one answer path

Goal: a person sees each stop that waits on them as one Inbox item and answers it in one place. The answer continues the same attempt; a task held on questions starts after its last answer. This applies to an approval, a question, a review, a coding run's question and a task held on questions.

flowchart LR
  A["Shift Manager · real model · durable file-backed host"] --> L1["leg a · one stop of each kind"]
  L1 --> I["the Inbox · one item per stop"]
  I --> L2["leg b · answer it there"]
  I --> L3["leg c · cancel its task"]
  I --> L4["leg d · steer it while it waits"]
  L2 -->|"same attempt, claim kept · a held task starts · item closes"| P["PASS · the epic's goal is met"]
  L3 -->|"item closes"| P
  L4 -->|"answers or waits · no request beside it"| P
  C["control · today's main"] -.-> L1
  L1 -.->|"under the control"| F["must FAIL · four kinds missing"]
Loading

The closure issue's goal check (FIX-2134) proves it, with a sweep for the five retired names. Control: today's main, where four kinds do not reach the Inbox and the Inbox cannot answer a stop in a task's request. Each control runs red at least once. Why this goal: SPEC.md.

What's in the box: waitForUser with three kinds and a deadline, held on questions, the task's person mark and its recorded stop, one Inbox for every stop, durable by default. Composed in by the app: deadline handling, which kind, the Inbox screen. Replaced in one line: the parks, answerTask, the harness inbox. Not built: the Not doing list

A flow gets the box when it calls one function. Below the fence is the Not doing list.

Lead measure: the children whose own goal check passes on main, by name. None today. Kill line: if FIX-2063 cannot make durable execution the default on dev, local and self-hosted hosts, we stop before we retire a park.

Why now. FIX-2056 is in its last PRs (#3701, and #3692, its closure). Its claim gate already records a person's stop on the task row, and steers exist. The renames (FIX-2071) wait for this epic.

The set: five issues and a closure. FIX-2063 (durable by default), then FIX-2129 (a stop holds its task and resumes once), then three in parallel: FIX-2131 to FIX-2133. As of 2026-10-23: all in Backlog. The spec records that snapshot and links to live state.

Who owns what: seven rules by five issues and the closure FIX-2134, each rule with one owner

Each rule has one owner. Two would be a seam; none would be a gap.

Sign off

The goal, at that size: five kinds, one Inbox, the same attempt. If wrong: we close the epic and a person still cannot find a stop.

The set's debt: net down. Two parks, the harness inbox and three answer calls go. waitForUser, held on questions, a default deadline and one trusted answer route come in. If wrong: map entries that nothing reads.

Durable execution by default comes first, and no park stays as a fallback · D1

D1: durable by default first with no park kept, chosen, beside keeping the parks as a fallback. Decides it: two forms of one job, which the epic removes. Price: a host without durability cannot stop for a person

It comes down to two forms of one job: a fallback park keeps what the epic removes. If wrong: a host we support loses stops for a person, and the kill line fires.

A person's stop has a default deadline of its own, 7 days · D3, decided by the owner

D3: a default of its own for a person's stop, 7 days, chosen, beside the 5-minute wait default and no default; decided by work failing while a person is away

It comes down to a person being away: the wait default fails their work within minutes. A host setting, overridable on each call; FIX-2129 builds it and names it in the concept doc. If wrong: one host setting.

What would change my mind on D1: a host we support that cannot be durable. Reasoning, what lost, and the rules each child obeys: DECISIONS.md.

Reviewers · look here

  • Changed in review. FIX-2130 is now part of FIX-2129, so waitForUser ships with its deadline and cancel, and a person's stop resumes with cancelled, not the wait gate's stopped. ER-7 gives the Inbox one trusted route to answer a stop in a task's request; today it cannot. epic(LAB-162): OMP coding runs ask, park, and continue #1612 (LAB-162) is closed as superseded by FIX-2132; LAB-163 needs a fresh spec if still wanted.
  • Decisions → D2. The row's person mark, not the session's key, keeps a task's requests apart during a stop. Today a steer starts a request beside a waiting one. Messages are not decided here: they follow rule 10, and the call is FIX-2070's. If wrong, three children change.
  • The Linear epic's open questions are settled: the deadline rule, one card for a coding run's question, and no shim for in-flight parks.

Not here: the approach of a single issue. Those are the spec PRs.

Spec · Decisions · Linear FIX-2058 · Project: Orchestration Primitives · merges after human approval and required checks

How to review this — an epic-spec, not an implementation plan

This is an epic-spec: the shared objective and cross-cutting decisions for a set of
issues, in a retained document set. It is not any one issue's implementation design, and it
is not a schedule.

In scope to challenge:

  • The objective and the goal in SPEC.md — is this body of work worth doing, and is the
    goal the real need at full size, or a smaller one the set could meet while the need stays
    unmet? Would the closure issue's check fail if the goal were not met?
  • Whether the set overbuilds. Each issue can earn its place while the whole is too much.
    That question can only be asked here.
  • The set's debt in SPEC.md — something the set overlaps and doesn't name, or adds and
    doesn't list.
  • A cross-cutting decision in DECISIONS.md — shared surface, naming, sequencing, contracts.
  • A rule in DECISIONS.md → Who owns what with no owner, or two.
  • A missing issue the objective implies, or one in the set that doesn't serve it.

Out of scope — owned by the individual issue specs:

  • Any single issue's approach, architecture, file layout, or test plan.
  • Anything that touches exactly one issue. It belongs on that issue's spec PR.
  • The figures, at the pixel level, and routine status movement since the dated snapshot.
  • POC production polish. End-state experiments under the owning spec's poc/
    show shape and scoping, not shippable implementation. Directional evidence, experimental
    isolation and absence of secrets/generated dependencies remain in scope.

Feedback in the second list is routed to the issue it concerns as an implementer note, not
folded in here.

Required repository checks, approvals and review-thread policy still govern merge.
Optional comments are triaged, not a reason to grind to zero or restart the design review.

https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6


Generated by Claude Code

The epic-spec for FIX-2058: SPEC.md (teams, the goal and its closure
check, the five objective lines, the box, the set with closure FIX-2134,
the graph, what's already here and the debt) and DECISIONS.md (D1 durable
first with no fallback park, D2 the row's person mark, six rules with one
owner each, seams, settled questions, and one open question for the owner).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Oct 23, 2026 2:07pm UTC
flow-state-dev-kitchen-sink Ignored Ignored Oct 23, 2026 2:07pm UTC
flow-state-dev-ui Ignored Ignored Preview Oct 23, 2026 2:07pm UTC

Request Review

@linear-code

linear-code Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

FIX-2058

FIX-2129

@jhoffner

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T13:49:08.761072Z 19e4346 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jhoffner

Copy link
Copy Markdown
Collaborator Author

Architect — one coherence gap: this epic reverses open epic #1612 (LAB-162) without naming it.

#1612 (epic/pi-harness, open, not draft) is still the live epic-spec for a coding run's question. Its contract is the opposite of FIX-2132 here:

Both can't be the plan. FIX-2058 is the direction Jake has backed (coordination refactor first, parks retired), so this one should win, but it has to say so:

  1. Add a row to What's already here, and the debt for epic(LAB-162): OMP coding runs ask, park, and continue #1612 / LAB-162: what it decided (park, no suspension, harness inbox as the answer route), and Replaced by FIX-2132 + D1.
  2. In FIX-2132's row (or DECISIONS), state what happens to epic(LAB-162): OMP coding runs ask, park, and continue #1612: closed with a pointer here, or its OMP dispatch half (OMP as a harness slot, same contract, session continuity) kept and its ask/park half dropped. Session continuity already appears under What stays (door.ts), so the split looks natural.
  3. Then epic(LAB-162): OMP coding runs ask, park, and continue #1612 gets a matching close-or-rewrite comment, so no child spec reads it as current.

Nothing else here forks in-flight work. It builds on FIX-2077 D1 / FIX-2056 D2–D3 / #3696 as stated, and it agrees with the 2026-10-22 call that steer is the only way to change open work.

— FSD Architect

Copy link
Copy Markdown
Collaborator Author

Second-look + architecture pass (spec-only PR, so this is about shape and the code the seams cite)

I read SPEC.md + DECISIONS.md against the current main code. Overall the direction is sound (one suspension, one answer path, net-down debt). Findings below are ranked; the first three could change a child's spec.

1. waitForUser may be a third wait mechanism, not the merge of two

core/src/types/wait-gate.ts already has a wait gate (reason: "wait", parkOnWait, WaitOutcome = answered / deadline / stopped, isExpiredApproval). Approvals and input are separate suspension reasons (human_approval, human_input). The seams table says FIX-2130 "uses the same outcome words", but ER-1 never says whether waitForUser is built on the wait gate (a gate bound to a person, with a kind) or beside it. If beside, the framework goes from "six forms" to six minus the parks plus one new call over two existing suspension families. Suggest ER-1 state it explicitly, and have FIX-2129's spec price the "extend the wait gate with a person binding" shape (smaller surface, and the exactly-once/deadline resume in ER-3 is then inherited rather than rebuilt in FIX-2130).

2. "Two copies of is-it-a-person's-stop" is three

task-board/task-request.ts:306 (stopOf: human_approval || human_input), shift-manager/src/lib/reads.ts:332 (PERSON_REASONS, used at 816), and shift-manager/src/lib/send.ts:143-157 (its own stopOf, which also consumes PERSON_REASONS to pick "ask" vs "wait"). Orchestration and shift-manager also can't share a predicate unless it lives in core/contracts (shift-manager must not import orchestration internals just for this). ER-1 should name the home package for the predicate (recommend contracts next to suspension.ts, which already defines the reasons), and list send.ts among the readers FIX-2129/2131 must migrate. Otherwise the "no child keeps its own list" rule is unenforceable at the package boundary.

3. FIX-2129 / FIX-2130 are one issue in practice

The spec already flags 2129 as the cut candidate ("FIX-2077 already marks a person's stop and drops the lease, leaving waitForUser and the row's record"). ER-3 (resumes exactly once, deadline, cancel) is part of what waitForUser means; shipping the call in 2129 without its resume contract means 2129 lands a call with no defined deadline behavior, and 2131/2132 can only start after 2129 but need 2130's semantics to be tested honestly (the graph shows 2131/2132 not blocked by 2130). Recommend merging 2129+2130 (one PR: call + row record + resume-once + cancel), leaving four parallel children after it. That also removes the "2130's spec needs the open deadline answer" ordering hazard. If the PR is too big, split by layer (engine suspension/deadline vs. task-board row/mark), not by call vs. resume.

4. FIX-2133 may not need FIX-2063

"Held on questions" is a row state released by the last answer (a held start, not a suspended request), so it shouldn't need durable execution to exist. The graph blocks it on FIX-2063 only transitively via 2129. If 2133 only needs "the open question on the row", it can start earlier / in parallel with 2063; worth stating so the kill line (2063 failing) doesn't also freeze a child that doesn't depend on it. Conversely, if it does depend on durable resume to release the task, say that in its row.

5. Stale/incorrect citation

harness-manager/src/door.ts:15-20 (listed under "What stays as it is") does not exist on this branch (find packages -name 'door*' is empty). Please re-point it, since a child will be told not to touch it.

6. ER-2 (mark, not key) – check the race it leaves

D2 says every admit path reads the row's mark. The mark is written when the claim gate records the stop (after the request ends/suspends), while steer admission reads the row. There's a window between the request suspending and the mark landing where a steer could be admitted beside the waiting request – exactly the failure D2 says it prevents. The spec cites #3696's per-request plan mark as precedent; FIX-2129's spec should say whether the mark is written before the lease drops (same write) so no window exists, and the closure should carry a concurrent steer-during-stop leg (BP-035 concurrent path). Today's closure legs a/b/c don't cover it.

7. Smaller notes

  • Default deadline (open item): 7 days is reasonable, but "unhandled question/review errors, using an attempt" means a forgotten Inbox item silently burns a retry a week later with nobody watching. Consider the unhandled-at-deadline case closing the item and marking the task (so the Inbox doesn't show a dead item) as an explicit requirement for FIX-2130, regardless of the default length.
  • Closure sweep as the only guard for "no park survives": the sweep lives in rules.mjs on fix/FIX-2087, which isn't on main. If 2087 slips, the epic's "not done if" has no mechanical check. Note the dependency on FIX-2087 landing (or put the sweep in the closure issue itself).
  • No shim for in-flight parks, but ER-5 still reads pre-refactor rows: consistent per the owner note; just make sure FIX-2131's tests include one persisted legacy parked row (BP-030 dual-read) since that is the one case the no-shim decision doesn't waive.

Architecture-improvement lens

Worth pulling into this epic rather than separately (it's exactly the "refactor while implementing" case): the single person-stop predicate (#2) and collapsing the answerTask/parkOnQuestion/awaitReview/unparkAndDrain surface, which touch ~25 orchestration test files — plan the test migration as part of FIX-2131 so the deletion PR isn't also a test-rewrite PR. I'd not fold in an Inbox redesign (correctly out of scope).

No blocking issues; #1–#3 are the ones I'd want the author to settle before the child specs are written.


Generated by Claude Code

@jhoffner

Copy link
Copy Markdown
Collaborator Author

FSD Architect: coherence check on this epic

One two-direction seam the spec doesn't name yet: the open, never-merged epic #1612 (LAB-162, "OMP coding runs ask, park, and continue").

  • LAB-162 has a coding run's question park the task, ends the worker request, and reuses the harness-manager inbox and answer action as is. Its "Not built" list explicitly excludes worker suspension.
  • This epic's FIX-2132 goes the other way: the coding flow's request suspends with waitForUser, the harness inbox goes, and the closure sweep requires answerQuestion() to have no references.

Both can't land. The concept doc (#3534) already settled the direction (one suspension, no parks), so this epic should win. It should say so in writing, so LAB-162 doesn't keep building on the inbox FIX-2132 deletes.

Asked changes:

  1. In What's already here, and the debt (or Not doing), add a row for LAB-162 / epic(LAB-162): OMP coding runs ask, park, and continue #1612. Say what this epic keeps (dispatch through the harness contract, continuing the same saved session; this matches What stays as it is, door.ts) and what it supersedes (the coding-run park and the harness inbox as the answer path).
  2. In the FIX-2132 row, or in its Linear issue, state what happens to LAB-162: it gets amended to waitForUser before any of its park work merges, or it closes as superseded by FIX-2132. Either is fine, but pick one. Don't leave it open in both directions.
  3. If any LAB-162 child is already in flight on the inbox route, list it next to FIX-1851 as related and superseded.

No other forks found against open work. FIX-2056 (D2/(e)), FIX-2070, FIX-2071, FIX-2077, FIX-2080 and #3696 are all cited and consumed, not re-decided.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/simplify review — direction looks right; trim apparatus, sharpen child specs

This is a spec-only epic PR (759 lines, SPEC.md + DECISIONS.md + figures). I ran parallel read-only passes (quality, operational perf, reuse against FIX-2056 and the engine/orchestration seams). No direction forks that would block approval — unifying person stops under one suspension + one Inbox path, D1 (durable first, no park fallback), and D2 (row mark vs reply-line key) are coherent with FIX-2056 and what’s already in task-request.ts / the wait-gate outcome vocabulary.

Did the approach go too far?

On work / issue graph: no. Six children + closure is smaller than FIX-2056 and matches real subsystem boundaries (durability default → waitForUser spine → parallel retirements → closure). A single mega-issue for all of waitForUser would trade coordination tables for an unreviewable monolith and still wouldn’t merge FIX-2063’s kill line.

On spec density: mildly yes — mostly duplicate channels, not wrong scope:

  • ER-6 largely restates D1 (consider one owner).
  • Coordination seams + ER table repeat “who owns what” (seams → file pointers; ER → rules only).
  • Kill line, sweep list, and “six forms → one” recur in goal, debt, and closure (one canonical bullet + links elsewhere).
  • Five decision SVGs + three mermaids mirror FIX-2056; the open deadline figure gates nothing — a table may be enough.

Optional simpler issue graph (only if you want fewer Linear cards, not required): fold FIX-2129 + FIX-2130 into one spine PR and/or FIX-2131 + FIX-2132 + FIX-2133 into one “surfaces + retirements” issue. The spec already flags FIX-2129 as the cut candidate if the child spec is only “record the stop” after FIX-2077 — I’d act on that early in issue-spec rather than carrying a thin issue for ceremony.

Reuse / third-party packages

FIX-2063 should stay on engine checkpoint durability + sweeper (createCheckpointDurabilityProvider, durability-sweeper, stop-suspended) — not BullMQ (dispatch queue ≠ suspension store). Child spec should be explicit about today’s gap: durable: true alone doesn’t imply a sweeper on fsdev run / getRuntime() paths (createFlowState.ts documents router-only sweep). D1’s kill line needs both default-on durability for persistent profiles and a liveness story for the sweeper on dev/CLI hosts.

waitForUser doesn’t exist in code yet — fine as product vocabulary; FIX-2129 should say thin wrapper over ctx.suspend + shared isPersonSuspension (replace stopOf + PERSON_REASONS + goals copies) so implementers don’t hunt a missing export.

Clarify for child authors: person stops use suspension records; wait-gate.ts remains for filed-task / dispatch waits (FIX-2082) — reuse outcome words, not the wait-gate mechanism.

Performance (design-level, not blocking)

Unification is a steady-state win (one path, kept claim). Watchpoints to encode in FIX-2131 / FIX-2133 specs (not necessarily in this epic doc):

  • Held-on-questions Inbox items should come from board snapshot already loaded in LabReader, not per-task getTask N+1 on refresh.
  • Person deadlines should use suspension expiresAt + existing sweeper re-arm, not a second poll loop.
  • Default 7d deadline reduces churn vs 5m task waits; correlated expiries may burst sweep ticks — acceptable if documented.

POC gap

DECISIONS notes no end-state POC (closure is first integrated proof). Reasonable given FIX-2056 seam coverage; slightly higher UX regression risk than FIX-2056’s claim-gate POC. One explicit sentence in SPEC that 2134 is intentionally the first integrated proof would match expectations.

Skipped (needs owner / child spec, not epic gate)

  • Default deadline value (open section is well-formed).
  • No BP-030 shim between refactor epics — defensible with deploy ordering; highest cost if production straddles epics (already owner-recorded).
  • External Claude artifact link in “real need” — weak for long-lived repo canon (nit).

Verdict: Approve the epic direction. Before child specs merge, I’d dedupe ER/seams prose, resolve FIX-2129 thinness, and pin FIX-2063 + Inbox read constraints so implementation doesn’t reintroduce dual paths or N+1 reads.

Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

Comment thread specs/epics/FIX-2058/SPEC.md Outdated
| [FIX-2133](https://linear.app/fixpoint-labs/issue/FIX-2133) · held on questions | Asked at filing, one item, the last answer releases it | FIX-2063, FIX-2129 |
| [FIX-2134](https://linear.app/fixpoint-labs/issue/FIX-2134) · closure · **required** | The QA plan, on one `main` commit | every other child |

Six and a closure. The one I'd cut is FIX-2129: FIX-2077 already marks a person's stop and drops

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify lever (consider, not blocking): You already name FIX-2129 as the cut candidate if the child spec is “only the row record” after FIX-2077. I’d decide that in the first FIX-2129 issue-spec wake and fold into FIX-2131 if true — otherwise six issues risks ceremony for a spine that’s mostly D2/ER-2 wiring.

Alternative issue graph if you want fewer cards: 2129+2130 as one “waitForUser + mark + resume-once + cancel” issue (keeps 2063 gate and 2134 closure).

- **Serverless hosts without durable execution** ([D1](DECISIONS.md#d1)).
- **An Inbox redesign** beyond listing every stop.

**Kill line:** if FIX-2063 can't make durable execution the default on dev, local and self-hosted

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIX-2063 child spec guardrail: D1’s kill line isn’t only durable: true on persistent stores — today the stale/suspension sweeper is tied to router startup (createFlowState comments: fsdev run / getRuntime() may not sweep). Child spec should name sweeper-on-CLI (or equivalent refusal) explicitly; otherwise “durable by default” and “person stop refuses loudly” can diverge.

| ER-3 | A stop resumes exactly once: answered, deadline or cancelled. Whichever comes first wins and the rest find it resolved. A user's stop ends the request, closes its item and cancels its task | FIX-2130 | FIX-2131's, FIX-2132's and FIX-2133's spec review; legs b and c |
| ER-4 | No task tool answers a stop for a person. The filer answers only a question its task asked midway, by a steer, and not on a routed task; approvals, reviews and held questions are the user's (rule 11) | FIX-2131 | Every later spec review; the closure sweep |
| ER-5 | A row parked before the refactor is read through FIX-2080's one map ([FIX-2056 D3](../FIX-2056/DECISIONS.md#d3)), never a child's own read. States in flight between the refactor epics get no shim | FIX-2131 | FIX-2132's spec review |
| ER-6 | Stopping for a person needs durable execution, on by default wherever stores persist. No child builds a path for a host without it; such a host refuses a stop loudly | FIX-2063 | Every spec review |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc dedup (nit): ER-6 restates D1 + the kill line almost verbatim. Consider ER-6 → “See D1” or a single row that references D1 only — same rule, one place to update when FIX-2063 lands.

Comment thread specs/epics/FIX-2058/DECISIONS.md Outdated
| The claim gate's stop arm (`orchestration/src/task-board/task-request.ts`, `stopOf`) | FIX-2129 keys it on ER-1's predicate and records the suspension on the row; FIX-2130 adds the cancel and the user's stop |
| The suspension record, the stop and the sweep (`core/src/types/suspension.ts`, `engine/src/durability/stop-suspended.ts`, `durability-sweeper.ts`) | FIX-2063 runs the sweeper on file-backed hosts; FIX-2129 adds the kind; FIX-2130 the deadline resume and the stop that cancels. The wait gate (`core/src/types/wait-gate.ts`) already resumes once with answered, deadline or stopped: FIX-2130 uses the same outcome words, not a second set |
| Steer admission (`workforce/src/conversation-board/steer.ts`, `task-admission.ts`) | FIX-2113's gate stays for plan waits. FIX-2131 makes a steer into a task waiting on a person answer or wait (ER-2); FIX-2132 makes it end the coding run |
| The Inbox read (`shift-manager/src/lib/reads.ts`, `surfaces/Inbox.tsx`) | FIX-2131 lists questions and reviews through ER-1's predicate; FIX-2133 adds held tasks, read from task rows; FIX-2132 adds nothing a question doesn't |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perf / simplify for FIX-2133: When child specs define held-on-questions Inbox items, specify they are projected from task rows already in the board snapshot (LabReader step 4), not a per-refresh getTask / listTasks walk. That keeps the unified Inbox from becoming an N+1 read path.

Comment thread specs/epics/FIX-2058/DECISIONS.md Outdated
| Seam | Owner, then who else touches it |
|---|---|
| The claim gate's stop arm (`orchestration/src/task-board/task-request.ts`, `stopOf`) | FIX-2129 keys it on ER-1's predicate and records the suspension on the row; FIX-2130 adds the cancel and the user's stop |
| The suspension record, the stop and the sweep (`core/src/types/suspension.ts`, `engine/src/durability/stop-suspended.ts`, `durability-sweeper.ts`) | FIX-2063 runs the sweeper on file-backed hosts; FIX-2129 adds the kind; FIX-2130 the deadline resume and the stop that cancels. The wait gate (`core/src/types/wait-gate.ts`) already resumes once with answered, deadline or stopped: FIX-2130 uses the same outcome words, not a second set |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good seam list. For child authors: add one line that person stops = suspension + row mark; wait-gate.ts stays for dispatch/task waits (FIX-2082). Reuse wait-gate outcome vocabulary in FIX-2130, not the wait-gate mechanism — avoids implementers conflating two “wait” systems.


## What the end-state POC showed

None built. The seams sit on code FIX-2056 has just shipped and tested (the claim gate's stop

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Process note (optional): No end-state POC (closure is first integrated proof) is acceptable given FIX-2056 seam tests, but slightly higher regression risk on Inbox UX. One forward pointer in SPEC (“2134 is the intentional first E2E proof”) would set expectations without building a POC here.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19e4346eab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread specs/epics/FIX-2058/DECISIONS.md Outdated
| The claim gate's stop arm (`orchestration/src/task-board/task-request.ts`, `stopOf`) | FIX-2129 keys it on ER-1's predicate and records the suspension on the row; FIX-2130 adds the cancel and the user's stop |
| The suspension record, the stop and the sweep (`core/src/types/suspension.ts`, `engine/src/durability/stop-suspended.ts`, `durability-sweeper.ts`) | FIX-2063 runs the sweeper on file-backed hosts; FIX-2129 adds the kind; FIX-2130 the deadline resume and the stop that cancels. The wait gate (`core/src/types/wait-gate.ts`) already resumes once with answered, deadline or stopped: FIX-2130 uses the same outcome words, not a second set |
| Steer admission (`workforce/src/conversation-board/steer.ts`, `task-admission.ts`) | FIX-2113's gate stays for plan waits. FIX-2131 makes a steer into a task waiting on a person answer or wait (ER-2); FIX-2132 makes it end the coding run |
| The Inbox read (`shift-manager/src/lib/reads.ts`, `surfaces/Inbox.tsx`) | FIX-2131 lists questions and reviews through ER-1's predicate; FIX-2133 adds held tasks, read from task rows; FIX-2132 adds nothing a question doesn't |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Assign a safe answer route for task-dispatched asks

When a dispatched task calls the proposed waitForUser({ kind: "question" }), its request is stamped with source task; the public resume route rejects that source (packages/engine/src/routes/resume-routes.ts:111-117), and Shift Manager consequently marks the ask unanswerable (packages/shift-manager/src/lib/reads.ts:834-839). This seam assigns FIX-2131 only to list the item, while no issue owns a secure internal resolution path and ER-4 rules out the existing task-answer tool, so clicking Answer cannot resume the same attempt and the central leg-b goal fails. Assign an issue to implement the task-safe answer route without reopening task requests through the public re-entry endpoint.

Useful? React with 👍 / 👎.

Comment thread specs/epics/FIX-2058/SPEC.md Outdated
| How we verify | |
|---|---|
| **Goal check** | The closure issue's (FIX-2134), real model, in Shift Manager, on one `main` commit after every other child merges |
| **Signal** | Leg a: each of the five kinds shows as one item. Leg b: an Inbox answer resumes the same attempt with its claim. Leg c: cancelling the task closes its item. A sweep: `answerTask`, `parkOnQuestion`, `awaitReview`, `unparkAndDrain` and harness-manager's `answerQuestion()` have no references in package source |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Split held-task verification from same-attempt resume

For the held-on-questions case, there is no attempt or claim to resume: a held task starts with attempts: 0, and claiming it after release creates its first attempt (packages/orchestration/src/tasks/collection/internal.ts:91-100,1281-1329). This signal nevertheless requires each of the five kinds to resume the same attempt with its claim, contradicting the adopted rule that a held task starts only after its last answer. FIX-2134 must therefore either fail forever for held questions or silently omit one of the five cases; require same-attempt resume only for suspension-backed items and separately assert that a held task starts its first attempt after the final answer.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Architect: not approving yet

The model fits the concept's Inbox section and rules 11 and 12, and it fits FIX-2103 and the steer-only rule. The #1612 (LAB-162) supersede note asked for above still stands. Before approval:

  1. Cancel outcome (DECISIONS seams, wait-gate.ts). The wait gate's words are answered, deadline and stopped, and stopped ends the request with no model reading it. The concept's person stop resumes with cancelled, and the block runs to its end. FIX-2130 needs a cancelled outcome the block reads, so please drop "not a second set".
  2. Messages during a stop (D2, ER-2). Giving back the session key means a message to a session waiting on a person can run rather than queue as rule 10 says. Please state that messages follow rule 10 as written until that decision is made, and pin today's behaviour with a test. D2 shouldn't settle it.
  3. Deadline default. The concept says waitForUser defaults to "the host's" deadline, the same wording used for waits. If the person stop gets a default of its own, FIX-2130 should amend concept L219 to name it.
  4. Small fixes:

Leans for sign-off: D1 agree; D2 agree once item 2 is fixed; keep FIX-2129 separate, rescoped, because three children build on waitForUser and the predicate; 7-day default as its own host setting.

— FSD Architect

- FIX-2130 folds into FIX-2129: waitForUser ships with its deadline,
  cancel and stop; ER-3 moves owner, ownership matrix redrawn.
- LAB-162 (#1612): its coding-run park is superseded by FIX-2132 and D1.
- ER-1: waitForUser on the person suspensions, not the wait gate; one
  predicate in contracts, three copies today (send.ts added).
- ER-7: one answer route the server trusts; today the Inbox cannot
  answer a stop in a task's request (resume-routes source check).
- Goal check: a held task starts rather than resumes; leg d for a steer
  during a stop; ER-2 mark lands with the lease drop.
- Re-point door.ts (renamed) to the harness resume resolver.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
@jhoffner

Copy link
Copy Markdown
Collaborator Author

Record mismatch with #1612's close (please reconcile before approval).

Two minutes apart, #1612 got two different stories:

#1612 is now closed, so "D2 rewritten here" has no home. Please align this PR with the close:

  1. SPEC.md debt table (the LAB-162 row): drop "open" and "stays LAB-162's"; say epic(LAB-162): OMP coding runs ask, park, and continue #1612 is closed as superseded, and LAB-163 needs a fresh spec on waitForUser if wanted.
  2. DECISIONS.md → Decided in review (LAB-162 bullet): same change; remove "whose D2 is rewritten before it starts".
  3. Optionally post a one-line correction on epic(LAB-162): OMP coding runs ask, park, and continue #1612 so the 13:57Z note doesn't read as current.

LAB-164 closing as superseded by FIX-2132 on approval is fine as written.

— FSD Architect

@jhoffner jhoffner added the Epic label Oct 23, 2026
- D3: a person's stop has its own default deadline, 7 days, a host
  setting overridable per call (owner, 2026-10-23); FIX-2129 amends the
  concept's L219 wording. The Open section closes; its figure becomes
  D3's trade-off.
- #1612 closed as superseded: LAB-163 needs a fresh spec on waitForUser
  if still wanted, no longer "stays LAB-162's".
- ER-1: a person's stop resumes with cancelled, sharing only answered
  and deadline with the wait gate.
- D2 and ER-2: messages follow rule 10, FIX-2070's call; retired words
  (turns, reply-line key, notices) replaced in prose and figures.
- Small fixes: waitForUser's prompt in the teams table, FIX-2056's open
  PRs, map entries no longer tied to FIX-2071.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6

Copy link
Copy Markdown
Collaborator Author

Folded in 7458646.

  • The deadline question, answered by the owner (2026-10-23): recorded as D3. A person's stop has its own default deadline, 7 days, a host setting overridable on each call by waitForUser's deadline, separate from the wait default. FIX-2129 builds it and amends the concept doc's "defaults to the host's" wording (L219) to name it. DECISIONS.md → Open is now empty.
  • epic(LAB-162): OMP coding runs ask, park, and continue #1612's close: the debt row and the Decided in review bullet now say epic(LAB-162): OMP coding runs ask, park, and continue #1612 is closed as superseded; LAB-163 needs a fresh spec on waitForUser if still wanted. LAB-164 closing on approval is unchanged.
  • Architect's 13:49 items: a person's stop resumes with cancelled and shares only answered and deadline with the wait gate (ER-1, seams). D2 no longer settles messages: rule 10 stands, the call is FIX-2070's, and FIX-2129 pins today's behaviour with a test. Retired words replaced (requests, the session's key, onTaskSettled), prompt added to the teams table, the FIX-2056 PRs corrected, map entries no longer tied to FIX-2071. Rescoping FIX-2129's Linear text goes to that issue.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants