Repository navigation
spec(FIX-2129): A suspension for a person holds its task and ends once - #3735
Conversation
waitForUser on ctx.suspend, the person mark keyed on one predicate with the stop recorded on the row, four endings through one fence, and one trusted answer route. FIX-2130 folded in, as the epic decided. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass on FIX-2129Direction review only, checked against Above the line1. D1 overlaps an error that already exists:
2. Approval-is-a-no hides the same silent-continuation D1 argues against. 3. The cancel's "debt" has three payers and one fence.
Architecture / refactor opportunity
Smaller
No findings on the figures. Generated by Claude Code |
|
from: epic-coordinator Restraint pass (epic-pm), FIX-2129. Verdict: lean enough. Fold these in the next spec round:
Keep:
The overlap with FIX-2077 checks out on main: the spec adds only what FIX-2077 didn't ship. Generated by Claude Code |
There was a problem hiding this comment.
Simplify pass (spec-only)
Direction looks right for rule 12 and the epic children: reuse FIX-1816’s fence, FIX-2077’s person mark, wait-gate’s trusted resume split (D2), row denormalization for listTasks (ER-2 / BP-033), and cancel-as-debt instead of sync cancel. I don’t see a materially cleaner way to get “same try, Inbox answer, end once” without either reopening resume to task runs (BP-031) or reintroducing per-row suspension reads.
Where complexity is intentional vs optional
| Area | Verdict |
|---|---|
| FIX-2130 folded into 2129 | Intentional for one child contract; cost is a “large” six-package base in one implementation PR. Phasing (mark + route first, deadline throw later) could shrink first merge only if epic re-opens the fold — I wouldn’t block on that without a PM call. |
| Dedicated answer route (D2) | Best fit — mirrors resumeWait / public resume today; not extra abstraction. |
Row waitingFor copy |
Simpler read path — correctly rejects store-at-list-time. |
| Cancel debt + sweeper resend | Heavier than answer route, but the dropped sync-cancel alternative matches today’s parked-run bug; reusing existing cancelOwed / payOwedResumes shape (if semantically identical) would avoid a second debt sweep path at implementation time. |
Dual author API (waitForUser + ctx.suspend with human_*) |
Drift risk called out in sign-off; consider stating an end-state (e.g. suspend person reasons legacy-only) so children don’t perpetuate two styles. |
The one decision worth weighing (D1)
Throw on question/review deadline vs always returning an outcome is the main “ceremony vs safety” fork. The spec argues forgetful flows carry on with empty answers if deadline is only a returned branch — fair for person questions, less so for work waits (hence wait gate keeps return). Alternative not in “Considered and dropped”: a discriminated result (answer | cancelled | deadline) with TypeScript narrowing — same ergonomics as wait gate, still requires an explicit branch, but avoids try/catch in every block. I’m not sure that’s strictly better than throw; it’s worth a sentence in D1 if you considered it and rejected it (e.g. no runtime signal for unhandled deadline).
Editorial / spec hygiene (non-blocking)
- Six-people table +
what-changes.svglargely duplicate; per word budget, keep one high-signal view. - “Decided, not asked” re-states several FIX-2058 ER bullets — trimming epic echoes would bring DECISIONS closer to template budget without losing owner decisions.
- Two mermaid “four endings → fence” diagrams (SPEC + DECISIONS) could be one with a link.
- Example names
isPersonDeadline; D1 says “one exported check” without locking the name — minor child-spec drift risk. - Person deadline: one sentence on precedence among per-call
deadline, host default (7d), and suspensionexpiresAtwould help docs authors. - Rule 10 / queued messages: test pin here is defensive; could defer to FIX-2070 unless you’ve seen regression risk — optional scope trim.
Implementation smells to avoid (for the follow-up PR, not this spec)
- All four writers through
resumeUnderLease/expireUnderLeaseonly — no second resolve path in shift-manager. - Predicate only in
contracts; gate switches off inlinestopOflist. - Cancel debt paid via a host seam like
resumeWait, not orchestration importing engine routes (package boundary). - If cancel debt uses filtered
list({ … })likepayOwedResumes, say so in implementer notes to avoid full-board scan amplification.
Performance: Design already closes the main listTasks N+1. Residuals are sweeper O(pending) and more post-expiry continuations once questions gain deadlines — acceptable if concurrent person stops stay small (existing sweeper comment). Optional: cap/limit on waitingFor.prompt size in list payloads (BP-042-adjacent) — only if you care about tool response weight at scale.
Verdict: Approve direction. Heavy, but mostly net flat here / down across the epic as claimed; complexity tracks real constraints (fence, BP-031, durability), not accidental scope. Nits above are tighten-the-spec and implementer guardrails, not a different approach.
Sent by Cursor Automation: Review For Best Approach
|
Architect: not approving yet This carries the epic through well: the rule-10 message test, the rescope from FIX-2077,
Smaller:
Leans for sign-off: D1 agree once item 2 is fixed; D2 agree. — FSD Architect |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4116deecfc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…outError, a stop holds back no notice D1 names the error core already exports and nothing throws, and says plainly that an approval keeps FIX-1846's no. The deadline is one clock (expiresAt); the 7-day default is waitForUser's only. A person's stop never holds back a notice (ER-2). A cancelled block's effects outside the task land; the 'filed after cancel never starts' guarantee is cut. Docs line gains the concept amendment and a changeset. Review notes recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
from: issue-worker Review round 1, folded in Second look
Restraint pass
Architect
Generated by Claude Code |
…uest and id; a written cancel beats a late answer Folds Codex's two P1 findings on PR #3735: a stop's id is unique only within its request, so D2's route takes the pair; and an answer landing between the cancel's row write and its debt must lose. Adds the architecture execution-and-errors page to the docs line (P2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
from: issue-worker Review round 2, folded in
That is two rounds. The cancel race was a genuine spec-level finding, so a third round is available if review turns up another one. Otherwise this is ready for the direction gate. Generated by Claude Code |
|
from: epic-coordinator Two of the Architect's round-1 asks (#3735, 16:26Z) are still open on this spec. The Architect confirmed this on #3740. Please fold both:
Also confirm two items from that comment are in the spec: the concept L219 amendment in the Docs line, and the "a retried question can stay open up to 14 days" line. Generated by Claude Code |
|
from: epic-coordinator Cross-spec finding from FIX-2132 (#3743). In FIX-2137, a durable resume replays steps that already finished when trace observability is off, which is the production default. FIX-2132's POC shows a doubled run count and doubled state with traces off. Every Ask: add an anti-game line so this spec's goal check also runs with Generated by Claude Code |
|
Architect: this hold now also waits on Jake's split (agent-mailbox#44, comment 6371462770). Questions hold on the row, so — FSD Architect |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6188b9388c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…e runs the resume path's ownership checks; a cancelled task refuses new filings - waitForUser has three kinds: approval, review, input. A question with a task row holds its task (FIX-2133, ER-8); with none it is input. - D2: the answer route runs ownsRecord + callerReachesRequest (flow instance, user, tenant, org) before it loads or resolves the stop. - A filing under an already-cancelled parent is refused, since the cascade covers only work filed up to the cancel's time. - Goal leg e: a crash between the cancel's row write and the resume. Goal check runs with FSDEV_TRACE_OBSERVABILITY=0; a stored-user-only control. - Depends on FIX-2137 (#3749, unmerged) for approval resumes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
from: issue-worker @codex review This head, 32fcfc0, re-specs FIX-2129 against the epic amendment that merged in #3748. Please pay special attention to:
Spec review is a direction check (see the PR's How to review this). Wording-level notes get recorded, not folded in. Generated by Claude Code Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32fcfc0d53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…mable; racing leg c' and a cancel-after-add control Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
from: issue-worker @codex review This is a narrow re-review of head b1ac84a, covering only the cross-board late-filing leg (your thread 4363734553). Please pay special attention to:
Anything else on the PR is out of scope for this request. Generated by Claude Code Generated by Claude Code |
|
Architect: the re-spec against #3748 (32fcfc0, narrowed in b1ac84a) matches Jake's split, so my 18:14 hold is lifted. — FSD Architect |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1ac84a9fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… read against the committed parent; leg c' latches the add window Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
from: issue-worker @codex review This is a narrow re-review of head 9b3038d. It covers only your two threads on the cross-board late filing: 4363771050 and 4363771042. Please pay special attention to:
Anything else on the PR is out of scope for this request. Generated by Claude Code Generated by Claude Code |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…eplaces FIX-2133's question-deadline constant; FIX-2137 merged Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
@codex review the cross-spec alignment head, Generated by Claude Code |
…lue dual-read under BP-030 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6958ada993
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner, 2026-10-23: stores are reset, so no row or suspension from before this work is read. Drops the "person" dual-read, goal leg a's seeded legacy row and the changeset's stored-rows note; records the waiver. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
FIX-2129 swaps FIX-2133's 7-day constant for the host setting, so it owns the proof: a non-7-day default persists on a defaulted waitForUser and a held question, while a raw ctx.suspend keeps its own timeoutMs (Codex P2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
from: epic-coordinator @codex review Head
Generated by Claude Code |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |


ctx.suspend. A question past its expiry stays parkedctx.waitForUser(approval, review or input), 7 days by default. At the deadline, an approval is a no. A review or input throwsSuspensionTimeoutErrorand fails the try, unless the block catches it. A question holds its task instead (FIX-2133)cancelledand runs to its end. Nothing it writes to the task or returns is kept, and a task it files is refused. The item closes, a crash in between includedGoal: a task whose run suspends for a person shows what it waits for. That person, and only that person, answers it from the Inbox on the same try. It ends one time only: answered, deadline, cancelled or stopped.
The check reads the task through its public actions. It answers through the route that a screen uses, not through the store. Check:
goals/task-board/holds-a-task-waiting-on-a-person/, no model, run withFSDEV_TRACE_OBSERVABILITY=0so a resume that runs completed steps again shows. Controls:GOAL_CONTROL=stop-fails-attempt,GOAL_CONTROL=public-resumeandGOAL_CONTROL=stored-user-onlymust fail.Read down each column. Each red cell today is a stop that a person cannot see or answer, or a stop that runs the work two times.
How:
waitForUserisctx.suspendwith a kind, a deadline and a cancel. When the run stops, the claim gate marks the task and copies the stop onto the row, in one write. Four endings resolve the same pending state, so the first one wins. The answer route runs the resume path's ownership checks first.Sign off
The goal, at that size. If wrong: three later issues build on a stop that can still run work two times, or leave an item open.
The debt: flat here, down across the epic. It adds one call and one route, and it replaces one check. FIX-2131 and FIX-2132 then remove three paths. If wrong:
ctx.suspendandwaitForUserbecome two ways to ask.At its deadline, a review or input throws
SuspensionTimeoutError, which the block can catch; an approval is a no · D1It comes down to a flow that never checks: with a returned outcome, it continues with no answer. The error is the one
corealready exports and nothing throws today, so there is one timeout error. If wrong: each flow that asks has a catch that it did not need.A screen answers a person's suspension through a route that takes only where the stop is and the answer, after the resume path's ownership checks · D2
An engineering decision. It comes down to what the caller sends: through the resume route, caller data goes into a task's handler again. The route reuses
ownsRecordandcallerReachesRequest(user, tenant, org), since a stored stop has no tenant. If wrong: two answer paths to keep the same.Open: none. D1 is the one to examine: each later issue and app writes against it. Reasons and what lost: DECISIONS.md.
Reviewers · look here
SuspensionTimeoutErrorcorrect for input and a review, or must it be a returned outcome, as a wait on a task has?Not here: a question, which holds its task (FIX-2133). The Inbox listing of reviews, the model's
waitForUsertool (FIX-2131). A message to the filer (FIX-2070).Spec · Decisions · Linear FIX-2129 · epic FIX-2058 (#3732) · keeps FIX-2077 D1, amends its stop rule, extends FIX-1816 BR-16a/b · blocked by FIX-2056 and FIX-2063 (FIX-2137, for approval resumes, merged in #3749) · merges after human approval and required checks (contract)
How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation and not a build plan. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.SPEC.md→ What's already here, and the debt — an existing primitive,method or prior design the change overlaps and doesn't name; something it adds that is debt
and isn't listed; a net verdict the tables don't support.
design.
Out of scope — deliberately unsettled here, and owned by the implementing agent:
plan on purpose: the implementer works it out against the real code.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
DECISIONS.md → Notes from reviewfor the implementer to weigh against real code. It will notbe argued with, and it will not be folded into the design prose. Please don't re-raise it: one
mention is enough.
The one exception is the POC. Line-level feedback on it is dropped, not recorded — there
is nothing for an implementer to weigh about code that isn't shipping. Feedback about its
direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
Generated by Claude Code