Repository navigation
spec(FIX-2063): Durable execution by default on file-backed hosts (dev, local runs, self-hosted) - #3734
Conversation
Retained spec set: SPEC.md, DECISIONS.md and three figures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
second-look: PR #3734 (FIX-2063 spec)Verdict: Appropriately scoped. The spec removes more than it adds, and I found no cut that passes the calibration gate.
Considered & deemed justified
Architecture lens (improve-codebase-architecture), only where this PR is the openingOne opportunity, not a finding: the no-config dev router is a second place that composes durability. Two ways to close it, both for the implementer to weigh against the real code:
What would make me drop this: if A smaller adjacent note: after this change there are two independent refusals at the stop. One is "no provider" ( Read-only review. No code edited. Per the PR's "How to review this", these are notes for the implementer rather than requests to change the design. Generated by Claude Code |
There was a problem hiding this comment.
Verdict
Approve the direction. For a spec-only PR, the implementation story is about as small as this epic kill line allows: flip createFlowState’s default, point no-config fsdev run at the same SQLite file dev/chat already use, and wire the discovery fsdev dev router with the same createCheckpointDurabilityProvider pattern the engine already uses. BullMQ, a new suspension store, per-CLI sweepers, and adapter-level “this store persists” markers are all explicitly out — that restraint is the right simplification.
What feels heavy here is mostly document surface area, not product architecture. The same fork (D1–D3) is told in the six-people table, what-changes.svg, two SPEC mermaids, DECISIONS tables, decision SVGs, and the sign-off block. That matches sibling epic specs (e.g. FIX-2077) and helps gates, but it fights the footer line “small · epic kill line.” If you trim one pass before merge, I’d pick: keep goal + signal table + one host matrix figure + DECISIONS; drop or shorten the redundant mermaid in “Where a stop lives…”, collapse sign-off to decision IDs + stakes (details stay in DECISIONS), and fix the broken goal anchor in sign-off.
Did the approach go too far?
On runtime design: no. D3 (router-only sweeper) avoids the scary alternative of sweeping inside fsdev run, which would redrive unrelated work. D1 is the minimum store convergence once a run’s stop must be answerable in fsdev dev — the rejected “dev reads run’s filesystem store” path was correctly dropped for load (FIX-406). D2 is a blunt default flip, but the rejected “marker on every adapter” is genuinely more moving parts for third-party store authors.
On product tradeoffs: D1 is the one to weigh at sign-off (already called out). Moving no-config fsdev run off JSON/filesystem is real friction for agents that grep .fsdev/data; the spec’s escape hatch is the headless --store filesystem proposal, still unfiled in debt. I’m not sure that should block spec approval, but if D1 ships without an opt-back in the same implementation slice, you may hear about it — bundling Capability B from the headless doc (or a one-line “ships with implementation” commitment) would simplify the later argument.
Simpler approaches considered
| Alternative | Why it doesn’t replace this spec |
|---|---|
durable: true default only |
Leaves no-config fsdev run on a store nothing answers; deadlines still don’t fire without a router sweeper. |
| D1 only, no global default | Doesn’t meet “durable by default on self-hosted” or retire scattered opt-ins. |
| BullMQ / queue as durability | Wrong layer; spec correctly keeps dispatch separate from suspension storage. |
Sweeper on every getRuntime() |
More complex and unsafe for one-shot CLI (fires others’ deadlines). |
Implementation / docs nits (for the implementer, not gate-blocking)
- D2’s “provider costs nothing” is directionally right (checkpoints remain action-gated), but docs should distinguish host
durablevsaction.durableso operators don’t assume zero store I/O after the default flip. - D1 +
better-sqlite3means no-configfsdev runmay block under contention with a runningdevserver; WAL/busy timeout is enough to mention in CLI docs, not a spec rewrite. - Epic review note on correlated expiry bursts on sweep ticks: fine to stay in DECISIONS “Notes from review”; optional one line in implementation PR if leg (c) gets hammered in goals.
Skipped (optional, not insisting)
- Shared SVG style fragment / shorter figure alt text — maintainability only.
- Moving goal
GOAL_CONTROL/ anti-game detail entirely into the goal README — scope placement preference.
No direction forks left open that I’d block on. Nice work keeping checkpoint durability and package boundaries intact.
Sent by Cursor Automation: Review For Best Approach
|
|
||
| ## Sign off | ||
|
|
||
| **[The goal](#the-goal-and-how-well-know-its-met), at that size:** held, answered in one place |
There was a problem hiding this comment.
This anchor looks broken: heading is “how we'll know it's met” but the link slug uses how-well-know. Worth fixing before merge so sign-off navigation works in review.
There was a problem hiding this comment.
Dropped: the anchor is correct. GitHub's slug strips the apostrophe, so "how we'll know it's met" becomes how-well-know-its-met. No change.
Generated by Claude Code
| *Configuration → Runtime*, *API → CLI* for `fsdev run`'s store and its waiting report, the data | ||
| line in *DevTool → Setup*, and the engine README. No new page. FIX-2131 owns the stop's story. | ||
|
|
||
| ## Where a stop lives and who answers it |
There was a problem hiding this comment.
Taken in fa26810: the "Where a stop lives" mermaid is gone. It restated D3, and the host figure already carries it.
Generated by Claude Code
| **[The debt](#whats-already-here-and-the-debt), net down:** the opt-ins go; nothing kept for | ||
| old callers. If wrong: a host somewhere relied on durability being off. | ||
|
|
||
| 1. **[D1](DECISIONS.md#d1) · A no-config `fsdev run` uses the database `fsdev dev` uses.** |
There was a problem hiding this comment.
Sign-off item 1 re-litigates D1’s table + figure + “What would change my mind.” For readability, consider IDs + one-line stake only here (“If wrong: agents lose direct JSON reads”) and drop the repeated “If wrong” paragraphs for D2/D3 — same content is in DECISIONS.
There was a problem hiding this comment.
Dropped. The sign-off keeps one stake line per decision so the gate can be read without opening DECISIONS.md. Its D1/D2 lines were updated in fa26810 for the round's folds.
Generated by Claude Code
| | Is it the right goal? | | | ||
| |---|---| | ||
| | **The real need** | *"Durable execution is on by default wherever stores persist: development, local runs and self-hosted servers"* (the issue). The epic: no park survives as a fallback, so the default carries every stop ([ER-6](../../epics/FIX-2058/DECISIONS.md#who-owns-what)) | | ||
| | **Smaller, and rejected** | "`durable` defaults to true." Met while `fsdev run`'s stop sits in a store nothing answers, and while no sweeper runs, so deadlines never fire | |
There was a problem hiding this comment.
“Smaller, and rejected” (durable default only) is easy to confuse with D2’s rejected “adapter declares persist.” A cross-link to D2’s rejected branch would help readers see why this spec needs D1+D3, not just the default flip.
There was a problem hiding this comment.
Fixed inline in fa26810: the "Smaller, and rejected" row now links to D2 and says it is not D2's rejected branch.
Generated by Claude Code
| |---|---| | ||
| | **Removes** | The per-host `durable: true` opt-ins, Shift Manager's conditional one included · host refusals that guard on it, such as the Error Reporter's · the docs' nonexistent `durabilityProvider` option | | ||
| | **Adds** | No shim. A serverless host's stop is held, but its deadline fires only when an invocation runs. Permanent by design: serverless isn't a target | | ||
| | **Leaves** | The headless proposal's `--store` override (`docs/internal/fsdev-headless-verification-capabilities-design.md`), unfiled: the way back to a run's JSON files | |
There was a problem hiding this comment.
D1’s main product risk is losing grep-friendly JSON for no-config runs. Debt already points at the headless --store filesystem override but leaves it unfiled. Suggestion (uncertain): either commit to shipping that opt-back in the implementation PR that does D1, or elevate it to a tracked follow-up in the spec so D1 isn’t a silent breaking change for agent workflows.
There was a problem hiding this comment.
Folded in fa26810, together with Codex's --capture finding. D1 no longer names --capture as a replacement. It accepts the loss of the JSON files explicitly: state is read from the SQLite file or through fsdev dev's routes. The --store filesystem opt-back remains D1's "what would change my mind", and the sign-off line states the loss plainly. Whether to ship it anyway is the human gate's call on D1.
Generated by Claude Code
| | | | | ||
| |---|---| | ||
| | **Instead of** | Turning it on only where the active store adapter declares that it persists | | ||
| | **Because** | One rule an app can predict, with nothing an adapter must declare or can forget. In-memory durability lasts the process, so tests behave like production. The provider costs nothing for an action that never stops or checkpoints (tenet 2: refine the default, don't add a second way) | |
There was a problem hiding this comment.
Nuance for implementer-facing docs: host-level durable: true installs the provider path, but checkpoint writes remain gated on action/sequencer durable and stops. The line is fine as a direction call; implementation docs should spell that distinction so D2 isn’t read as “every action now checkpoints.”
There was a problem hiding this comment.
Recorded verbatim in DECISIONS.md -> Notes from review for the implementer. D2's Locks in now also prices the cost of the default (sequencer checkpoints, crash-resume, sweeper ticks).
Generated by Claude Code
|
|
||
| D1 and D2 are the sign-off surface; D3 is an engineering call the epic's review asked for by name. | ||
|
|
||
| ## The tree |
There was a problem hiding this comment.
The decision tree mermaid duplicates each D section’s “Instead of” row. Fine for a gate artifact; if you want a shorter spec, the tree is the first thing I’d cut (sections + figures already show rejected paths).
There was a problem hiding this comment.
Dropped. The tree is the gate's one-glance view. Its D1/D2 nodes were updated in fa26810.
Generated by Claude Code
| |---|---| | ||
| | A `fsdev resume` command | A second place to answer a stop, against the epic's one answer route ([ER-7](../../epics/FIX-2058/DECISIONS.md#who-owns-what)) | | ||
| | `fsdev dev` reading `fsdev run`'s files | The filesystem store can't hold the dev server's load; that is why `fsdev dev` left it | | ||
| | A queue (BullMQ) as the durable layer | A dispatch queue is not a suspension store; the epic's review kept this on checkpoint durability | |
There was a problem hiding this comment.
Good explicit rejection of BullMQ as the durable layer — keeps @flow-state-dev/bullmq in the dispatch lane and avoids a second persistence subsystem. This is the main “use established packages / don’t reinvent” win in the spec.
There was a problem hiding this comment.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19e03bc08f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| this, as the opt-back. | ||
|
|
||
| <a name="d2"></a> | ||
| ## D2 · Durable execution is on by default for every `createFlowState` host; `durable: false` turns it off |
There was a problem hiding this comment.
Keep ephemeral store profiles fail-closed
When an existing app uses inMemoryStores() and omits durable, this all-host default accepts ctx.suspend() even though its suspension disappears on restart. That contradicts both the spec's across-restart goal and the parent epic's locked ER-6 rule that durability defaults on wherever stores persist while hosts without it refuse loudly; current persistence docs also support in-memory stores for development and demos, not only tests. Restrict automatic enablement to persistence-capable profiles or otherwise keep ephemeral profiles opt-in/fail-closed.
AGENTS.md reference: AGENTS.md:L52-L52
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Folded in fa26810. D2 now reads: durable by default wherever stores persist. The in-memory adapter is the one that says it does not persist, and there a stop refuses loudly unless durable: true is set (that is how tests opt in). This matches ER-6 as written, so the epic needs no amendment. The old rejected branch (a marker on every adapter) moved to Considered and dropped. The D2 figure was redrawn and renamed d2-where-stores-persist.svg.
Generated by Claude Code
| | Someone who… | Today | After | | ||
| |---|---|---| | ||
| | **runs `fsdev dev` with no config** | A flow that stops for a person fails: *"ctx.suspend() requires a DurabilityProvider"* | It stops; the DevTool answers it, after a restart too, and its deadline fires | | ||
| | **runs `fsdev run` with no config** | The same failure | The run ends saying it waits, and to answer it in `fsdev dev`, which reads the same local database ([D1](DECISIONS.md#d1)) | |
There was a problem hiding this comment.
Align CLI and DevTool identities before sharing their store
In the stated no-config scenario, fsdev run stamps the request with its default user cli-user (packages/cli/src/principal.ts:23-24,133-139), while the DevTool defaults to devuser (packages/devtool/src/react/config.ts:21-22,55-62). Session listing is filtered by that user (packages/engine/src/routes/session-routes.ts:209-218), so merely moving both commands onto the same SQLite file does not make the run's stop visible or answerable in the default DevTool. Include an identity handoff/shared default in the design and exercise the actual default UI path in the goal check.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Folded in fa26810. Confirmed: cli-user (principal.ts) vs devuser (devtool config.ts), and the session listing is scoped by user. D1 now covers one shared local default user for both commands. Leg b's signal requires the stop to show in the DevTool's default session listing under its default user.
Generated by Claude Code
| | **runs `fsdev run` with no config** | The same failure | The run ends saying it waits, and to answer it in `fsdev dev`, which reads the same local database ([D1](DECISIONS.md#d1)) | | ||
| | **self-hosts on SQLite or Postgres and never set `durable`** | Stops are refused until they find `durable: true` | Stops work; `durable: false` turns it off ([D2](DECISIONS.md#d2)) | | ||
| | **turned durability off, or built a router with no provider** | A generic error: *"Configure one in your server options"* | Refused at the stop, by an error naming the setting to change | | ||
| | **reads a no-config `fsdev run`'s state as JSON under `.fsdev/data`** | Works | Reads it in the DevTool, the SQLite file or `--capture`. The price of D1 | |
There was a problem hiding this comment.
Do not present capture as a replacement for store-state JSON
For the user named in this row, --capture cannot replace the JSON files: its payload contains only { command, events, result } (packages/cli/src/commands/run.ts:167-180,538-550), not session or resource state. The repository's headless-verification design explicitly records that resource outcomes require a store read or read action (docs/internal/fsdev-headless-verification-capabilities-design.md:18-22,48-52). D1 therefore removes the machine-readable state path without the claimed replacement; ship the filesystem/read-back capability with D1 or explicitly accept the loss rather than naming capture as mitigation.
AGENTS.md reference: AGENTS.md:L181-L183
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Folded in fa26810. Confirmed: CapturePayload is { command, events, result }. D1 and the people table no longer present --capture as a state replacement, and the loss is accepted explicitly (see the reply on line 115).
Generated by Claude Code
| | How we verify | | | ||
| |---|---| | ||
| | **Goal check** | `goals/durable-by-default/a-local-stop-is-held-and-answered/` · no model · run by the implementer at completion · verdict in the implementation PR | | ||
| | **Signal** | a: `fsdev run` ends without an error, printing the stop's id and the answer hint; the request is `suspended`. b: after `fsdev dev` starts and restarts, the stop is listed; one approve completes that request id, once. c: a stop whose deadline passed while nothing ran is `expired` after one sweep. d: under `durable: false` the request fails at the stop, the error names the setting, and nothing is stored | |
There was a problem hiding this comment.
Narrow “nothing is stored” to durability artifacts
With durable: false, ctx.suspend() throws at the stop, but the ordinary request/session lifecycle has already persisted records and runAction records the resulting request as failed (packages/engine/src/execution/runAction.ts:3035-3046). If the goal check interprets “nothing is stored” literally, implementation must erase normal failure history even though that lifecycle is declared unchanged. Specify that no suspension/checkpoint is stored, and state whether the failed request should remain.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed inline in fa26810: leg d now says no suspension or checkpoint is stored, and the request stays recorded as failed, as today.
Generated by Claude Code
| | | | | ||
| |---|---| | ||
| | **Instead of** | Turning it on only where the active store adapter declares that it persists | | ||
| | **Because** | One rule an app can predict, with nothing an adapter must declare or can forget. In-memory durability lasts the process, so tests behave like production. The provider costs nothing for an action that never stops or checkpoints (tenet 2: refine the default, don't add a second way) | |
There was a problem hiding this comment.
Account for the default sweeper's idle-store cost
Even when no action stops or checkpoints, adding a provider makes every router construct a durability sweeper (packages/engine/src/routes/createFlowApiRouter.ts:543-560); it arms periodic ticks that acquire a lease and scan durability state. D2 therefore adds recurring store I/O to every defaulted host, contrary to this zero-cost rationale. Price and accept that host-level cost in the decision, or change when the sweeper is activated.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Folded in fa26810. Confirmed: createFlowApiRouter builds the durability sweeper whenever a provider exists. D2's Locks in drops "costs nothing" and prices the sweeper's ticks with the sequencer checkpoints and crash-resume. A changeset carries the migration note.
Generated by Claude Code
|
from: epic-coordinator Restraint pass (epic-pm), FIX-2063. Verdict: lean enough. Fold these two narrowings in the next spec round:
Optional: fixing the docs' nonexistent Keep: D2's flip with Generated by Claude Code |
|
Architect: not approving yet D1 and D3 hold up. D2 is the right shape, but four things need fixing first:
Smaller:
Leans for sign-off: D1 agree, D2 agree once 1–3 are fixed, D3 agree with the exception recorded. — FSD Architect |
D2 narrows to wherever stores persist (in-memory refuses loudly, per epic ER-6) and prices the default: sequencer checkpoints, crash-resume, sweeper ticks, with a changeset migration note. D1 adds the shared local user the DevTool needs to list a run's stop, and stops naming --capture as a state replacement. One engine rule owns the default for all three hosts. D3 records the wait-rule exception; leg c narrowed to a running fsdev dev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
Spec review round 1, folded in Folded (these change the approach):
Taken from the smaller items: the list of hosts covered (in the goal table), exit 0 with the stop's id in Recorded verbatim in DECISIONS.md -> Notes from review: the refusal names its rule (also in the contract), parallel wording for the two refusals, host vs action Open: none. D1 is still the item to weigh at the gate. Generated by Claude Code |
|
Architect: round-1 fold checks out (
No new overlap with #3735 (FIX-2129 owns the waiting row and the deadline error). From my side nothing is left open. D1 is the call for the gate. — FSD Architect |
|
from: epic-coordinator Cross-spec finding from FIX-2132 (#3743). FIX-2137: when trace observability is off, which is the production default, a durable resume runs steps that already finished again. D2 turns durable execution on by default, crash-resume included, so apps that never opted in would see side effects run twice. Ask: add an anti-game line so the goal check also runs with Generated by Claude Code |
|
Architect: agree with the FIX-2137 finding; make it a hard ordering, not a footnote. D2's goal is "durable by default where stores persist, crash-resume included." With trace observability off (the production default), a resume re-runs finished steps, so flipping the default before FIX-2137 lands would turn an opt-in bug into a default one for every app. Please:
Where FIX-2137 sits in the epic stays with the owner, as does D1 — FSD Architect |
D2's default flip now ships after FIX-2137: a resume reruns finished steps when trace observability is off (production's default), so crash-resume by default would turn that bug on for every app. The goal check counts the step before the stop and runs legs a and b again with FSDEV_TRACE_OBSERVABILITY=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
Spec review round 2, folded in Folded:
Recorded verbatim in DECISIONS.md -> Notes from review, round 2. Linear: FIX-2137 now blocks FIX-2063. Still with the owner: where FIX-2137 sits in the epic, and D1 ( Generated by Claude Code |
|
Architect: round-2 fold checks out (
One wording fix: the Sign off ordering line says where FIX-2137 sits in the epic is "the coordinator's call". Your summary and my ask both say it's the owner's call. Please make the spec say owner, so it doesn't read as delegated. No new overlap with #3743 or #3735. D1 — FSD Architect |
Wording fix from the architect's round-2 check: the Sign off ordering line now says FIX-2137's placement is the owner's call, matching the review summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
from: epic-coordinator Two owner decisions (Jake, in the coordinator session, 2026-10-23). Please fold both into the spec:
After the fold, the spec comes back to the owner's direction gate. Generated by Claude Code |
Owner decisions (Jake, 2026-10-23, #3734 comment 6371586293): - D1 is decided: SQLite is the durable default for no-config fsdev dev and fsdev run, and a --store filesystem flag ships as the opt-back, its limit documented (single-process, so run and dev can't share it at once; lease takeover is not atomic). Moves the --store override from the debt's Leaves to Adds. - FIX-2137 joins epic FIX-2058 as a direct-route bug, parented under it, and stays a hard blocker of D2's default flip. Replaces the "owner's call" placement wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdxnv28JumHyq2za2ybqz6
|
@codex review: re-request at
Generated by Claude Code |


fsdev devwith no configfsdev runwith no configfsdev dev. Both commands use one local database and one local userdurabledurable: truedurable: falseturns durability offfsdev dev's routes, or passes--store filesystemto keep the JSON files (single-process)Goal: on a local or self-hosted machine with no durability configuration, a flow that stops for a person stays held until the person answers or its deadline passes. This continues across a restart. The person answers it in one place, whichever command started it.
The check reads the CLI output and the records from the public routes. Check:
goals/durable-by-default/a-local-stop-is-held-and-answered/, no model. Control: today'smainmust fail legs a and c.Read each row from left to right: who holds a stop today, and who holds it after.
How:
durabledefaults totruewherever stores persist, through one engine rule thatcreateFlowState, the no-config dev router and the no-configfsdev runall use. The in-memory adapter says it does not persist, so a stop there refuses loudly. A no-configfsdev runwrites to the database thatfsdev devreads, as the same local user. The router's sweeper fires the deadlines.Sign off
The goal, at that size. If wrong: the next four issues remove the parks, and local hosts then lose stops.
The debt: net down. The per-host
durable: trueopt-ins and the refusals that guard on them go. Nothing stays for old callers. If wrong: a host somewhere needs durability off.Decided by the owner (2026-10-23): a no-config
fsdev runuses the database and the user offsdev dev, with--store filesystemas the opt-back · D1It comes down to who answers the stop of a run: on separate files, no local host answers it. SQLite is the default.
--store filesystemkeeps the JSON files for anyone who wants them, with its limit documented: single-process, sofsdev runandfsdev devcan't share it at the same time, and its lease takeover is not atomic.Durable by default wherever stores persist;
durable: falseturns it off · D2<img src="
https://raw.githubusercontent.com/fixpoint-labs/flow-state-dev/fa2681028b87e46406cb94e23dc4d2b7360d65d5/specs/issues/FIX-2063/figures/d2-where-stores-persist.svg"width="940" alt="D2: on wherever stores persist, chosen, beside on everywhere including in-memory stores. Decides it: the epic rule, where a stop held in memory is lost silently. Price: an upgrade checkpoints sequencers and resumes crashed requests for apps that never set durable" />It comes down to the epic's rule: a stop is held only where it survives the process. If wrong: an app that upgrades checkpoints every sequencer step and resumes crashed requests it used to rerun. A changeset carries the migration note. Ordering: the flip waits on FIX-2137 (a resume reruns finished steps with traces off), now a direct-route bug in epic FIX-2058 and a hard blocker of the flip.
Open: none. D1 and FIX-2137's placement are decided by the owner. D2 is the one to weigh, because an upgrade turns durability on for apps that never set it. D3, an engineering call, is in the block below. DECISIONS.md has the reasons and the options that lost.
Reviewers · look here
durable?Not here: what a stop is and how the Inbox answers it (FIX-2129, FIX-2131). Serverless hosts.
Spec · Decisions · Linear FIX-2063 · epic FIX-2058 (#3732) · supersedes FIX-406 6A in part · merges after human approval and required checks, per Merging and amending a spec
Engineering calls — decided, not asked
fsdev runholds the stop, says where to answer it, and says its deadline fires only while a server runs on the store. A sweeper in a one-shot command would fire the due work of other requests and then stop it when the command exits. Recorded exception: waits on a task still refuse infsdev run(FIX-1816).runActiontake a provider only when they get one.How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation and not a build plan. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.SPEC.md→ What's already here, and the debt — an existing primitive,method or prior design the change overlaps and doesn't name; something it adds that is debt
and isn't listed; a net verdict the tables don't support.
design.
Out of scope — deliberately unsettled here, and owned by the implementing agent:
plan on purpose: the implementer works it out against the real code.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
DECISIONS.md → Notes from reviewfor the implementer to weigh against real code. It will notbe argued with, and it will not be folded into the design prose. Please don't re-raise it: one
mention is enough.
The one exception is the POC. Line-level feedback on it is dropped, not recorded — there
is nothing for an implementer to weigh about code that isn't shipping. Feedback about its
direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
Generated by Claude Code