Repository navigation
feat(claude-code-style): dismiss a failed thread so it stops waiting on you (FIX-2579) - #4820
Conversation
…on you A failed thread sat under Waiting on you with only Retry, so a failure you'd already read stayed in your list and the session's count forever. Its view now offers Dismiss: the failed attempt moves to Resolved and the session stops counting it. Kept per task attempt in your user state, like pins (a new dismissals flow over one shared user-marks schema), so a retry that fails again waits on you again. Part of FIX-2579. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiFNPRahqdbL4B28RkR
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture reviewOverall: the approach is sound. Dismissal as user state keyed by task+attempt is the lean shape, and it keeps the board's task status untouched. The tests encode the intent: a retry that fails again waits again, and an in-progress task is never resolved by a dismissal. The items below are ordered by importance. 1. Read the dismissals once per relist, not once per session (efficiency, worth fixing here)
2. A failed dismissals read blanks every session count (resilience)
3. Two flows sharing one schema is a smell (architecture, optional)
4. Key stability across recreate (correctness, low)
5. Smaller items
No blockers. I'd fix 1 and 2 in this PR, and decide on 3 before merge, since it is cheapest now. Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c777aede78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ounded dismiss Review on #4820: each session row read the dismissals itself, and any user-state notice (a pin too) re-read every row. The sessions list now reads them once per pass and counts the rows again only when they changed. dismiss returns its key alone (BP-042) and keeps one key per task, so the list never grows past one entry per task. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiFNPRahqdbL4B28RkR
Review on #4820: a literal patch of the dismissed list can lose one of two dismissals made at once. The updater form recomputes against the stored list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiFNPRahqdbL4B28RkR
Co-authored-by: jhoffner <579835+jhoffner@users.noreply.github.com>
…dapter main's task-time test renders ThreadsBoard with an adapter that only had watchPins; the board now also watches dismissals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiFNPRahqdbL4B28RkR
Co-authored-by: jhoffner <579835+jhoffner@users.noreply.github.com>
|
I'm marking not ready because this one and #4713 both rely on using flows just as a form of CRUD controller and I want to pause and think through how we can better solve this. It feels like a workaround. Some options we could consider:
|
Co-authored-by: jhoffner <579835+jhoffner@users.noreply.github.com>
Code Review ✅ Approved 2 closed / 2 findings🟡 Medium risk · Persisting per-attempt dismissals moves failed threads out of Waiting on you, so a mistaken dismissal could hide work needing attention. Adds a Dismiss action to failed threads so they move to Resolved and stop counting toward "waiting on you," with dismissals stored in a new user-state flow sharing one schema with pins. Resolved this session: dismissals are now re-read once per session instead of on every user-state notice, and ✅ 2 closed✅ Performance: Dismissals are re-read once per session, and every user-state notice relists all
✅ Quality:
|
| Auto-apply | Compact |
|
|
Was this helpful? React with 👍 / 👎 | Gitar
Requested by Jake · project thread
Part of FIX-2579 (problems 2 and 3 of the widened issue). The label fix (problem 4) shipped in #4813. Problem 1, a finished run marked Failed, waits on the error text from Jake's run and gets its own PR.
Problem
A failed thread lands under Waiting on you (
columnOf:errored → waiting), and its view offers only Retry. A failure you've already read, or one whose work landed anyway (Jake's "Align task info to flyout popup", which opened #4798), stays in your list, and in the session's "N waiting on you" count, indefinitely.Change
This builds the option recommended on Jake's decision card in the thread. If he picks another option, this PR changes or closes.
dismissalsflow (workforce/flows/dismissals.mts). Each one is keyed by task id and attempt (dismissalKey), so a retry that fails again waits on you again.pinsanddismissalsnow declare one schema (workforce/flows/user-marks.mts). With two separate schemas the server warned at startup that "Flows pins and dismissals declare structurally compatible but non-identical user.stateSchema schemas".listTasksrows keepattempts, which the adapter used to drop. The sessions list also listens on your user topic, so a dismissal updates the count without a reload.Decided, not asked: Dismiss has no undo. A dismissed failure is still in Resolved, and Retry still works from its view.
Verification
columnOfandwaitingOnYoudismissal cases, the threads-screen Dismiss flow, and twowatchSessionscases). With the change, the lab suite passes: 32 files, 224 tests.tscand eslint are clean.fsdev serveon this config, stub harness):dismiss {key:"t1#1"}completes,listDismissedreads["t1#1"], pins in the same user state read back unchanged (["t9"]), and the schema warning is gone.No changeset: private lab. The lab README rows for the board's columns and the adapter table now cover dismissals.
Generated by Claude Code