Repository navigation
fix(harness-manager): a run that opened a pull request waits on it, whatever the judge reads (FIX-2579) - #4990
Conversation
…hatever the judge reads (FIX-2579) With awaitPullRequests on, settle read the judge's verdict before the task's pull requests, so a confident not-done failed a run whose work had landed as a pull request. The pull requests are now read first: a run that opened one settles on it, and the judge's reason goes in a status note. A run with no pull request, or with the option off, still fails on a confident not-done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDusxC39h1dkbTPtPC
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture notesSmall, targeted diff. The approach (let the PR reviewer be the check when a PR exists) is reasonable and the leaner shape is basically what's here. A few things for the implementing agent to weigh: 1. 2. The 3. 4. Tests: confirm the red state. The new tests in 5. Housekeeping (minor).
Architecture (improve-codebase-architecture lens): No blocking correctness bugs found; points 1 and 4 are the ones I'd want addressed before merge. Generated by Claude Code |
Code Review ✅ Approved🟡 Medium risk · With awaitPullRequests, deferring a confident not-done judgment when a run opened a PR could leave ineffective work waiting for review instead of retrying. Reorders VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Requested by Jake · project thread
Problem
FIX-2579, problem 1 (wrong outcome). A coding task that pushed and opened a PR (#4798) was marked Failed. With
awaitPullRequestson,settlechecked the goal judge before the task's pull requests. So a confidentnot-done(≥ floor) threwthe judge found the task not done: …even though the work had landed as a PR. That's likely in this scene: after a revise turn, the final message is about the push and PR, not the change.Fix
settlenow reads the task's pull requests first. If the run opened one, the task waits on that PR as FIX-2578 intended, and the judge's reason goes in a status note. A run that opened no PR still fails on a confidentnot-done. With the option off, nothing changes.Evidence
test/await-pull-requests.spec.ts→ "a judged run that opened a pull request". The run records its own PR from a renamed branch, and the judge saysnot-doneat 0.8.pendingwith feedbackthe judge found the task not done: ….in_progress, onesystem/externalhold).@flow-state-dev/harness-manager: 545/545 tests pass. Typecheck passes through turbo.Not in this PR
the run stopped without finishing, the cause is indecide, not the judge, and this fix doesn't cover it.Changeset:
judge-defers-to-pull-request.md(harness-manager patch).Generated by Claude Code