Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[iOS] Avoid jitter and laggy when user is dragging on iOS Promotion devices #35592

Merged
auto-submit merged 13 commits into from
Sep 7, 2022
Merged

[iOS] Avoid jitter and laggy when user is dragging on iOS Promotion devices #35592

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1b1b2d7
Add code in FlutterViewController and VSyncClient
luckysmg Aug 19, 2022
b655406
Add tests
luckysmg Aug 20, 2022
8e93dae
Add tests
luckysmg Aug 20, 2022
85bc1b5
Optimize code
luckysmg Aug 20, 2022
ba09d7c
Modify test
luckysmg Aug 20, 2022
59000d6
Merge branch 'main' into touch_trigger
luckysmg Aug 22, 2022
47abf4e
nits
luckysmg Aug 23, 2022
c6b77a9
nits
luckysmg Aug 26, 2022
4bf7f3f
nits
luckysmg Aug 27, 2022
8fceea1
Merge branch 'flutter:main' into touch_trigger
luckysmg Aug 27, 2022
2cd6988
nits
luckysmg Aug 31, 2022
2bc5880
nits
luckysmg Sep 7, 2022
72b3ff7
Merge branch 'flutter:main' into touch_trigger
luckysmg Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nits
  • Loading branch information
@luckysmg
luckysmg committed Aug 27, 2022
commit 4bf7f3f3876694f9873556f024bee8f202b48681
11 changes: 8 additions & 3 deletions shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ @interface FlutterViewController () <FlutterBinaryMessenger, UIScrollViewDelegat
@property(nonatomic, assign) double targetViewInsetBottom;
@property(nonatomic, retain) VSyncClient* keyboardAnimationVSyncClient;

/// VSyncClient for touch callback's rate correction.
/// VSyncClient for touch events delivery frame rate correction.
///
/// On promotion devices(eg: iPhone13 Pro), the delivery frame rate of touch events is 60HZ
/// but the frame rate of rendering is 120HZ, which is different and will leads junk and laggy.
/// With this VSyncClient, we can correct the delivery frame rate of touch events to let it keep
Copy link
Member

@knopp knopp Aug 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use we in comments.

Copy link
Contributor Author

@luckysmg luckysmg Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done^_^

/// the same with frame rate of rendering.
@property(nonatomic, retain) VSyncClient* touchRateCorrectionVSyncClient;
Copy link
Member

@knopp knopp Aug 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is VSyncClient necessary here? Since this is just for increasing resolution of touch events and doesn't directly affect rendering, should we just use CADisplayLink directly?

Copy link
Contributor

@cyanglaz cyanglaz Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using VSyncClient ensures the preferred frame rate that used is the same as the one used on UIThread.


/*
Expand Down Expand Up @@ -674,7 +679,7 @@ - (void)viewDidLoad {
// Register internal plugins.
[self addInternalPlugins];

// Create a vsync client to correct touch rate if needed.
// Create a vsync client to correct delivery frame rate of touch events if needed.
[self createTouchRateCorrectionVSyncClientIfNeeded];

if (@available(iOS 13.4, *)) {
Expand Down Expand Up @@ -973,7 +978,7 @@ - (void)dispatchTouches:(NSSet*)touches
}
}

// Activate or pause touch rate correction according to the touches when user is interacting.
// Activate or pause the correction of delivery frame rate of touch events.
[self triggerTouchRateCorrectionIfNeeded:touches];

const CGFloat scale = [UIScreen mainScreen].scale;
Expand Down