Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more to the message.
  • Loading branch information
matanlurey committed Mar 26, 2024
commit 448ac658eab8d1d049b89c858e694c45ad07b60c
8 changes: 6 additions & 2 deletions testing/skia_gold_client/lib/src/errors.dart
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ final class SkiaGoldProcessError extends Error {
/// Error thrown when the Skia Gold process exits due to a negative image.
final class SkiaGoldNegativeImageError extends SkiaGoldProcessError {
/// Creates a new [SkiaGoldNegativeImageError] from the provided origin.
///
///
/// See [SkiaGoldProcessError.new] for more information.
SkiaGoldNegativeImageError({
required this.testName,
Expand All @@ -68,5 +68,9 @@ final class SkiaGoldNegativeImageError extends SkiaGoldProcessError {
final String testName;

@override
String get message => 'Negative image detected for test: "$testName"';
String get message => 'Negative image detected for test: "$testName".\n\n'
'The flutter/engine workflow should never produce negative images; it is '
'possible that someone accidentally (or without knowing our policy) '
'marked a test as negative.\n\n'
'See https://github.com/flutter/flutter/issues/145043 for details.';
}