Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fail pre-submit if a negative image is encountered as part of goldctl imgtest add. #51685

Merged
auto-submit merged 5 commits into from
Mar 27, 2024
Merged

Fail pre-submit if a negative image is encountered as part of goldctl imgtest add. #51685

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d891112
Fail pre-submit during a negative image digest.
matanlurey Mar 26, 2024
448ac65
Add more to the message.
matanlurey Mar 26, 2024
9880f80
Format.
matanlurey Mar 26, 2024
94b82a4
Update testing/skia_gold_client/test/skia_gold_client_test.dart
matanlurey Mar 26, 2024
4ed1878
++
matanlurey Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format.
  • Loading branch information
@matanlurey
matanlurey committed Mar 26, 2024
commit 9880f80a5ee9aba7196b78baea6f19aaf8186246
2 changes: 1 addition & 1 deletion testing/skia_gold_client/lib/skia_gold_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ interface class SkiaGoldClient {
..writeln('stdout:\n$resultStdout');
return;
}

// Negative images are considered failures during tryjobs.
//
// We don't actually use negative images as part of our workflow, but
Expand Down